[GitHub] [kafka] jsancio commented on a diff in pull request #12885: KAFKA-14358; Disallow creation of cluster metadata partition

[GitBox <gi...@apache.org>]

jsancio commented on code in PR #12885:
URL: https://github.com/apache/kafka/pull/12885#discussion_r1035279719


##########
core/src/main/scala/kafka/server/ControllerApis.scala:
##########
@@ -400,7 +407,8 @@ class ControllerApis(val requestChannel: RequestChannel,
         if (!authorizedTopicNames.contains(name)) {
           response.topics().add(new CreatableTopicResult().
             setName(name).
-            setErrorCode(TOPIC_AUTHORIZATION_FAILED.code))
+            setErrorCode(TOPIC_AUTHORIZATION_FAILED.code).
+            setErrorMessage("Authorization failed."))

Review Comment:
   @hachikuji Mainly because the ZK implementation returns this error message. For the test that I added in this PR, I want it to succeed in both mode (ZK and KRaft). For this, I need to either add this error message to the KRaft impl or remove this message from the ZK impl. This seems like the more backward compatible change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org