[GitHub] [spark] LuciferYang commented on a diff in pull request #41491: [SPARK-43991][CORE][WEBUI] Use the value of spark.eventLog.compression.codec set by user when write compact file

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #41491:
URL: https://github.com/apache/spark/pull/41491#discussion_r1221780405


##########
core/src/test/scala/org/apache/spark/deploy/history/EventLogFileCompactorSuite.scala:
##########
@@ -283,6 +284,24 @@ class EventLogFileCompactorSuite extends SparkFunSuite {
     }
   }
 
+  test("Use the value of spark.eventLog.compression.codec set by user") {

Review Comment:
   Check this test without change of `EventLogFileWriters.scala`  and `EventLogFileCompactor.scala`, the new test cases will also pass. Can you check the design of the new test? If this is a bug fix, the new test should fail without change of `EventLogFileWriters.scala`  and `EventLogFileCompactor.scala`
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org