You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/15 02:07:41 UTC
[GitHub] [apisix-website] guoqqqi opened a new pull request #414: feat: Add home page lead window for 200 contributors blogs
guoqqqi opened a new pull request #414:
URL: https://github.com/apache/apisix-website/pull/414
Fixes: #[Add issue number here]
Changes:
<!-- Add here what changes were made in this pull request and if possible provide links showcasing the changes. -->
This PR added a homepage guide window for 200 contributors blogs.
Screenshots of the change:
<!-- Add screenshots depicting the changes. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
👷 Deploy Preview for *apisix* processing.
🔨 Explore the source changes: 881db2316e874ad2365c4d098cd5e5fc4b89b2c5
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f038bf39ac0600078d0262](https://app.netlify.com/sites/apisix/deploys/60f038bf39ac0600078d0262?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
👷 Deploy Preview for *apisix* processing.
🔨 Explore the source changes: c91568776a932835b93fc47270f987000625ae6c
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f1558237eccd0007c11dfb](https://app.netlify.com/sites/apisix/deploys/60f1558237eccd0007c11dfb?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi closed pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
guoqqqi closed pull request #414:
URL: https://github.com/apache/apisix-website/pull/414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
👷 Deploy Preview for *apisix* processing.
🔨 Explore the source changes: e51509873f4ea83f79098e8d98eae7e27cc2b1cf
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f0ef9b1f348a0007fddf3f](https://app.netlify.com/sites/apisix/deploys/60f0ef9b1f348a0007fddf3f?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
✔️ Deploy Preview for *apisix* ready!
🔨 Explore the source changes: 05a8c2cd79fdcebac693d6f20e5a4ba50d6ed941
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f151662f62e60007b8d89c](https://app.netlify.com/sites/apisix/deploys/60f151662f62e60007b8d89c?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-414--apisix.netlify.app](https://deploy-preview-414--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880808552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
👷 Deploy Preview for *apisix* processing.
🔨 Explore the source changes: 53e360830e49402cd680386cebebfa10cefd7a12
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f1332b020e0e00087bfd7d](https://app.netlify.com/sites/apisix/deploys/60f1332b020e0e00087bfd7d?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
✔️ Deploy Preview for *apisix* ready!
🔨 Explore the source changes: e51509873f4ea83f79098e8d98eae7e27cc2b1cf
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f0ef9b1f348a0007fddf3f](https://app.netlify.com/sites/apisix/deploys/60f0ef9b1f348a0007fddf3f?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-414--apisix.netlify.app](https://deploy-preview-414--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on a change in pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#discussion_r670470777
##########
File path: website/src/pages/index.js
##########
@@ -261,22 +261,23 @@ const NewsletterSection = () => {
const PicPoster = () => {
const [display, setDisplay] = useState(true);
const [theme, setTheme] = useState('light');
+ const windowGlobal = typeof window !== 'undefined' && window
Review comment:
Just do window.getItem inside useEffect instead of this. This will always put undefined on windowGlobal at build as window is not defined when SSR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
✔️ Deploy Preview for *apisix* ready!
🔨 Explore the source changes: b835fb15e47d26af775b75936d72e0ddcf996bfa
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f0560ab37f9d0007c49702](https://app.netlify.com/sites/apisix/deploys/60f0560ab37f9d0007c49702?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-414--apisix.netlify.app](https://deploy-preview-414--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on a change in pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#discussion_r670771341
##########
File path: website/src/pages/index.js
##########
@@ -258,9 +258,46 @@ const NewsletterSection = () => {
);
};
+const PicPoster = () => {
+ const [display, setDisplay] = useState(true);
+ const [theme, setTheme] = useState('light');
+
+ useEffect(() => {
+ addEventListener('click', () => {
+ if (localStorage.getItem('theme') !== theme) {
+ setTheme(localStorage.getItem('theme'));
+ };
+ });
+ }, [theme]);
+
+ if (!display || localStorage.getItem('SHOW_200_CONTRIBUTOR_EVENT_ENTRY')) {
+ return false;
+ };
+
+ const onClose = () => {
+ setDisplay(false);
+ localStorage.setItem('SHOW_200_CONTRIBUTOR_EVENT_ENTRY', 'read');
+ };
+
+ return (
+ <div className="pic-wrapper">
+ <button className="pic-wrapper-close" onClick={onClose}>
+ <svg aria-hidden="true" focusable="false" data-prefix="fas" data-icon="times" class="svg-inline--fa fa-times fa-w-11" role="img" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 352 512">
+ <path fill="currentColor" d="M242.72 256l100.07-100.07c12.28-12.28 12.28-32.19 0-44.48l-22.24-22.24c-12.28-12.28-32.19-12.28-44.48 0L176 189.28 75.93 89.21c-12.28-12.28-32.19-12.28-44.48 0L9.21 111.45c-12.28 12.28-12.28 32.19 0 44.48L109.28 256 9.21 356.07c-12.28 12.28-12.28 32.19 0 44.48l22.24 22.24c12.28 12.28 32.2 12.28 44.48 0L176 322.72l100.07 100.07c12.28 12.28 32.2 12.28 44.48 0l22.24-22.24c12.28-12.28 12.28-32.19 0-44.48L242.72 256z"></path>
+ </svg>
+ </button>
+ <a href="/blog/2021/07/06/celebrate-200-contributors" onClick={onClose}>
+ {theme === "light" && <img src="/static/img/pic_poster/200_mark_light.jpg" alt="" />}
+ {theme === "dark" && <img src="/static/img/pic_poster/200_mark_dark.jpg" alt="" />}
Review comment:
For this one too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880876521
> @guoqqqi Cannot see the image, and why you update the yarn.lock??
1. I can't see the image because, for the image link I used
`/static/img/pic_poster/200_mark_light.jpg`
instead of
`https://cdn.jsdelivr.net/gh/apache/apisix-website@/website/static/img/pic_poster/200_mark_light.jpg`
Do I need to update it?
2. I just ran
```shell
yarn
yarn start
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
👷 Deploy Preview for *apisix* processing.
🔨 Explore the source changes: 52ef086d53c355fcad2ed705c90642b2c2a5bf6f
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f12e3221cd72000782bad6](https://app.netlify.com/sites/apisix/deploys/60f12e3221cd72000782bad6?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
👷 Deploy Preview for *apisix* processing.
🔨 Explore the source changes: e3e31ca2bf20417b4715b19f1eb0591a9473636a
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f13066f809220008b1bfae](https://app.netlify.com/sites/apisix/deploys/60f13066f809220008b1bfae?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
✔️ Deploy Preview for *apisix* ready!
🔨 Explore the source changes: 53e360830e49402cd680386cebebfa10cefd7a12
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f1332b020e0e00087bfd7d](https://app.netlify.com/sites/apisix/deploys/60f1332b020e0e00087bfd7d?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-414--apisix.netlify.app](https://deploy-preview-414--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
👷 Deploy Preview for *apisix* processing.
🔨 Explore the source changes: b835fb15e47d26af775b75936d72e0ddcf996bfa
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f0560ab37f9d0007c49702](https://app.netlify.com/sites/apisix/deploys/60f0560ab37f9d0007c49702?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #414:
URL: https://github.com/apache/apisix-website/pull/414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
✔️ Deploy Preview for *apisix* ready!
🔨 Explore the source changes: 52ef086d53c355fcad2ed705c90642b2c2a5bf6f
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f12e3221cd72000782bad6](https://app.netlify.com/sites/apisix/deploys/60f12e3221cd72000782bad6?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-414--apisix.netlify.app](https://deploy-preview-414--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880680128
Hi, @iamayushdas Do you understand the reasons for failure in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#discussion_r671095017
##########
File path: website/src/pages/index.js
##########
@@ -258,9 +258,48 @@ const NewsletterSection = () => {
);
};
+const PicPoster = () => {
Review comment:
```suggestion
const Contributor200Poster = () => {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
👷 Deploy Preview for *apisix* processing.
🔨 Explore the source changes: 05a8c2cd79fdcebac693d6f20e5a4ba50d6ed941
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f151662f62e60007b8d89c](https://app.netlify.com/sites/apisix/deploys/60f151662f62e60007b8d89c?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on a change in pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#discussion_r670470777
##########
File path: website/src/pages/index.js
##########
@@ -261,22 +261,23 @@ const NewsletterSection = () => {
const PicPoster = () => {
const [display, setDisplay] = useState(true);
const [theme, setTheme] = useState('light');
+ const windowGlobal = typeof window !== 'undefined' && window
Review comment:
Just do window.localStorage.getItem inside useEffect instead of this. This will always put undefined on windowGlobal at build as window is not defined when SSR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
👷 Deploy Preview for *apisix* processing.
🔨 Explore the source changes: ad795c221cca0a82666e41e0494912fd24aa9d99
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60ef98659ed48b00081b10d6](https://app.netlify.com/sites/apisix/deploys/60ef98659ed48b00081b10d6?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
✔️ Deploy Preview for *apisix* ready!
🔨 Explore the source changes: 203c651b77accf6ccd7b8b8a6c95c4621c0b206c
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f15609f7e053000733fd31](https://app.netlify.com/sites/apisix/deploys/60f15609f7e053000733fd31?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-414--apisix.netlify.app](https://deploy-preview-414--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on a change in pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#discussion_r670487447
##########
File path: website/src/pages/index.js
##########
@@ -261,22 +261,23 @@ const NewsletterSection = () => {
const PicPoster = () => {
const [display, setDisplay] = useState(true);
const [theme, setTheme] = useState('light');
+ const windowGlobal = typeof window !== 'undefined' && window
Review comment:
I guess one solution could be to use useRef hook and put it on the button, then target event of click inside useEffect. Like classic ref.current.addEventListener()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
👷 Deploy Preview for *apisix* processing.
🔨 Explore the source changes: f55ee71c409f38fef2fa7aa86e2eceba3474d3f3
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60ef9a01d3130e0007d45622](https://app.netlify.com/sites/apisix/deploys/60ef9a01d3130e0007d45622?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] guoqqqi commented on a change in pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#discussion_r670473131
##########
File path: website/src/pages/index.js
##########
@@ -261,22 +261,23 @@ const NewsletterSection = () => {
const PicPoster = () => {
const [display, setDisplay] = useState(true);
const [theme, setTheme] = useState('light');
+ const windowGlobal = typeof window !== 'undefined' && window
Review comment:
Hi, what should we do with the localStorage that is not on the hook?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
✔️ Deploy Preview for *apisix* ready!
🔨 Explore the source changes: cdeeb11ebba2352e091e1a22353cfb7ba7d60755
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f138b07706c30007b8a7fb](https://app.netlify.com/sites/apisix/deploys/60f138b07706c30007b8a7fb?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-414--apisix.netlify.app](https://deploy-preview-414--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
👷 Deploy Preview for *apisix* processing.
🔨 Explore the source changes: cdeeb11ebba2352e091e1a22353cfb7ba7d60755
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f138b07706c30007b8a7fb](https://app.netlify.com/sites/apisix/deploys/60f138b07706c30007b8a7fb?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880332698
✔️ Deploy Preview for *apisix* ready!
🔨 Explore the source changes: e3e31ca2bf20417b4715b19f1eb0591a9473636a
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix/deploys/60f13066f809220008b1bfae](https://app.netlify.com/sites/apisix/deploys/60f13066f809220008b1bfae?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-414--apisix.netlify.app](https://deploy-preview-414--apisix.netlify.app?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#issuecomment-880867452
@guoqqqi Cannot see the image, and why you update the yarn.lock??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] 1502shivam-singh commented on a change in pull request #414: feat: Add home page lead window for 200 contributors blogs
Posted by GitBox <gi...@apache.org>.
1502shivam-singh commented on a change in pull request #414:
URL: https://github.com/apache/apisix-website/pull/414#discussion_r670771140
##########
File path: website/src/pages/index.js
##########
@@ -258,9 +258,46 @@ const NewsletterSection = () => {
);
};
+const PicPoster = () => {
+ const [display, setDisplay] = useState(true);
+ const [theme, setTheme] = useState('light');
+
+ useEffect(() => {
+ addEventListener('click', () => {
+ if (localStorage.getItem('theme') !== theme) {
+ setTheme(localStorage.getItem('theme'));
+ };
+ });
+ }, [theme]);
+
+ if (!display || localStorage.getItem('SHOW_200_CONTRIBUTOR_EVENT_ENTRY')) {
+ return false;
+ };
+
+ const onClose = () => {
+ setDisplay(false);
+ localStorage.setItem('SHOW_200_CONTRIBUTOR_EVENT_ENTRY', 'read');
+ };
+
+ return (
+ <div className="pic-wrapper">
+ <button className="pic-wrapper-close" onClick={onClose}>
+ <svg aria-hidden="true" focusable="false" data-prefix="fas" data-icon="times" class="svg-inline--fa fa-times fa-w-11" role="img" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 352 512">
+ <path fill="currentColor" d="M242.72 256l100.07-100.07c12.28-12.28 12.28-32.19 0-44.48l-22.24-22.24c-12.28-12.28-32.19-12.28-44.48 0L176 189.28 75.93 89.21c-12.28-12.28-32.19-12.28-44.48 0L9.21 111.45c-12.28 12.28-12.28 32.19 0 44.48L109.28 256 9.21 356.07c-12.28 12.28-12.28 32.19 0 44.48l22.24 22.24c12.28 12.28 32.2 12.28 44.48 0L176 322.72l100.07 100.07c12.28 12.28 32.2 12.28 44.48 0l22.24-22.24c12.28-12.28 12.28-32.19 0-44.48L242.72 256z"></path>
+ </svg>
+ </button>
+ <a href="/blog/2021/07/06/celebrate-200-contributors" onClick={onClose}>
+ {theme === "light" && <img src="/static/img/pic_poster/200_mark_light.jpg" alt="" />}
Review comment:
Put `200_mark_light.jpg` inside the src folder in the asset directory, or serve it by cdn.
As you can see - https://deploy-preview-414--apisix.netlify.app/static/img/pic_poster/200_mark_light.jpg leads to 404 after build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org