You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/07/28 16:46:26 UTC
[GitHub] [maven-plugin-tools] slawekjaranowski opened a new pull request, #129: [MPLUGIN-408] helpmojo improvement
slawekjaranowski opened a new pull request, #129:
URL: https://github.com/apache/maven-plugin-tools/pull/129
- use groupId + artifactId for calculating package name
- discover mojos only ones by descriptor mojo
- simplify in AbstractGeneratorMojo
- remove unneeded code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #129: [MPLUGIN-408] helpmojo improvement
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #129:
URL: https://github.com/apache/maven-plugin-tools/pull/129#issuecomment-1200270387
Nobody wants to look?
If need more time let me know.
Failed build on jenkins on branch which was removed when PR has been created ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski merged pull request #129: [MPLUGIN-408] helpmojo improvement
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #129:
URL: https://github.com/apache/maven-plugin-tools/pull/129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #129: [MPLUGIN-408] helpmojo improvement
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #129:
URL: https://github.com/apache/maven-plugin-tools/pull/129#discussion_r950088022
##########
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java:
##########
@@ -45,6 +42,8 @@
import org.codehaus.plexus.util.xml.PrettyPrintXMLWriter;
import org.codehaus.plexus.util.xml.XMLWriter;
+import static java.nio.charset.StandardCharsets.UTF_8;
Review Comment:
old item, import reorder ...
used in lines: 101, 103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #129: [MPLUGIN-408] helpmojo improvement
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #129:
URL: https://github.com/apache/maven-plugin-tools/pull/129#discussion_r950089632
##########
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java:
##########
@@ -45,6 +42,8 @@
import org.codehaus.plexus.util.xml.PrettyPrintXMLWriter;
import org.codehaus.plexus.util.xml.XMLWriter;
+import static java.nio.charset.StandardCharsets.UTF_8;
Review Comment:
checkstyle takes care about unused imports
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on pull request #129: [MPLUGIN-408] helpmojo improvement
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #129:
URL: https://github.com/apache/maven-plugin-tools/pull/129#issuecomment-1220556181
Update commit message:
- use groupId + artifactId for calculating package name
- discover mojos only once by descriptor mojo
- simplify AbstractGeneratorMojo
- remove unneeded code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on pull request #129: [MPLUGIN-408] helpmojo improvement
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #129:
URL: https://github.com/apache/maven-plugin-tools/pull/129#issuecomment-1200273612
> Nobody wants to look? If need more time let me know.
>
> Failed build on jenkins on branch which was removed when PR has been created ...
Massive change, takes time. It is weekend also...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #129: [MPLUGIN-408] helpmojo improvement
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #129:
URL: https://github.com/apache/maven-plugin-tools/pull/129#issuecomment-1214441848
kindly reminder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-plugin-tools] michael-o commented on a diff in pull request #129: [MPLUGIN-408] helpmojo improvement
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #129:
URL: https://github.com/apache/maven-plugin-tools/pull/129#discussion_r950082424
##########
maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorGenerator.java:
##########
@@ -45,6 +42,8 @@
import org.codehaus.plexus.util.xml.PrettyPrintXMLWriter;
import org.codehaus.plexus.util.xml.XMLWriter;
+import static java.nio.charset.StandardCharsets.UTF_8;
Review Comment:
Where is this used in the diff?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org