You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <da...@elego.de> on 2013/06/24 23:24:31 UTC

Bug: .svn/format deleted upon upgrade

% /usr/local/svn-1.7.1/bin/svn co -q https://svn.apache.org/repos/asf/subversion/trunk/notes/commit-access-templates/
% ls commit-access-templates/.svn
entries  format  pristine  tmp  wc.db
% svn upgrade commit-access-templates
% ls commit-access-templates/.svn
pristine  tmp  wc.db

That's a bug: the 'format' file needs to stay (with value "12\n") so
that 1.6 clients recognize the working copy as a working copy.  There
also exists third-party code[1] which relies on the existence of
.svn/format to identify working copies efficiently.

Haven't looked yet into a fix.

Daniel


[1] specifically, the zsh plugin vcs_info - which can be used eg to show
wc information in the prompt when cd'd into a wc.

Re: Bug: .svn/format deleted upon upgrade

Posted by Branko Čibej <br...@wandisco.com>.
On 25.06.2013 00:03, Branko Čibej wrote:
> On 24.06.2013 23:52, Branko Čibej wrote:
>> On 24.06.2013 23:24, Daniel Shahaf wrote:
>>> % /usr/local/svn-1.7.1/bin/svn co -q https://svn.apache.org/repos/asf/subversion/trunk/notes/commit-access-templates/
>>> % ls commit-access-templates/.svn
>>> entries  format  pristine  tmp  wc.db
>>> % svn upgrade commit-access-templates
>>> % ls commit-access-templates/.svn
>>> pristine  tmp  wc.db
>>>
>>> That's a bug: the 'format' file needs to stay (with value "12\n") so
>>> that 1.6 clients recognize the working copy as a working copy.  There
>>> also exists third-party code[1] which relies on the existence of
>>> .svn/format to identify working copies efficiently.
>>>
>>> Haven't looked yet into a fix.
>> And the entries file needs to remain there, too. A version-12 format
>> file and a 3-byte entries file (containing just "12\n") are breadcrumbs
>> for pre-1.7 clients. What's more, when we create a new working copy, we
>> create those files, too.
> It would appear that the bug is just about as old as WC-NG itself.
>

Hm, actually, that's not the case at all ... those files are supposed to
be installed during a post-upgrade workqueue run. The
closest-to-doubtful revision I could find is r1357558, which reorders
the workqueue items; but it doesn't seem to cause this bug at first glance.

-- Brane

-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane@wandisco.com

Re: Bug: .svn/format deleted upon upgrade

Posted by Branko Čibej <br...@wandisco.com>.
On 24.06.2013 23:52, Branko Čibej wrote:
> On 24.06.2013 23:24, Daniel Shahaf wrote:
>> % /usr/local/svn-1.7.1/bin/svn co -q https://svn.apache.org/repos/asf/subversion/trunk/notes/commit-access-templates/
>> % ls commit-access-templates/.svn
>> entries  format  pristine  tmp  wc.db
>> % svn upgrade commit-access-templates
>> % ls commit-access-templates/.svn
>> pristine  tmp  wc.db
>>
>> That's a bug: the 'format' file needs to stay (with value "12\n") so
>> that 1.6 clients recognize the working copy as a working copy.  There
>> also exists third-party code[1] which relies on the existence of
>> .svn/format to identify working copies efficiently.
>>
>> Haven't looked yet into a fix.
> And the entries file needs to remain there, too. A version-12 format
> file and a 3-byte entries file (containing just "12\n") are breadcrumbs
> for pre-1.7 clients. What's more, when we create a new working copy, we
> create those files, too.

It would appear that the bug is just about as old as WC-NG itself.

-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane@wandisco.com

Re: Bug: .svn/format deleted upon upgrade

Posted by Branko Čibej <br...@wandisco.com>.
On 24.06.2013 23:24, Daniel Shahaf wrote:
> % /usr/local/svn-1.7.1/bin/svn co -q https://svn.apache.org/repos/asf/subversion/trunk/notes/commit-access-templates/
> % ls commit-access-templates/.svn
> entries  format  pristine  tmp  wc.db
> % svn upgrade commit-access-templates
> % ls commit-access-templates/.svn
> pristine  tmp  wc.db
>
> That's a bug: the 'format' file needs to stay (with value "12\n") so
> that 1.6 clients recognize the working copy as a working copy.  There
> also exists third-party code[1] which relies on the existence of
> .svn/format to identify working copies efficiently.
>
> Haven't looked yet into a fix.

And the entries file needs to remain there, too. A version-12 format
file and a 3-byte entries file (containing just "12\n") are breadcrumbs
for pre-1.7 clients. What's more, when we create a new working copy, we
create those files, too.

-- Brane

-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane@wandisco.com