[arrow] branch master updated: ARROW-5544: [Archery] Don't return non-zero on regressions

[ks...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

kszucs pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new f838c99  ARROW-5544: [Archery] Don't return non-zero on regressions
f838c99 is described below

commit f838c995c5b4fd81b0c7ec5d78ed6564f963a9ca
Author: François Saint-Jacques <fs...@gmail.com>
AuthorDate: Tue Jun 11 13:19:27 2019 +0200

    ARROW-5544: [Archery] Don't return non-zero on regressions
    
    The return code should be used to return when the command did not
    execute successfully. In this case, the command did run without issues,
    we leave to the calling user to decide what to do with the data.
    
    This will simplify integration with ursabot CI.
    
    Author: François Saint-Jacques <fs...@gmail.com>
    
    Closes #4512 from fsaintjacques/ARROW-5544-archery-benchmark-diff-return-code and squashes the following commits:
    
    b22231356 <François Saint-Jacques> ARROW-5544:  don't return non-zero on regressions
---
 dev/archery/archery/cli.py | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/dev/archery/archery/cli.py b/dev/archery/archery/cli.py
index 8f0f1ad..f334b03 100644
--- a/dev/archery/archery/cli.py
+++ b/dev/archery/archery/cli.py
@@ -383,17 +383,13 @@ def benchmark_diff(ctx, src, preserve, suite_filter, benchmark_filter,
             src, root, baseline, conf,
             suite_filter=suite_filter, benchmark_filter=benchmark_filter)
 
-        regressions = 0
         runner_comp = RunnerComparator(runner_cont, runner_base, threshold)
 
         # TODO(kszucs): test that the output is properly formatted jsonlines
         for comparator in runner_comp.comparisons:
-            regressions += comparator.regression
             json.dump(comparator, output, cls=JsonEncoder)
             output.write("\n")
 
-        sys.exit(regressions)
-
 
 if __name__ == "__main__":
     archery(obj={})