You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/30 07:10:00 UTC

[GitHub] [pulsar] saosir edited a comment on pull request #8606: [C++] fix cpp client do AcknowledgeCumulative not clean up previous message

saosir edited a comment on pull request #8606:
URL: https://github.com/apache/pulsar/pull/8606#issuecomment-735593147


   1. Both `PartitionedConsumerImpl` and `ConsumerImpl` have member variable `unAckedMessageTrackerPtr_` (class `UnAckedMessageTrackerEnabled`), and `PartitionedConsumerImpl` is composed of `ConsumerImpl`. if the acknowledgement times out, will they send redeliverMessages repeatedly?
   2. in `UnAckedMessageTrackerEnabled`,  param msg of `UnAckedMessageTrackerEnabled::add` contain `partition`, `ledgerId`, `entryId`,`batchIndex`. When ack timeout and do `redeliverUnacknowledgedMessages`, does it deduplicte based on ledger and entryId?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org