You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ws.apache.org by co...@apache.org on 2019/01/22 12:15:40 UTC
svn commit: r1851808 - in /webservices/wss4j/trunk:
performance/src/test/java/org/apache/wss4j/performance/
policy/src/main/java/org/apache/wss4j/policy/model/
ws-security-common/src/main/java/org/apache/wss4j/common/util/
ws-security-stax/src/test/jav...
Author: coheigea
Date: Tue Jan 22 12:15:39 2019
New Revision: 1851808
URL: http://svn.apache.org/viewvc?rev=1851808&view=rev
Log:
Replacing String equals to "" with isEmpty
Modified:
webservices/wss4j/trunk/performance/src/test/java/org/apache/wss4j/performance/AbstractTestBase.java
webservices/wss4j/trunk/policy/src/main/java/org/apache/wss4j/policy/model/NSStack.java
webservices/wss4j/trunk/ws-security-common/src/main/java/org/apache/wss4j/common/util/NSStack.java
webservices/wss4j/trunk/ws-security-stax/src/test/java/org/apache/wss4j/stax/test/AbstractTestBase.java
Modified: webservices/wss4j/trunk/performance/src/test/java/org/apache/wss4j/performance/AbstractTestBase.java
URL: http://svn.apache.org/viewvc/webservices/wss4j/trunk/performance/src/test/java/org/apache/wss4j/performance/AbstractTestBase.java?rev=1851808&r1=1851807&r2=1851808&view=diff
==============================================================================
--- webservices/wss4j/trunk/performance/src/test/java/org/apache/wss4j/performance/AbstractTestBase.java (original)
+++ webservices/wss4j/trunk/performance/src/test/java/org/apache/wss4j/performance/AbstractTestBase.java Tue Jan 22 12:15:39 2019
@@ -395,7 +395,7 @@ public abstract class AbstractTestBase {
* defined in the deployment descriptor takes precedence.
*/
reqData.setUsername((String) getOption(WSHandlerConstants.USER));
- if (reqData.getUsername() == null || reqData.getUsername().equals("")) {
+ if (reqData.getUsername() == null || reqData.getUsername().isEmpty()) {
reqData.setUsername((String) mc.get(WSHandlerConstants.USER));
}
@@ -413,7 +413,7 @@ public abstract class AbstractTestBase {
break;
}
}
- if (usernameRequired && (reqData.getUsername() == null || reqData.getUsername().equals(""))) {
+ if (usernameRequired && (reqData.getUsername() == null || reqData.getUsername().isEmpty())) {
/*
* We need a username - if none throw a WSSecurityException. For encryption
* there is a specific parameter to get a username.
Modified: webservices/wss4j/trunk/policy/src/main/java/org/apache/wss4j/policy/model/NSStack.java
URL: http://svn.apache.org/viewvc/webservices/wss4j/trunk/policy/src/main/java/org/apache/wss4j/policy/model/NSStack.java?rev=1851808&r1=1851807&r2=1851808&view=diff
==============================================================================
--- webservices/wss4j/trunk/policy/src/main/java/org/apache/wss4j/policy/model/NSStack.java (original)
+++ webservices/wss4j/trunk/policy/src/main/java/org/apache/wss4j/policy/model/NSStack.java Tue Jan 22 12:15:39 2019
@@ -187,7 +187,7 @@ class NSStack {
* find one because "pre" is actually mapped to "otherNamespace"
*/
public String getPrefix(String namespaceURI, boolean noDefault) {
- if (namespaceURI == null || namespaceURI.equals("")) {
+ if (namespaceURI == null || namespaceURI.isEmpty()) {
return null;
}
int hash = namespaceURI.hashCode();
Modified: webservices/wss4j/trunk/ws-security-common/src/main/java/org/apache/wss4j/common/util/NSStack.java
URL: http://svn.apache.org/viewvc/webservices/wss4j/trunk/ws-security-common/src/main/java/org/apache/wss4j/common/util/NSStack.java?rev=1851808&r1=1851807&r2=1851808&view=diff
==============================================================================
--- webservices/wss4j/trunk/ws-security-common/src/main/java/org/apache/wss4j/common/util/NSStack.java (original)
+++ webservices/wss4j/trunk/ws-security-common/src/main/java/org/apache/wss4j/common/util/NSStack.java Tue Jan 22 12:15:39 2019
@@ -198,7 +198,7 @@ public class NSStack {
* find one because "pre" is actually mapped to "otherNamespace"
*/
public String getPrefix(String namespaceURI, boolean noDefault) {
- if (namespaceURI == null || namespaceURI.equals("")) {
+ if (namespaceURI == null || namespaceURI.isEmpty()) {
return null;
}
int hash = namespaceURI.hashCode();
Modified: webservices/wss4j/trunk/ws-security-stax/src/test/java/org/apache/wss4j/stax/test/AbstractTestBase.java
URL: http://svn.apache.org/viewvc/webservices/wss4j/trunk/ws-security-stax/src/test/java/org/apache/wss4j/stax/test/AbstractTestBase.java?rev=1851808&r1=1851807&r2=1851808&view=diff
==============================================================================
--- webservices/wss4j/trunk/ws-security-stax/src/test/java/org/apache/wss4j/stax/test/AbstractTestBase.java (original)
+++ webservices/wss4j/trunk/ws-security-stax/src/test/java/org/apache/wss4j/stax/test/AbstractTestBase.java Tue Jan 22 12:15:39 2019
@@ -407,7 +407,7 @@ public abstract class AbstractTestBase {
* defined in the deployment descriptor takes precedence.
*/
reqData.setUsername((String) getOption(WSHandlerConstants.USER));
- if (reqData.getUsername() == null || reqData.getUsername().equals("")) {
+ if (reqData.getUsername() == null || reqData.getUsername().isEmpty()) {
reqData.setUsername((String) mc.get(WSHandlerConstants.USER));
}
@@ -425,7 +425,7 @@ public abstract class AbstractTestBase {
break;
}
}
- if (usernameRequired && (reqData.getUsername() == null || reqData.getUsername().equals(""))) {
+ if (usernameRequired && (reqData.getUsername() == null || reqData.getUsername().isEmpty())) {
/*
* We need a username - if none throw a WSSecurityException. For encryption
* there is a specific parameter to get a username.