You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2016/09/09 23:06:08 UTC

[Impala-ASF-CR] IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.

Jim Apple has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4361

Change subject: IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.
......................................................................

IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.

While I'm here, fix some of the easier warnings.

Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
---
M LICENSE.txt
M be/.astylerc
M be/src/benchmarks/expr-benchmark.cc
M be/src/experiments/data-provider.cc
M be/src/experiments/hashing/cache-hash-test.cc
M be/src/experiments/hashing/growing-test.cc
M be/src/experiments/hashing/interface/cache-hash-test.cc
M be/src/experiments/hashing/interface/growing-test.cc
M be/src/experiments/hashing/multilevel/cache-hash-test.cc
M be/src/experiments/hashing/multilevel/growing-test.cc
M be/src/experiments/hashing/prefetch/cache-hash-test.cc
M be/src/experiments/hashing/prefetch/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/cache-hash-test.cc
M be/src/experiments/hashing/split-benchmarks/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/partitioning-throughput-test.cc
M be/src/experiments/hashing/streaming/cache-hash-test.cc
M be/src/experiments/hashing/streaming/growing-test.cc
M be/src/testutil/certificates-info.txt
M be/src/util/asan.h
M bin/README-RUNNING-BENCHMARKS
A bin/check-rat-report.py
A bin/rat.sh
A bin/rat_exclude_files.txt
M fe/src/main/java/com/cloudera/impala/analysis/AggregateInfoBase.java
M fe/src/main/java/com/cloudera/impala/analysis/ExprSubstitutionMap.java
M fe/src/main/java/com/cloudera/impala/analysis/PartitionSpec.java
M fe/src/main/java/com/cloudera/impala/catalog/ArrayType.java
M fe/src/main/java/com/cloudera/impala/catalog/MapType.java
M fe/src/main/java/com/cloudera/impala/catalog/StructType.java
M fe/src/main/java/com/cloudera/impala/planner/Planner.java
30 files changed, 582 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/4361/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>

[Impala-ASF-CR] IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.

Jim Apple has uploaded a new patch set (#4).

Change subject: IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.
......................................................................

IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.

While I'm here, fix as many of the warnings as possible.

The instructions on how to run this are in check-rat-report.py:

1. Either download a release candidate or create an archive from your
   git repo using `git archive --prefix=Foo/ -o baz.tar.gz HEAD`

2. Untar and run `java -jar apache-rat-0.12.jar -x . >baz.xml`. Only
   RAT version 0.12 is known to work at this time.

3. `bin/check-rat-report.py bin/rat_exclude_files.txt baz.xml`

Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
---
M LICENSE.txt
M be/.astylerc
M be/.impala.doxy
M be/src/benchmarks/expr-benchmark.cc
M be/src/experiments/data-provider.cc
M be/src/experiments/hashing/cache-hash-test.cc
M be/src/experiments/hashing/growing-test.cc
M be/src/experiments/hashing/interface/cache-hash-test.cc
M be/src/experiments/hashing/interface/growing-test.cc
M be/src/experiments/hashing/multilevel/cache-hash-test.cc
M be/src/experiments/hashing/multilevel/growing-test.cc
M be/src/experiments/hashing/prefetch/cache-hash-test.cc
M be/src/experiments/hashing/prefetch/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/cache-hash-test.cc
M be/src/experiments/hashing/split-benchmarks/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/partitioning-throughput-test.cc
M be/src/experiments/hashing/streaming/cache-hash-test.cc
M be/src/experiments/hashing/streaming/growing-test.cc
M be/src/testutil/certificates-info.txt
M be/src/util/asan.h
M bin/README-RUNNING-BENCHMARKS
D bin/cpplint.py
M bin/impala-ipython
M bin/impala-py.test
M bin/impala-python
M cmake_modules/FindAvro.cmake
M cmake_modules/FindBreakpad.cmake
M cmake_modules/FindBzip2.cmake
M cmake_modules/FindGFlags.cmake
M cmake_modules/FindGLog.cmake
M cmake_modules/FindHDFS.cmake
M cmake_modules/FindJNI.cmake
M cmake_modules/FindLdap.cmake
M cmake_modules/FindLlvm.cmake
M cmake_modules/FindLlvmBinaries.cmake
M cmake_modules/FindLz4.cmake
M cmake_modules/FindOpenSSL.cmake
M cmake_modules/FindPProf.cmake
M cmake_modules/FindRapidJson.cmake
M cmake_modules/FindRe2.cmake
M cmake_modules/FindSnappy.cmake
M cmake_modules/FindThrift.cmake
M cmake_modules/FindZlib.cmake
M fe/src/main/java/com/cloudera/impala/analysis/AggregateInfoBase.java
M fe/src/main/java/com/cloudera/impala/analysis/ExprSubstitutionMap.java
M fe/src/main/java/com/cloudera/impala/analysis/PartitionSpec.java
M fe/src/main/java/com/cloudera/impala/catalog/ArrayType.java
M fe/src/main/java/com/cloudera/impala/catalog/MapType.java
M fe/src/main/java/com/cloudera/impala/catalog/StructType.java
M fe/src/main/java/com/cloudera/impala/planner/Planner.java
M fe/src/test/resources/authz-policy.ini.template
M fe/src/test/resources/hive-log4j.properties.template
M fe/src/test/resources/log4j.properties.template
M infra/python/deps/download_requirements
M infra/python/deps/requirements.txt
M testdata/avro_schema_resolution/create_table.sql
M testdata/bin/cache_tables.py
M testdata/bin/create-mini.sql
M testdata/bin/load-dependent-tables.sql
M testdata/bin/load-hive-builtins.sh
M testdata/bin/run-hive.sh
M testdata/cluster/node_templates/cdh5/etc/init.d/kms
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-common
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-master
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-tserver
M testdata/cluster/node_templates/cdh5/etc/init.d/llama-application
M testdata/cluster/node_templates/common/etc/init.d/common.tmpl
M testdata/cluster/node_templates/common/etc/init.d/hdfs-common
M testdata/cluster/node_templates/common/etc/init.d/hdfs-datanode
M testdata/cluster/node_templates/common/etc/init.d/hdfs-namenode
M testdata/cluster/node_templates/common/etc/init.d/yarn-common
M testdata/cluster/node_templates/common/etc/init.d/yarn-nodemanager
M testdata/cluster/node_templates/common/etc/init.d/yarn-resourcemanager
D testdata/data/mstr/eatwh1/EATWH1-DDL.sql
D testdata/data/mstr/eatwh1/LoadTablesEATWH1.sql
D testdata/data/mstr/eatwh1/csv/COST_MARKET_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/COST_MARKET_DEP.TXT
D testdata/data/mstr/eatwh1/csv/COST_MARKET_DIV.TXT
D testdata/data/mstr/eatwh1/csv/COST_REGION_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/COST_REGION_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/COST_STORE_DEP.TXT
D testdata/data/mstr/eatwh1/csv/COST_STORE_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/FT1.TXT
D testdata/data/mstr/eatwh1/csv/FT10.TXT
D testdata/data/mstr/eatwh1/csv/FT11.TXT
D testdata/data/mstr/eatwh1/csv/FT12.TXT
D testdata/data/mstr/eatwh1/csv/FT13.TXT
D testdata/data/mstr/eatwh1/csv/FT14.TXT
D testdata/data/mstr/eatwh1/csv/FT15.TXT
D testdata/data/mstr/eatwh1/csv/FT17.TXT
D testdata/data/mstr/eatwh1/csv/FT2.TXT
D testdata/data/mstr/eatwh1/csv/FT3.TXT
D testdata/data/mstr/eatwh1/csv/FT4.TXT
D testdata/data/mstr/eatwh1/csv/FT5.TXT
D testdata/data/mstr/eatwh1/csv/FT6.TXT
D testdata/data/mstr/eatwh1/csv/FT7.TXT
D testdata/data/mstr/eatwh1/csv/FT8.TXT
D testdata/data/mstr/eatwh1/csv/FT9.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_CURR.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_ORDERS.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q1_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q1_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q2_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q2_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q3_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q3_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q4_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q4_1998.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_COLOR.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DAY.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DEMOG.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MANAGER.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MARKET.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MONTH.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_PRICEZONE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_QUAL.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_QUARTER.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_SEASON.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_SIZE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STATE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STORE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STYLE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_WEEK.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_WEEKDAY.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/LU_CALL_CTR.TXT
D testdata/data/mstr/eatwh1/csv/LU_CATALOG.TXT
D testdata/data/mstr/eatwh1/csv/LU_CATEGORY.TXT
D testdata/data/mstr/eatwh1/csv/LU_COUNTRY.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUSTOMER.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUST_CITY.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUST_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LU_DATE.TXT
D testdata/data/mstr/eatwh1/csv/LU_DIST_CTR.TXT
D testdata/data/mstr/eatwh1/csv/LU_EMPLOYEE.TXT
D testdata/data/mstr/eatwh1/csv/LU_INCOME.TXT
D testdata/data/mstr/eatwh1/csv/LU_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/LU_MANAGER.TXT
D testdata/data/mstr/eatwh1/csv/LU_MONTH.TXT
D testdata/data/mstr/eatwh1/csv/LU_MONTH_OF_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/LU_ORDER.TXT
D testdata/data/mstr/eatwh1/csv/LU_PROMOTION.TXT
D testdata/data/mstr/eatwh1/csv/LU_PROMO_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LU_PYMT_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LU_QUARTER.TXT
D testdata/data/mstr/eatwh1/csv/LU_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LU_SHIPPER.TXT
D testdata/data/mstr/eatwh1/csv/LU_SUBCATEG.TXT
D testdata/data/mstr/eatwh1/csv/LU_SUPPLIER.TXT
D testdata/data/mstr/eatwh1/csv/LU_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/MNTH_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh1/csv/MSI_STATS_LOG.TXT
D testdata/data/mstr/eatwh1/csv/MSI_STATS_PROP.TXT
D testdata/data/mstr/eatwh1/csv/ORDER_DETAIL.TXT
D testdata/data/mstr/eatwh1/csv/ORDER_FACT.TXT
D testdata/data/mstr/eatwh1/csv/PMT_INVENTORY.TXT
D testdata/data/mstr/eatwh1/csv/PRODUCT_DETAIL.TXT
D testdata/data/mstr/eatwh1/csv/PROMOTIONS.TXT
D testdata/data/mstr/eatwh1/csv/P_DAY_DEC_94.TXT
D testdata/data/mstr/eatwh1/csv/P_MONTH_DEC_93.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_1.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_2.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_3.TXT
D testdata/data/mstr/eatwh1/csv/QTR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh1/csv/REGION_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/REGION_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/REGION_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/REGION_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_COLOR.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_SIZE.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_STYLE.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_LY_LW.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_MTD.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_REGION_MAN.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_STORE_DEMOG.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_STORE_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/REL_CAT_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/RUSH_ORDER.TXT
D testdata/data/mstr/eatwh1/csv/SEPERATE_FACT.TXT
D testdata/data/mstr/eatwh1/csv/STORE_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/STORE_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/STORE_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_93.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_93_HETERO.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_94.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_94_HETERO.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_ORDERS.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_PTMAP.TXT
D testdata/data/mstr/eatwh1/csv/TE_TRANS_STATISTICS.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_DATE_LW_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_DATE_MTD.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_MONTH_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_QUARTER_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_YEAR_LY.TXT
D testdata/data/mstr/eatwh1/csv/YR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/EATWH2-DDL.sql
D testdata/data/mstr/eatwh2/LoadTablesEATWH2.sql
D testdata/data/mstr/eatwh2/csv/BIG_ORDER_FACT.TXT
D testdata/data/mstr/eatwh2/csv/CITY_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_SUBCATEG_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_SUBCATEG_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CUSTOMER_SLS.TXT
D testdata/data/mstr/eatwh2/csv/DAY_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_CURR.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_ORDERS.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q1_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q1_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q2_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q2_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q3_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q3_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q4_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q4_2001.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_EMP_SLS.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_MNTH_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/LU_BRAND.TXT
D testdata/data/mstr/eatwh2/csv/LU_CALL_CTR.TXT
D testdata/data/mstr/eatwh2/csv/LU_CATALOG.TXT
D testdata/data/mstr/eatwh2/csv/LU_CATEGORY.TXT
D testdata/data/mstr/eatwh2/csv/LU_COUNTRY.TXT
D testdata/data/mstr/eatwh2/csv/LU_COUNTRY_MANAGER.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUSTOMER.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_CITY.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_REGION.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_STATE.TXT
D testdata/data/mstr/eatwh2/csv/LU_DAY.TXT
D testdata/data/mstr/eatwh2/csv/LU_DIST_CTR.TXT
D testdata/data/mstr/eatwh2/csv/LU_EMPLOYEE.TXT
D testdata/data/mstr/eatwh2/csv/LU_INCOME.TXT
D testdata/data/mstr/eatwh2/csv/LU_ITEM.TXT
D testdata/data/mstr/eatwh2/csv/LU_MANAGER.TXT
D testdata/data/mstr/eatwh2/csv/LU_MONTH.TXT
D testdata/data/mstr/eatwh2/csv/LU_MONTH_OF_YEAR.TXT
D testdata/data/mstr/eatwh2/csv/LU_ORDER.TXT
D testdata/data/mstr/eatwh2/csv/LU_PROMOTION.TXT
D testdata/data/mstr/eatwh2/csv/LU_PROMO_TYPE.TXT
D testdata/data/mstr/eatwh2/csv/LU_PYMT_TYPE.TXT
D testdata/data/mstr/eatwh2/csv/LU_QUARTER.TXT
D testdata/data/mstr/eatwh2/csv/LU_REGION.TXT
D testdata/data/mstr/eatwh2/csv/LU_SHIPPER.TXT
D testdata/data/mstr/eatwh2/csv/LU_SUBCATEG.TXT
D testdata/data/mstr/eatwh2/csv/LU_SUPPLIER.TXT
D testdata/data/mstr/eatwh2/csv/LU_YEAR.TXT
D testdata/data/mstr/eatwh2/csv/MNTH_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/MSI_STATS_LOG.TXT
D testdata/data/mstr/eatwh2/csv/MSI_STATS_PROP.TXT
D testdata/data/mstr/eatwh2/csv/MTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/ORDER_DETAIL.TXT
D testdata/data/mstr/eatwh2/csv/ORDER_FACT.TXT
D testdata/data/mstr/eatwh2/csv/PMT_INVENTORY.TXT
D testdata/data/mstr/eatwh2/csv/PROMOTIONS.TXT
D testdata/data/mstr/eatwh2/csv/QTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/QTR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/RELATE_PROJECTS_CATEGORIES.TXT
D testdata/data/mstr/eatwh2/csv/REL_CAT_ITEM.TXT
D testdata/data/mstr/eatwh2/csv/REL_GROUPS.TXT
D testdata/data/mstr/eatwh2/csv/REL_USERS_GROUPS.TXT
D testdata/data/mstr/eatwh2/csv/RUSH_ORDER.TXT
D testdata/data/mstr/eatwh2/csv/STATE_REGION_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/STATE_SUBCATEG_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/STATE_SUBCATEG_REGION_SLS.TXT
D testdata/data/mstr/eatwh2/csv/SUBCATEG_MNTH_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/TE_TRANS_STATISTICS.TXT
D testdata/data/mstr/eatwh2/csv/YR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/YTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/YTM_MONTH.TXT
M tests/comparison/conftest.py
M tests/test-hive-udfs/pom.xml
280 files changed, 1,292 insertions(+), 1,648,831 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/4361/4
-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.

Alex Behm has posted comments on this change.

Change subject: IMPALA-4110: Clean up issues found by Apache RAT.
......................................................................


Patch Set 8: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.

Jim Apple has posted comments on this change.

Change subject: IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.
......................................................................


Patch Set 1:

This is only a "PREVIEW", as I am seeking feedback on this approach before I clean up this patch for further review.

-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.

Jim Apple has uploaded a new patch set (#2).

Change subject: IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.
......................................................................

IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.

While I'm here, fix as many of the warnings as possible.

The instructions on how to run this are in check-rat-report.py:

1. Either download a release candidate or create an archive from your
   git repo using `git archive --prefix=Foo/ -o baz.tar.gz HEAD`

2. Untar and run `java -jar apache-rat-0.12.jar -x . >baz.xml`. Only
   RAT version 0.12 is known to work at this time.

3. `bin/check-rat-report.py bin/rat_exclude_files.txt baz.xml`

Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
---
M LICENSE.txt
M be/.astylerc
M be/.impala.doxy
M be/src/benchmarks/expr-benchmark.cc
M be/src/experiments/data-provider.cc
M be/src/experiments/hashing/cache-hash-test.cc
M be/src/experiments/hashing/growing-test.cc
M be/src/experiments/hashing/interface/cache-hash-test.cc
M be/src/experiments/hashing/interface/growing-test.cc
M be/src/experiments/hashing/multilevel/cache-hash-test.cc
M be/src/experiments/hashing/multilevel/growing-test.cc
M be/src/experiments/hashing/prefetch/cache-hash-test.cc
M be/src/experiments/hashing/prefetch/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/cache-hash-test.cc
M be/src/experiments/hashing/split-benchmarks/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/partitioning-throughput-test.cc
M be/src/experiments/hashing/streaming/cache-hash-test.cc
M be/src/experiments/hashing/streaming/growing-test.cc
M be/src/testutil/certificates-info.txt
M be/src/util/asan.h
M bin/README-RUNNING-BENCHMARKS
A bin/check-rat-report.py
D bin/cpplint.py
M bin/impala-ipython
M bin/impala-py.test
M bin/impala-python
A bin/rat_exclude_files.txt
M cmake_modules/FindAvro.cmake
M cmake_modules/FindBreakpad.cmake
M cmake_modules/FindBzip2.cmake
M cmake_modules/FindGFlags.cmake
M cmake_modules/FindGLog.cmake
M cmake_modules/FindHDFS.cmake
M cmake_modules/FindJNI.cmake
M cmake_modules/FindLdap.cmake
M cmake_modules/FindLlvm.cmake
M cmake_modules/FindLlvmBinaries.cmake
M cmake_modules/FindLz4.cmake
M cmake_modules/FindOpenSSL.cmake
M cmake_modules/FindPProf.cmake
M cmake_modules/FindRapidJson.cmake
M cmake_modules/FindRe2.cmake
M cmake_modules/FindSnappy.cmake
M cmake_modules/FindThrift.cmake
M cmake_modules/FindZlib.cmake
M fe/src/main/java/com/cloudera/impala/analysis/AggregateInfoBase.java
M fe/src/main/java/com/cloudera/impala/analysis/ExprSubstitutionMap.java
M fe/src/main/java/com/cloudera/impala/analysis/PartitionSpec.java
M fe/src/main/java/com/cloudera/impala/catalog/ArrayType.java
M fe/src/main/java/com/cloudera/impala/catalog/MapType.java
M fe/src/main/java/com/cloudera/impala/catalog/StructType.java
M fe/src/main/java/com/cloudera/impala/planner/Planner.java
M fe/src/test/resources/authz-policy.ini.template
M fe/src/test/resources/hive-log4j.properties.template
M fe/src/test/resources/log4j.properties.template
M infra/python/deps/download_requirements
M infra/python/deps/requirements.txt
M testdata/avro_schema_resolution/create_table.sql
M testdata/bin/cache_tables.py
M testdata/bin/create-mini.sql
M testdata/bin/load-dependent-tables.sql
M testdata/bin/load-hive-builtins.sh
M testdata/bin/run-hive.sh
M testdata/cluster/node_templates/cdh5/etc/init.d/kms
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-common
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-master
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-tserver
M testdata/cluster/node_templates/cdh5/etc/init.d/llama-application
M testdata/cluster/node_templates/common/etc/init.d/common.tmpl
M testdata/cluster/node_templates/common/etc/init.d/hdfs-common
M testdata/cluster/node_templates/common/etc/init.d/hdfs-datanode
M testdata/cluster/node_templates/common/etc/init.d/hdfs-namenode
M testdata/cluster/node_templates/common/etc/init.d/yarn-common
M testdata/cluster/node_templates/common/etc/init.d/yarn-nodemanager
M testdata/cluster/node_templates/common/etc/init.d/yarn-resourcemanager
M tests/comparison/conftest.py
M tests/test-hive-udfs/pom.xml
77 files changed, 1,473 insertions(+), 4,809 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/4361/2
-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.

Jim Apple has uploaded a new patch set (#7).

Change subject: IMPALA-4110: Clean up issues found by Apache RAT.
......................................................................

IMPALA-4110: Clean up issues found by Apache RAT.

The script and support files are in another patch:

https://gerrit.cloudera.org/#/c/4405/

Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
---
M LICENSE.txt
M be/.astylerc
M be/.impala.doxy
M be/src/benchmarks/expr-benchmark.cc
M be/src/experiments/data-provider.cc
M be/src/experiments/hashing/cache-hash-test.cc
M be/src/experiments/hashing/growing-test.cc
M be/src/experiments/hashing/interface/cache-hash-test.cc
M be/src/experiments/hashing/interface/growing-test.cc
M be/src/experiments/hashing/multilevel/cache-hash-test.cc
M be/src/experiments/hashing/multilevel/growing-test.cc
M be/src/experiments/hashing/prefetch/cache-hash-test.cc
M be/src/experiments/hashing/prefetch/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/cache-hash-test.cc
M be/src/experiments/hashing/split-benchmarks/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/partitioning-throughput-test.cc
M be/src/experiments/hashing/streaming/cache-hash-test.cc
M be/src/experiments/hashing/streaming/growing-test.cc
M be/src/testutil/certificates-info.txt
M be/src/util/asan.h
M bin/README-RUNNING-BENCHMARKS
D bin/cpplint.py
M bin/impala-ipython
M bin/impala-py.test
M bin/impala-python
M cmake_modules/FindAvro.cmake
M cmake_modules/FindBreakpad.cmake
M cmake_modules/FindBzip2.cmake
M cmake_modules/FindGFlags.cmake
M cmake_modules/FindGLog.cmake
M cmake_modules/FindHDFS.cmake
M cmake_modules/FindJNI.cmake
M cmake_modules/FindLdap.cmake
M cmake_modules/FindLlvm.cmake
M cmake_modules/FindLlvmBinaries.cmake
M cmake_modules/FindLz4.cmake
M cmake_modules/FindOpenSSL.cmake
M cmake_modules/FindPProf.cmake
M cmake_modules/FindRapidJson.cmake
M cmake_modules/FindRe2.cmake
M cmake_modules/FindSnappy.cmake
M cmake_modules/FindThrift.cmake
M cmake_modules/FindZlib.cmake
M fe/src/main/java/com/cloudera/impala/analysis/AggregateInfoBase.java
M fe/src/main/java/com/cloudera/impala/analysis/ExprSubstitutionMap.java
M fe/src/main/java/com/cloudera/impala/analysis/PartitionSpec.java
M fe/src/main/java/com/cloudera/impala/catalog/ArrayType.java
M fe/src/main/java/com/cloudera/impala/catalog/MapType.java
M fe/src/main/java/com/cloudera/impala/catalog/StructType.java
M fe/src/main/java/com/cloudera/impala/planner/Planner.java
M fe/src/test/resources/authz-policy.ini.template
M fe/src/test/resources/hive-log4j.properties.template
M fe/src/test/resources/log4j.properties.template
M infra/python/deps/download_requirements
M infra/python/deps/requirements.txt
M testdata/avro_schema_resolution/create_table.sql
M testdata/bin/cache_tables.py
M testdata/bin/create-mini.sql
M testdata/bin/load-dependent-tables.sql
M testdata/bin/load-hive-builtins.sh
M testdata/bin/run-hive.sh
M testdata/cluster/node_templates/cdh5/etc/init.d/kms
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-common
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-master
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-tserver
M testdata/cluster/node_templates/cdh5/etc/init.d/llama-application
M testdata/cluster/node_templates/common/etc/init.d/common.tmpl
M testdata/cluster/node_templates/common/etc/init.d/hdfs-common
M testdata/cluster/node_templates/common/etc/init.d/hdfs-datanode
M testdata/cluster/node_templates/common/etc/init.d/hdfs-namenode
M testdata/cluster/node_templates/common/etc/init.d/yarn-common
M testdata/cluster/node_templates/common/etc/init.d/yarn-nodemanager
M testdata/cluster/node_templates/common/etc/init.d/yarn-resourcemanager
D testdata/data/mstr/eatwh1/EATWH1-DDL.sql
D testdata/data/mstr/eatwh1/LoadTablesEATWH1.sql
D testdata/data/mstr/eatwh1/csv/COST_MARKET_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/COST_MARKET_DEP.TXT
D testdata/data/mstr/eatwh1/csv/COST_MARKET_DIV.TXT
D testdata/data/mstr/eatwh1/csv/COST_REGION_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/COST_REGION_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/COST_STORE_DEP.TXT
D testdata/data/mstr/eatwh1/csv/COST_STORE_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/FT1.TXT
D testdata/data/mstr/eatwh1/csv/FT10.TXT
D testdata/data/mstr/eatwh1/csv/FT11.TXT
D testdata/data/mstr/eatwh1/csv/FT12.TXT
D testdata/data/mstr/eatwh1/csv/FT13.TXT
D testdata/data/mstr/eatwh1/csv/FT14.TXT
D testdata/data/mstr/eatwh1/csv/FT15.TXT
D testdata/data/mstr/eatwh1/csv/FT17.TXT
D testdata/data/mstr/eatwh1/csv/FT2.TXT
D testdata/data/mstr/eatwh1/csv/FT3.TXT
D testdata/data/mstr/eatwh1/csv/FT4.TXT
D testdata/data/mstr/eatwh1/csv/FT5.TXT
D testdata/data/mstr/eatwh1/csv/FT6.TXT
D testdata/data/mstr/eatwh1/csv/FT7.TXT
D testdata/data/mstr/eatwh1/csv/FT8.TXT
D testdata/data/mstr/eatwh1/csv/FT9.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_CURR.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_ORDERS.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q1_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q1_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q2_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q2_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q3_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q3_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q4_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q4_1998.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_COLOR.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DAY.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DEMOG.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MANAGER.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MARKET.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MONTH.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_PRICEZONE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_QUAL.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_QUARTER.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_SEASON.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_SIZE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STATE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STORE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STYLE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_WEEK.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_WEEKDAY.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/LU_CALL_CTR.TXT
D testdata/data/mstr/eatwh1/csv/LU_CATALOG.TXT
D testdata/data/mstr/eatwh1/csv/LU_CATEGORY.TXT
D testdata/data/mstr/eatwh1/csv/LU_COUNTRY.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUSTOMER.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUST_CITY.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUST_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LU_DATE.TXT
D testdata/data/mstr/eatwh1/csv/LU_DIST_CTR.TXT
D testdata/data/mstr/eatwh1/csv/LU_EMPLOYEE.TXT
D testdata/data/mstr/eatwh1/csv/LU_INCOME.TXT
D testdata/data/mstr/eatwh1/csv/LU_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/LU_MANAGER.TXT
D testdata/data/mstr/eatwh1/csv/LU_MONTH.TXT
D testdata/data/mstr/eatwh1/csv/LU_MONTH_OF_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/LU_ORDER.TXT
D testdata/data/mstr/eatwh1/csv/LU_PROMOTION.TXT
D testdata/data/mstr/eatwh1/csv/LU_PROMO_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LU_PYMT_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LU_QUARTER.TXT
D testdata/data/mstr/eatwh1/csv/LU_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LU_SHIPPER.TXT
D testdata/data/mstr/eatwh1/csv/LU_SUBCATEG.TXT
D testdata/data/mstr/eatwh1/csv/LU_SUPPLIER.TXT
D testdata/data/mstr/eatwh1/csv/LU_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/MNTH_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh1/csv/MSI_STATS_LOG.TXT
D testdata/data/mstr/eatwh1/csv/MSI_STATS_PROP.TXT
D testdata/data/mstr/eatwh1/csv/ORDER_DETAIL.TXT
D testdata/data/mstr/eatwh1/csv/ORDER_FACT.TXT
D testdata/data/mstr/eatwh1/csv/PMT_INVENTORY.TXT
D testdata/data/mstr/eatwh1/csv/PRODUCT_DETAIL.TXT
D testdata/data/mstr/eatwh1/csv/PROMOTIONS.TXT
D testdata/data/mstr/eatwh1/csv/P_DAY_DEC_94.TXT
D testdata/data/mstr/eatwh1/csv/P_MONTH_DEC_93.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_1.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_2.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_3.TXT
D testdata/data/mstr/eatwh1/csv/QTR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh1/csv/REGION_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/REGION_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/REGION_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/REGION_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_COLOR.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_SIZE.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_STYLE.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_LY_LW.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_MTD.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_REGION_MAN.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_STORE_DEMOG.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_STORE_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/REL_CAT_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/RUSH_ORDER.TXT
D testdata/data/mstr/eatwh1/csv/SEPERATE_FACT.TXT
D testdata/data/mstr/eatwh1/csv/STORE_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/STORE_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/STORE_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_93.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_93_HETERO.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_94.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_94_HETERO.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_ORDERS.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_PTMAP.TXT
D testdata/data/mstr/eatwh1/csv/TE_TRANS_STATISTICS.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_DATE_LW_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_DATE_MTD.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_MONTH_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_QUARTER_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_YEAR_LY.TXT
D testdata/data/mstr/eatwh1/csv/YR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/EATWH2-DDL.sql
D testdata/data/mstr/eatwh2/LoadTablesEATWH2.sql
D testdata/data/mstr/eatwh2/csv/BIG_ORDER_FACT.TXT
D testdata/data/mstr/eatwh2/csv/CITY_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_SUBCATEG_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_SUBCATEG_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CUSTOMER_SLS.TXT
D testdata/data/mstr/eatwh2/csv/DAY_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_CURR.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_ORDERS.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q1_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q1_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q2_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q2_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q3_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q3_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q4_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q4_2001.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_EMP_SLS.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_MNTH_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/LU_BRAND.TXT
D testdata/data/mstr/eatwh2/csv/LU_CALL_CTR.TXT
D testdata/data/mstr/eatwh2/csv/LU_CATALOG.TXT
D testdata/data/mstr/eatwh2/csv/LU_CATEGORY.TXT
D testdata/data/mstr/eatwh2/csv/LU_COUNTRY.TXT
D testdata/data/mstr/eatwh2/csv/LU_COUNTRY_MANAGER.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUSTOMER.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_CITY.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_REGION.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_STATE.TXT
D testdata/data/mstr/eatwh2/csv/LU_DAY.TXT
D testdata/data/mstr/eatwh2/csv/LU_DIST_CTR.TXT
D testdata/data/mstr/eatwh2/csv/LU_EMPLOYEE.TXT
D testdata/data/mstr/eatwh2/csv/LU_INCOME.TXT
D testdata/data/mstr/eatwh2/csv/LU_ITEM.TXT
D testdata/data/mstr/eatwh2/csv/LU_MANAGER.TXT
D testdata/data/mstr/eatwh2/csv/LU_MONTH.TXT
D testdata/data/mstr/eatwh2/csv/LU_MONTH_OF_YEAR.TXT
D testdata/data/mstr/eatwh2/csv/LU_ORDER.TXT
D testdata/data/mstr/eatwh2/csv/LU_PROMOTION.TXT
D testdata/data/mstr/eatwh2/csv/LU_PROMO_TYPE.TXT
D testdata/data/mstr/eatwh2/csv/LU_PYMT_TYPE.TXT
D testdata/data/mstr/eatwh2/csv/LU_QUARTER.TXT
D testdata/data/mstr/eatwh2/csv/LU_REGION.TXT
D testdata/data/mstr/eatwh2/csv/LU_SHIPPER.TXT
D testdata/data/mstr/eatwh2/csv/LU_SUBCATEG.TXT
D testdata/data/mstr/eatwh2/csv/LU_SUPPLIER.TXT
D testdata/data/mstr/eatwh2/csv/LU_YEAR.TXT
D testdata/data/mstr/eatwh2/csv/MNTH_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/MSI_STATS_LOG.TXT
D testdata/data/mstr/eatwh2/csv/MSI_STATS_PROP.TXT
D testdata/data/mstr/eatwh2/csv/MTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/ORDER_DETAIL.TXT
D testdata/data/mstr/eatwh2/csv/ORDER_FACT.TXT
D testdata/data/mstr/eatwh2/csv/PMT_INVENTORY.TXT
D testdata/data/mstr/eatwh2/csv/PROMOTIONS.TXT
D testdata/data/mstr/eatwh2/csv/QTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/QTR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/RELATE_PROJECTS_CATEGORIES.TXT
D testdata/data/mstr/eatwh2/csv/REL_CAT_ITEM.TXT
D testdata/data/mstr/eatwh2/csv/REL_GROUPS.TXT
D testdata/data/mstr/eatwh2/csv/REL_USERS_GROUPS.TXT
D testdata/data/mstr/eatwh2/csv/RUSH_ORDER.TXT
D testdata/data/mstr/eatwh2/csv/STATE_REGION_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/STATE_SUBCATEG_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/STATE_SUBCATEG_REGION_SLS.TXT
D testdata/data/mstr/eatwh2/csv/SUBCATEG_MNTH_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/TE_TRANS_STATISTICS.TXT
D testdata/data/mstr/eatwh2/csv/YR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/YTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/YTM_MONTH.TXT
M tests/test-hive-udfs/pom.xml
279 files changed, 1,280 insertions(+), 1,648,836 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/4361/7
-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.

Jim Apple has uploaded a new patch set (#6).

Change subject: IMPALA-4110: Clean up issues found by Apache RAT.
......................................................................

IMPALA-4110: Clean up issues found by Apache RAT.

The script and support files are in another patch:

https://gerrit.cloudera.org/#/c/4405/

Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
---
M LICENSE.txt
M be/.astylerc
M be/.impala.doxy
M be/src/benchmarks/expr-benchmark.cc
M be/src/experiments/data-provider.cc
M be/src/experiments/hashing/cache-hash-test.cc
M be/src/experiments/hashing/growing-test.cc
M be/src/experiments/hashing/interface/cache-hash-test.cc
M be/src/experiments/hashing/interface/growing-test.cc
M be/src/experiments/hashing/multilevel/cache-hash-test.cc
M be/src/experiments/hashing/multilevel/growing-test.cc
M be/src/experiments/hashing/prefetch/cache-hash-test.cc
M be/src/experiments/hashing/prefetch/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/cache-hash-test.cc
M be/src/experiments/hashing/split-benchmarks/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/partitioning-throughput-test.cc
M be/src/experiments/hashing/streaming/cache-hash-test.cc
M be/src/experiments/hashing/streaming/growing-test.cc
M be/src/testutil/certificates-info.txt
M be/src/util/asan.h
M bin/README-RUNNING-BENCHMARKS
D bin/cpplint.py
M bin/impala-ipython
M bin/impala-py.test
M bin/impala-python
M cmake_modules/FindAvro.cmake
M cmake_modules/FindBreakpad.cmake
M cmake_modules/FindBzip2.cmake
M cmake_modules/FindGFlags.cmake
M cmake_modules/FindGLog.cmake
M cmake_modules/FindHDFS.cmake
M cmake_modules/FindJNI.cmake
M cmake_modules/FindLdap.cmake
M cmake_modules/FindLlvm.cmake
M cmake_modules/FindLlvmBinaries.cmake
M cmake_modules/FindLz4.cmake
M cmake_modules/FindOpenSSL.cmake
M cmake_modules/FindPProf.cmake
M cmake_modules/FindRapidJson.cmake
M cmake_modules/FindRe2.cmake
M cmake_modules/FindSnappy.cmake
M cmake_modules/FindThrift.cmake
M cmake_modules/FindZlib.cmake
M fe/src/main/java/com/cloudera/impala/analysis/AggregateInfoBase.java
M fe/src/main/java/com/cloudera/impala/analysis/ExprSubstitutionMap.java
M fe/src/main/java/com/cloudera/impala/analysis/PartitionSpec.java
M fe/src/main/java/com/cloudera/impala/catalog/ArrayType.java
M fe/src/main/java/com/cloudera/impala/catalog/MapType.java
M fe/src/main/java/com/cloudera/impala/catalog/StructType.java
M fe/src/main/java/com/cloudera/impala/planner/Planner.java
M fe/src/test/resources/authz-policy.ini.template
M fe/src/test/resources/hive-log4j.properties.template
M fe/src/test/resources/log4j.properties.template
M infra/python/deps/download_requirements
M infra/python/deps/requirements.txt
M testdata/avro_schema_resolution/create_table.sql
M testdata/bin/cache_tables.py
M testdata/bin/create-mini.sql
M testdata/bin/load-dependent-tables.sql
M testdata/bin/load-hive-builtins.sh
M testdata/bin/run-hive.sh
M testdata/cluster/node_templates/cdh5/etc/init.d/kms
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-common
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-master
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-tserver
M testdata/cluster/node_templates/cdh5/etc/init.d/llama-application
M testdata/cluster/node_templates/common/etc/init.d/common.tmpl
M testdata/cluster/node_templates/common/etc/init.d/hdfs-common
M testdata/cluster/node_templates/common/etc/init.d/hdfs-datanode
M testdata/cluster/node_templates/common/etc/init.d/hdfs-namenode
M testdata/cluster/node_templates/common/etc/init.d/yarn-common
M testdata/cluster/node_templates/common/etc/init.d/yarn-nodemanager
M testdata/cluster/node_templates/common/etc/init.d/yarn-resourcemanager
D testdata/data/mstr/eatwh1/EATWH1-DDL.sql
D testdata/data/mstr/eatwh1/LoadTablesEATWH1.sql
D testdata/data/mstr/eatwh1/csv/COST_MARKET_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/COST_MARKET_DEP.TXT
D testdata/data/mstr/eatwh1/csv/COST_MARKET_DIV.TXT
D testdata/data/mstr/eatwh1/csv/COST_REGION_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/COST_REGION_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/COST_STORE_DEP.TXT
D testdata/data/mstr/eatwh1/csv/COST_STORE_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/FT1.TXT
D testdata/data/mstr/eatwh1/csv/FT10.TXT
D testdata/data/mstr/eatwh1/csv/FT11.TXT
D testdata/data/mstr/eatwh1/csv/FT12.TXT
D testdata/data/mstr/eatwh1/csv/FT13.TXT
D testdata/data/mstr/eatwh1/csv/FT14.TXT
D testdata/data/mstr/eatwh1/csv/FT15.TXT
D testdata/data/mstr/eatwh1/csv/FT17.TXT
D testdata/data/mstr/eatwh1/csv/FT2.TXT
D testdata/data/mstr/eatwh1/csv/FT3.TXT
D testdata/data/mstr/eatwh1/csv/FT4.TXT
D testdata/data/mstr/eatwh1/csv/FT5.TXT
D testdata/data/mstr/eatwh1/csv/FT6.TXT
D testdata/data/mstr/eatwh1/csv/FT7.TXT
D testdata/data/mstr/eatwh1/csv/FT8.TXT
D testdata/data/mstr/eatwh1/csv/FT9.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_CURR.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_ORDERS.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q1_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q1_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q2_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q2_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q3_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q3_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q4_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q4_1998.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_COLOR.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DAY.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DEMOG.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MANAGER.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MARKET.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MONTH.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_PRICEZONE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_QUAL.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_QUARTER.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_SEASON.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_SIZE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STATE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STORE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STYLE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_WEEK.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_WEEKDAY.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/LU_CALL_CTR.TXT
D testdata/data/mstr/eatwh1/csv/LU_CATALOG.TXT
D testdata/data/mstr/eatwh1/csv/LU_CATEGORY.TXT
D testdata/data/mstr/eatwh1/csv/LU_COUNTRY.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUSTOMER.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUST_CITY.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUST_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LU_DATE.TXT
D testdata/data/mstr/eatwh1/csv/LU_DIST_CTR.TXT
D testdata/data/mstr/eatwh1/csv/LU_EMPLOYEE.TXT
D testdata/data/mstr/eatwh1/csv/LU_INCOME.TXT
D testdata/data/mstr/eatwh1/csv/LU_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/LU_MANAGER.TXT
D testdata/data/mstr/eatwh1/csv/LU_MONTH.TXT
D testdata/data/mstr/eatwh1/csv/LU_MONTH_OF_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/LU_ORDER.TXT
D testdata/data/mstr/eatwh1/csv/LU_PROMOTION.TXT
D testdata/data/mstr/eatwh1/csv/LU_PROMO_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LU_PYMT_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LU_QUARTER.TXT
D testdata/data/mstr/eatwh1/csv/LU_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LU_SHIPPER.TXT
D testdata/data/mstr/eatwh1/csv/LU_SUBCATEG.TXT
D testdata/data/mstr/eatwh1/csv/LU_SUPPLIER.TXT
D testdata/data/mstr/eatwh1/csv/LU_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/MNTH_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh1/csv/MSI_STATS_LOG.TXT
D testdata/data/mstr/eatwh1/csv/MSI_STATS_PROP.TXT
D testdata/data/mstr/eatwh1/csv/ORDER_DETAIL.TXT
D testdata/data/mstr/eatwh1/csv/ORDER_FACT.TXT
D testdata/data/mstr/eatwh1/csv/PMT_INVENTORY.TXT
D testdata/data/mstr/eatwh1/csv/PRODUCT_DETAIL.TXT
D testdata/data/mstr/eatwh1/csv/PROMOTIONS.TXT
D testdata/data/mstr/eatwh1/csv/P_DAY_DEC_94.TXT
D testdata/data/mstr/eatwh1/csv/P_MONTH_DEC_93.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_1.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_2.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_3.TXT
D testdata/data/mstr/eatwh1/csv/QTR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh1/csv/REGION_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/REGION_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/REGION_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/REGION_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_COLOR.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_SIZE.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_STYLE.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_LY_LW.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_MTD.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_REGION_MAN.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_STORE_DEMOG.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_STORE_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/REL_CAT_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/RUSH_ORDER.TXT
D testdata/data/mstr/eatwh1/csv/SEPERATE_FACT.TXT
D testdata/data/mstr/eatwh1/csv/STORE_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/STORE_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/STORE_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_93.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_93_HETERO.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_94.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_94_HETERO.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_ORDERS.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_PTMAP.TXT
D testdata/data/mstr/eatwh1/csv/TE_TRANS_STATISTICS.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_DATE_LW_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_DATE_MTD.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_MONTH_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_QUARTER_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_YEAR_LY.TXT
D testdata/data/mstr/eatwh1/csv/YR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/EATWH2-DDL.sql
D testdata/data/mstr/eatwh2/LoadTablesEATWH2.sql
D testdata/data/mstr/eatwh2/csv/BIG_ORDER_FACT.TXT
D testdata/data/mstr/eatwh2/csv/CITY_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_SUBCATEG_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_SUBCATEG_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CUSTOMER_SLS.TXT
D testdata/data/mstr/eatwh2/csv/DAY_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_CURR.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_ORDERS.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q1_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q1_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q2_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q2_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q3_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q3_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q4_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q4_2001.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_EMP_SLS.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_MNTH_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/LU_BRAND.TXT
D testdata/data/mstr/eatwh2/csv/LU_CALL_CTR.TXT
D testdata/data/mstr/eatwh2/csv/LU_CATALOG.TXT
D testdata/data/mstr/eatwh2/csv/LU_CATEGORY.TXT
D testdata/data/mstr/eatwh2/csv/LU_COUNTRY.TXT
D testdata/data/mstr/eatwh2/csv/LU_COUNTRY_MANAGER.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUSTOMER.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_CITY.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_REGION.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_STATE.TXT
D testdata/data/mstr/eatwh2/csv/LU_DAY.TXT
D testdata/data/mstr/eatwh2/csv/LU_DIST_CTR.TXT
D testdata/data/mstr/eatwh2/csv/LU_EMPLOYEE.TXT
D testdata/data/mstr/eatwh2/csv/LU_INCOME.TXT
D testdata/data/mstr/eatwh2/csv/LU_ITEM.TXT
D testdata/data/mstr/eatwh2/csv/LU_MANAGER.TXT
D testdata/data/mstr/eatwh2/csv/LU_MONTH.TXT
D testdata/data/mstr/eatwh2/csv/LU_MONTH_OF_YEAR.TXT
D testdata/data/mstr/eatwh2/csv/LU_ORDER.TXT
D testdata/data/mstr/eatwh2/csv/LU_PROMOTION.TXT
D testdata/data/mstr/eatwh2/csv/LU_PROMO_TYPE.TXT
D testdata/data/mstr/eatwh2/csv/LU_PYMT_TYPE.TXT
D testdata/data/mstr/eatwh2/csv/LU_QUARTER.TXT
D testdata/data/mstr/eatwh2/csv/LU_REGION.TXT
D testdata/data/mstr/eatwh2/csv/LU_SHIPPER.TXT
D testdata/data/mstr/eatwh2/csv/LU_SUBCATEG.TXT
D testdata/data/mstr/eatwh2/csv/LU_SUPPLIER.TXT
D testdata/data/mstr/eatwh2/csv/LU_YEAR.TXT
D testdata/data/mstr/eatwh2/csv/MNTH_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/MSI_STATS_LOG.TXT
D testdata/data/mstr/eatwh2/csv/MSI_STATS_PROP.TXT
D testdata/data/mstr/eatwh2/csv/MTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/ORDER_DETAIL.TXT
D testdata/data/mstr/eatwh2/csv/ORDER_FACT.TXT
D testdata/data/mstr/eatwh2/csv/PMT_INVENTORY.TXT
D testdata/data/mstr/eatwh2/csv/PROMOTIONS.TXT
D testdata/data/mstr/eatwh2/csv/QTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/QTR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/RELATE_PROJECTS_CATEGORIES.TXT
D testdata/data/mstr/eatwh2/csv/REL_CAT_ITEM.TXT
D testdata/data/mstr/eatwh2/csv/REL_GROUPS.TXT
D testdata/data/mstr/eatwh2/csv/REL_USERS_GROUPS.TXT
D testdata/data/mstr/eatwh2/csv/RUSH_ORDER.TXT
D testdata/data/mstr/eatwh2/csv/STATE_REGION_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/STATE_SUBCATEG_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/STATE_SUBCATEG_REGION_SLS.TXT
D testdata/data/mstr/eatwh2/csv/SUBCATEG_MNTH_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/TE_TRANS_STATISTICS.TXT
D testdata/data/mstr/eatwh2/csv/YR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/YTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/YTM_MONTH.TXT
M tests/comparison/conftest.py
M tests/test-hive-udfs/pom.xml
280 files changed, 1,297 insertions(+), 1,648,836 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/4361/6
-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.

Jim Apple has posted comments on this change.

Change subject: IMPALA-4110: Clean up issues found by Apache RAT.
......................................................................


Patch Set 3:

(3 comments)

> (3 comments)
 > 
 > Looks good to me.
 > 
 > Can we please separate the tool integration from the fixes in two
 > separate patches?

Done, see https://gerrit.cloudera.org/#/c/4405

http://gerrit.cloudera.org:8080/#/c/4361/3/bin/check-rat-report.py
File bin/check-rat-report.py:

Line 21: # Usage:
> Can you describe the purpose of this tool? Where did this script come from?
Done. Moved to https://gerrit.cloudera.org/#/c/4405


Line 24: #      `git archive --prefix=Foo/ -o baz.tar.gz HEAD`
> can we make the examples more concrete?
Done


http://gerrit.cloudera.org:8080/#/c/4361/3/testdata/bin/cache_tables.py
File testdata/bin/cache_tables.py:

Line 22: # query.  This only works on a mini-dfs cluster.  This is remarkably difficult to do 
> fix whitespace while here
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.

Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4110: Clean up issues found by Apache RAT.
......................................................................


IMPALA-4110: Clean up issues found by Apache RAT.

Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Reviewed-on: http://gerrit.cloudera.org:8080/4361
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Internal Jenkins
---
M LICENSE.txt
M be/.astylerc
M be/.impala.doxy
M be/src/benchmarks/expr-benchmark.cc
M be/src/bufferpool/CMakeLists.txt
M be/src/experiments/data-provider.cc
M be/src/experiments/hashing/cache-hash-test.cc
M be/src/experiments/hashing/growing-test.cc
M be/src/experiments/hashing/interface/cache-hash-test.cc
M be/src/experiments/hashing/interface/growing-test.cc
M be/src/experiments/hashing/multilevel/cache-hash-test.cc
M be/src/experiments/hashing/multilevel/growing-test.cc
M be/src/experiments/hashing/prefetch/cache-hash-test.cc
M be/src/experiments/hashing/prefetch/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/cache-hash-test.cc
M be/src/experiments/hashing/split-benchmarks/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/partitioning-throughput-test.cc
M be/src/experiments/hashing/streaming/cache-hash-test.cc
M be/src/experiments/hashing/streaming/growing-test.cc
M be/src/testutil/certificates-info.txt
M be/src/util/asan.h
M bin/README-RUNNING-BENCHMARKS
M bin/check-rat-report.py
D bin/cpplint.py
M bin/impala-ipython
M bin/impala-py.test
M bin/impala-python
M bin/rat_exclude_files.txt
M cmake_modules/FindAvro.cmake
M cmake_modules/FindBreakpad.cmake
M cmake_modules/FindBzip2.cmake
M cmake_modules/FindGFlags.cmake
M cmake_modules/FindGLog.cmake
M cmake_modules/FindHDFS.cmake
M cmake_modules/FindJNI.cmake
M cmake_modules/FindLdap.cmake
M cmake_modules/FindLlvm.cmake
M cmake_modules/FindLlvmBinaries.cmake
M cmake_modules/FindLz4.cmake
M cmake_modules/FindOpenSSL.cmake
M cmake_modules/FindPProf.cmake
M cmake_modules/FindRapidJson.cmake
M cmake_modules/FindRe2.cmake
M cmake_modules/FindSnappy.cmake
M cmake_modules/FindThrift.cmake
M cmake_modules/FindZlib.cmake
M fe/src/main/java/com/cloudera/impala/analysis/AggregateInfoBase.java
M fe/src/main/java/com/cloudera/impala/analysis/ExprSubstitutionMap.java
M fe/src/main/java/com/cloudera/impala/analysis/PartitionSpec.java
M fe/src/main/java/com/cloudera/impala/catalog/ArrayType.java
M fe/src/main/java/com/cloudera/impala/catalog/MapType.java
M fe/src/main/java/com/cloudera/impala/catalog/StructType.java
M fe/src/main/java/com/cloudera/impala/planner/Planner.java
M fe/src/test/resources/authz-policy.ini.template
M fe/src/test/resources/hive-log4j.properties.template
M fe/src/test/resources/log4j.properties.template
M infra/python/deps/download_requirements
M infra/python/deps/requirements.txt
M testdata/avro_schema_resolution/create_table.sql
M testdata/bin/cache_tables.py
M testdata/bin/create-mini.sql
M testdata/bin/load-dependent-tables.sql
M testdata/bin/load-hive-builtins.sh
M testdata/bin/run-hive.sh
M testdata/cluster/node_templates/cdh5/etc/init.d/kms
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-common
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-master
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-tserver
M testdata/cluster/node_templates/cdh5/etc/init.d/llama-application
M testdata/cluster/node_templates/common/etc/init.d/common.tmpl
M testdata/cluster/node_templates/common/etc/init.d/hdfs-common
M testdata/cluster/node_templates/common/etc/init.d/hdfs-datanode
M testdata/cluster/node_templates/common/etc/init.d/hdfs-namenode
M testdata/cluster/node_templates/common/etc/init.d/yarn-common
M testdata/cluster/node_templates/common/etc/init.d/yarn-nodemanager
M testdata/cluster/node_templates/common/etc/init.d/yarn-resourcemanager
D testdata/data/mstr/eatwh1/EATWH1-DDL.sql
D testdata/data/mstr/eatwh1/LoadTablesEATWH1.sql
D testdata/data/mstr/eatwh1/csv/COST_MARKET_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/COST_MARKET_DEP.TXT
D testdata/data/mstr/eatwh1/csv/COST_MARKET_DIV.TXT
D testdata/data/mstr/eatwh1/csv/COST_REGION_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/COST_REGION_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/COST_STORE_DEP.TXT
D testdata/data/mstr/eatwh1/csv/COST_STORE_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/FT1.TXT
D testdata/data/mstr/eatwh1/csv/FT10.TXT
D testdata/data/mstr/eatwh1/csv/FT11.TXT
D testdata/data/mstr/eatwh1/csv/FT12.TXT
D testdata/data/mstr/eatwh1/csv/FT13.TXT
D testdata/data/mstr/eatwh1/csv/FT14.TXT
D testdata/data/mstr/eatwh1/csv/FT15.TXT
D testdata/data/mstr/eatwh1/csv/FT17.TXT
D testdata/data/mstr/eatwh1/csv/FT2.TXT
D testdata/data/mstr/eatwh1/csv/FT3.TXT
D testdata/data/mstr/eatwh1/csv/FT4.TXT
D testdata/data/mstr/eatwh1/csv/FT5.TXT
D testdata/data/mstr/eatwh1/csv/FT6.TXT
D testdata/data/mstr/eatwh1/csv/FT7.TXT
D testdata/data/mstr/eatwh1/csv/FT8.TXT
D testdata/data/mstr/eatwh1/csv/FT9.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_CURR.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_ORDERS.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q1_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q1_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q2_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q2_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q3_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q3_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q4_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q4_1998.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_COLOR.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DAY.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DEMOG.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MANAGER.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MARKET.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MONTH.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_PRICEZONE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_QUAL.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_QUARTER.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_SEASON.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_SIZE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STATE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STORE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STYLE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_WEEK.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_WEEKDAY.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/LU_CALL_CTR.TXT
D testdata/data/mstr/eatwh1/csv/LU_CATALOG.TXT
D testdata/data/mstr/eatwh1/csv/LU_CATEGORY.TXT
D testdata/data/mstr/eatwh1/csv/LU_COUNTRY.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUSTOMER.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUST_CITY.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUST_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LU_DATE.TXT
D testdata/data/mstr/eatwh1/csv/LU_DIST_CTR.TXT
D testdata/data/mstr/eatwh1/csv/LU_EMPLOYEE.TXT
D testdata/data/mstr/eatwh1/csv/LU_INCOME.TXT
D testdata/data/mstr/eatwh1/csv/LU_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/LU_MANAGER.TXT
D testdata/data/mstr/eatwh1/csv/LU_MONTH.TXT
D testdata/data/mstr/eatwh1/csv/LU_MONTH_OF_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/LU_ORDER.TXT
D testdata/data/mstr/eatwh1/csv/LU_PROMOTION.TXT
D testdata/data/mstr/eatwh1/csv/LU_PROMO_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LU_PYMT_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LU_QUARTER.TXT
D testdata/data/mstr/eatwh1/csv/LU_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LU_SHIPPER.TXT
D testdata/data/mstr/eatwh1/csv/LU_SUBCATEG.TXT
D testdata/data/mstr/eatwh1/csv/LU_SUPPLIER.TXT
D testdata/data/mstr/eatwh1/csv/LU_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/MNTH_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh1/csv/MSI_STATS_LOG.TXT
D testdata/data/mstr/eatwh1/csv/MSI_STATS_PROP.TXT
D testdata/data/mstr/eatwh1/csv/ORDER_DETAIL.TXT
D testdata/data/mstr/eatwh1/csv/ORDER_FACT.TXT
D testdata/data/mstr/eatwh1/csv/PMT_INVENTORY.TXT
D testdata/data/mstr/eatwh1/csv/PRODUCT_DETAIL.TXT
D testdata/data/mstr/eatwh1/csv/PROMOTIONS.TXT
D testdata/data/mstr/eatwh1/csv/P_DAY_DEC_94.TXT
D testdata/data/mstr/eatwh1/csv/P_MONTH_DEC_93.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_1.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_2.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_3.TXT
D testdata/data/mstr/eatwh1/csv/QTR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh1/csv/REGION_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/REGION_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/REGION_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/REGION_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_COLOR.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_SIZE.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_STYLE.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_LY_LW.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_MTD.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_REGION_MAN.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_STORE_DEMOG.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_STORE_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/REL_CAT_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/RUSH_ORDER.TXT
D testdata/data/mstr/eatwh1/csv/SEPERATE_FACT.TXT
D testdata/data/mstr/eatwh1/csv/STORE_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/STORE_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/STORE_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_93.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_93_HETERO.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_94.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_94_HETERO.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_ORDERS.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_PTMAP.TXT
D testdata/data/mstr/eatwh1/csv/TE_TRANS_STATISTICS.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_DATE_LW_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_DATE_MTD.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_MONTH_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_QUARTER_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_YEAR_LY.TXT
D testdata/data/mstr/eatwh1/csv/YR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/EATWH2-DDL.sql
D testdata/data/mstr/eatwh2/LoadTablesEATWH2.sql
D testdata/data/mstr/eatwh2/csv/BIG_ORDER_FACT.TXT
D testdata/data/mstr/eatwh2/csv/CITY_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_SUBCATEG_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_SUBCATEG_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CUSTOMER_SLS.TXT
D testdata/data/mstr/eatwh2/csv/DAY_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_CURR.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_ORDERS.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q1_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q1_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q2_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q2_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q3_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q3_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q4_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q4_2001.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_EMP_SLS.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_MNTH_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/LU_BRAND.TXT
D testdata/data/mstr/eatwh2/csv/LU_CALL_CTR.TXT
D testdata/data/mstr/eatwh2/csv/LU_CATALOG.TXT
D testdata/data/mstr/eatwh2/csv/LU_CATEGORY.TXT
D testdata/data/mstr/eatwh2/csv/LU_COUNTRY.TXT
D testdata/data/mstr/eatwh2/csv/LU_COUNTRY_MANAGER.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUSTOMER.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_CITY.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_REGION.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_STATE.TXT
D testdata/data/mstr/eatwh2/csv/LU_DAY.TXT
D testdata/data/mstr/eatwh2/csv/LU_DIST_CTR.TXT
D testdata/data/mstr/eatwh2/csv/LU_EMPLOYEE.TXT
D testdata/data/mstr/eatwh2/csv/LU_INCOME.TXT
D testdata/data/mstr/eatwh2/csv/LU_ITEM.TXT
D testdata/data/mstr/eatwh2/csv/LU_MANAGER.TXT
D testdata/data/mstr/eatwh2/csv/LU_MONTH.TXT
D testdata/data/mstr/eatwh2/csv/LU_MONTH_OF_YEAR.TXT
D testdata/data/mstr/eatwh2/csv/LU_ORDER.TXT
D testdata/data/mstr/eatwh2/csv/LU_PROMOTION.TXT
D testdata/data/mstr/eatwh2/csv/LU_PROMO_TYPE.TXT
D testdata/data/mstr/eatwh2/csv/LU_PYMT_TYPE.TXT
D testdata/data/mstr/eatwh2/csv/LU_QUARTER.TXT
D testdata/data/mstr/eatwh2/csv/LU_REGION.TXT
D testdata/data/mstr/eatwh2/csv/LU_SHIPPER.TXT
D testdata/data/mstr/eatwh2/csv/LU_SUBCATEG.TXT
D testdata/data/mstr/eatwh2/csv/LU_SUPPLIER.TXT
D testdata/data/mstr/eatwh2/csv/LU_YEAR.TXT
D testdata/data/mstr/eatwh2/csv/MNTH_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/MSI_STATS_LOG.TXT
D testdata/data/mstr/eatwh2/csv/MSI_STATS_PROP.TXT
D testdata/data/mstr/eatwh2/csv/MTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/ORDER_DETAIL.TXT
D testdata/data/mstr/eatwh2/csv/ORDER_FACT.TXT
D testdata/data/mstr/eatwh2/csv/PMT_INVENTORY.TXT
D testdata/data/mstr/eatwh2/csv/PROMOTIONS.TXT
D testdata/data/mstr/eatwh2/csv/QTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/QTR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/RELATE_PROJECTS_CATEGORIES.TXT
D testdata/data/mstr/eatwh2/csv/REL_CAT_ITEM.TXT
D testdata/data/mstr/eatwh2/csv/REL_GROUPS.TXT
D testdata/data/mstr/eatwh2/csv/REL_USERS_GROUPS.TXT
D testdata/data/mstr/eatwh2/csv/RUSH_ORDER.TXT
D testdata/data/mstr/eatwh2/csv/STATE_REGION_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/STATE_SUBCATEG_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/STATE_SUBCATEG_REGION_SLS.TXT
D testdata/data/mstr/eatwh2/csv/SUBCATEG_MNTH_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/TE_TRANS_STATISTICS.TXT
D testdata/data/mstr/eatwh2/csv/YR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/YTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/YTM_MONTH.TXT
M tests/test-hive-udfs/pom.xml
282 files changed, 1,285 insertions(+), 1,648,838 deletions(-)

Approvals:
  Internal Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.

Jim Apple has posted comments on this change.

Change subject: IMPALA-4110: Clean up issues found by Apache RAT.
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4361/6/be/.impala.doxy
File be/.impala.doxy:

Line 17
> should we really delete all these existing comments?
http://www.apache.org/legal/resolved.html#can-we-use-doxygen-generated-config-files

"As long as the generated comments are removed from the Doxygen-generated files, these files may be used."

Doxygen is GPL, and the comments are licensed GPL.


-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.

Alex Behm has posted comments on this change.

Change subject: IMPALA-4110: Clean up issues found by Apache RAT.
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4361/6/be/.impala.doxy
File be/.impala.doxy:

Line 17
> http://www.apache.org/legal/resolved.html#can-we-use-doxygen-generated-conf
Ridiculous, but ok.


-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.

Jim Apple has posted comments on this change.

Change subject: IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.
......................................................................


Patch Set 1:

(3 comments)

> (5 comments)
 > 
 > looks pretty reasonable. Might want to do a surface level
 > understanding of why you need this ratcursive workaround and file a
 > JIRA upstream.

Looks like it was some 0.11 problems; 0.12 worked without ratcursive.

http://gerrit.cloudera.org:8080/#/c/4361/1/bin/rat.sh
File bin/rat.sh:

PS1, Line 38: RAT_JAR=$1
            : # The location of the Impala directory (or subdirectory within the Impala tree) to check:
            : START=$2
> rather than relying just on set -u, i think it's nicer to print a real 'usa
File removed.


PS1, Line 51:  PN
> what's PN?
PseudoNym


Line 63:                 echo "Failed to RAT ${FN}" >&2
> should set the exit code in this case, no? otherwise people might miss this
I thinkk RAT exits with 0 even when the license isn't OK. I've changed the checker python script I borrowed from Kudu to be a little stricter in what goes to stderr.


-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.

Jim Apple has uploaded a new patch set (#8).

Change subject: IMPALA-4110: Clean up issues found by Apache RAT.
......................................................................

IMPALA-4110: Clean up issues found by Apache RAT.

Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
---
M LICENSE.txt
M be/.astylerc
M be/.impala.doxy
M be/src/benchmarks/expr-benchmark.cc
M be/src/bufferpool/CMakeLists.txt
M be/src/experiments/data-provider.cc
M be/src/experiments/hashing/cache-hash-test.cc
M be/src/experiments/hashing/growing-test.cc
M be/src/experiments/hashing/interface/cache-hash-test.cc
M be/src/experiments/hashing/interface/growing-test.cc
M be/src/experiments/hashing/multilevel/cache-hash-test.cc
M be/src/experiments/hashing/multilevel/growing-test.cc
M be/src/experiments/hashing/prefetch/cache-hash-test.cc
M be/src/experiments/hashing/prefetch/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/cache-hash-test.cc
M be/src/experiments/hashing/split-benchmarks/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/partitioning-throughput-test.cc
M be/src/experiments/hashing/streaming/cache-hash-test.cc
M be/src/experiments/hashing/streaming/growing-test.cc
M be/src/testutil/certificates-info.txt
M be/src/util/asan.h
M bin/README-RUNNING-BENCHMARKS
M bin/check-rat-report.py
D bin/cpplint.py
M bin/impala-ipython
M bin/impala-py.test
M bin/impala-python
M bin/rat_exclude_files.txt
M cmake_modules/FindAvro.cmake
M cmake_modules/FindBreakpad.cmake
M cmake_modules/FindBzip2.cmake
M cmake_modules/FindGFlags.cmake
M cmake_modules/FindGLog.cmake
M cmake_modules/FindHDFS.cmake
M cmake_modules/FindJNI.cmake
M cmake_modules/FindLdap.cmake
M cmake_modules/FindLlvm.cmake
M cmake_modules/FindLlvmBinaries.cmake
M cmake_modules/FindLz4.cmake
M cmake_modules/FindOpenSSL.cmake
M cmake_modules/FindPProf.cmake
M cmake_modules/FindRapidJson.cmake
M cmake_modules/FindRe2.cmake
M cmake_modules/FindSnappy.cmake
M cmake_modules/FindThrift.cmake
M cmake_modules/FindZlib.cmake
M fe/src/main/java/com/cloudera/impala/analysis/AggregateInfoBase.java
M fe/src/main/java/com/cloudera/impala/analysis/ExprSubstitutionMap.java
M fe/src/main/java/com/cloudera/impala/analysis/PartitionSpec.java
M fe/src/main/java/com/cloudera/impala/catalog/ArrayType.java
M fe/src/main/java/com/cloudera/impala/catalog/MapType.java
M fe/src/main/java/com/cloudera/impala/catalog/StructType.java
M fe/src/main/java/com/cloudera/impala/planner/Planner.java
M fe/src/test/resources/authz-policy.ini.template
M fe/src/test/resources/hive-log4j.properties.template
M fe/src/test/resources/log4j.properties.template
M infra/python/deps/download_requirements
M infra/python/deps/requirements.txt
M testdata/avro_schema_resolution/create_table.sql
M testdata/bin/cache_tables.py
M testdata/bin/create-mini.sql
M testdata/bin/load-dependent-tables.sql
M testdata/bin/load-hive-builtins.sh
M testdata/bin/run-hive.sh
M testdata/cluster/node_templates/cdh5/etc/init.d/kms
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-common
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-master
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-tserver
M testdata/cluster/node_templates/cdh5/etc/init.d/llama-application
M testdata/cluster/node_templates/common/etc/init.d/common.tmpl
M testdata/cluster/node_templates/common/etc/init.d/hdfs-common
M testdata/cluster/node_templates/common/etc/init.d/hdfs-datanode
M testdata/cluster/node_templates/common/etc/init.d/hdfs-namenode
M testdata/cluster/node_templates/common/etc/init.d/yarn-common
M testdata/cluster/node_templates/common/etc/init.d/yarn-nodemanager
M testdata/cluster/node_templates/common/etc/init.d/yarn-resourcemanager
D testdata/data/mstr/eatwh1/EATWH1-DDL.sql
D testdata/data/mstr/eatwh1/LoadTablesEATWH1.sql
D testdata/data/mstr/eatwh1/csv/COST_MARKET_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/COST_MARKET_DEP.TXT
D testdata/data/mstr/eatwh1/csv/COST_MARKET_DIV.TXT
D testdata/data/mstr/eatwh1/csv/COST_REGION_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/COST_REGION_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/COST_STORE_DEP.TXT
D testdata/data/mstr/eatwh1/csv/COST_STORE_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/FT1.TXT
D testdata/data/mstr/eatwh1/csv/FT10.TXT
D testdata/data/mstr/eatwh1/csv/FT11.TXT
D testdata/data/mstr/eatwh1/csv/FT12.TXT
D testdata/data/mstr/eatwh1/csv/FT13.TXT
D testdata/data/mstr/eatwh1/csv/FT14.TXT
D testdata/data/mstr/eatwh1/csv/FT15.TXT
D testdata/data/mstr/eatwh1/csv/FT17.TXT
D testdata/data/mstr/eatwh1/csv/FT2.TXT
D testdata/data/mstr/eatwh1/csv/FT3.TXT
D testdata/data/mstr/eatwh1/csv/FT4.TXT
D testdata/data/mstr/eatwh1/csv/FT5.TXT
D testdata/data/mstr/eatwh1/csv/FT6.TXT
D testdata/data/mstr/eatwh1/csv/FT7.TXT
D testdata/data/mstr/eatwh1/csv/FT8.TXT
D testdata/data/mstr/eatwh1/csv/FT9.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_CURR.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_ORDERS.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q1_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q1_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q2_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q2_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q3_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q3_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q4_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q4_1998.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_COLOR.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DAY.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DEMOG.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MANAGER.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MARKET.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MONTH.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_PRICEZONE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_QUAL.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_QUARTER.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_SEASON.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_SIZE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STATE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STORE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STYLE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_WEEK.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_WEEKDAY.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/LU_CALL_CTR.TXT
D testdata/data/mstr/eatwh1/csv/LU_CATALOG.TXT
D testdata/data/mstr/eatwh1/csv/LU_CATEGORY.TXT
D testdata/data/mstr/eatwh1/csv/LU_COUNTRY.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUSTOMER.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUST_CITY.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUST_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LU_DATE.TXT
D testdata/data/mstr/eatwh1/csv/LU_DIST_CTR.TXT
D testdata/data/mstr/eatwh1/csv/LU_EMPLOYEE.TXT
D testdata/data/mstr/eatwh1/csv/LU_INCOME.TXT
D testdata/data/mstr/eatwh1/csv/LU_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/LU_MANAGER.TXT
D testdata/data/mstr/eatwh1/csv/LU_MONTH.TXT
D testdata/data/mstr/eatwh1/csv/LU_MONTH_OF_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/LU_ORDER.TXT
D testdata/data/mstr/eatwh1/csv/LU_PROMOTION.TXT
D testdata/data/mstr/eatwh1/csv/LU_PROMO_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LU_PYMT_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LU_QUARTER.TXT
D testdata/data/mstr/eatwh1/csv/LU_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LU_SHIPPER.TXT
D testdata/data/mstr/eatwh1/csv/LU_SUBCATEG.TXT
D testdata/data/mstr/eatwh1/csv/LU_SUPPLIER.TXT
D testdata/data/mstr/eatwh1/csv/LU_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/MNTH_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh1/csv/MSI_STATS_LOG.TXT
D testdata/data/mstr/eatwh1/csv/MSI_STATS_PROP.TXT
D testdata/data/mstr/eatwh1/csv/ORDER_DETAIL.TXT
D testdata/data/mstr/eatwh1/csv/ORDER_FACT.TXT
D testdata/data/mstr/eatwh1/csv/PMT_INVENTORY.TXT
D testdata/data/mstr/eatwh1/csv/PRODUCT_DETAIL.TXT
D testdata/data/mstr/eatwh1/csv/PROMOTIONS.TXT
D testdata/data/mstr/eatwh1/csv/P_DAY_DEC_94.TXT
D testdata/data/mstr/eatwh1/csv/P_MONTH_DEC_93.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_1.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_2.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_3.TXT
D testdata/data/mstr/eatwh1/csv/QTR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh1/csv/REGION_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/REGION_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/REGION_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/REGION_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_COLOR.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_SIZE.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_STYLE.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_LY_LW.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_MTD.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_REGION_MAN.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_STORE_DEMOG.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_STORE_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/REL_CAT_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/RUSH_ORDER.TXT
D testdata/data/mstr/eatwh1/csv/SEPERATE_FACT.TXT
D testdata/data/mstr/eatwh1/csv/STORE_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/STORE_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/STORE_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_93.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_93_HETERO.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_94.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_94_HETERO.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_ORDERS.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_PTMAP.TXT
D testdata/data/mstr/eatwh1/csv/TE_TRANS_STATISTICS.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_DATE_LW_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_DATE_MTD.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_MONTH_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_QUARTER_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_YEAR_LY.TXT
D testdata/data/mstr/eatwh1/csv/YR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/EATWH2-DDL.sql
D testdata/data/mstr/eatwh2/LoadTablesEATWH2.sql
D testdata/data/mstr/eatwh2/csv/BIG_ORDER_FACT.TXT
D testdata/data/mstr/eatwh2/csv/CITY_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_SUBCATEG_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_SUBCATEG_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CUSTOMER_SLS.TXT
D testdata/data/mstr/eatwh2/csv/DAY_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_CURR.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_ORDERS.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q1_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q1_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q2_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q2_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q3_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q3_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q4_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q4_2001.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_EMP_SLS.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_MNTH_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/LU_BRAND.TXT
D testdata/data/mstr/eatwh2/csv/LU_CALL_CTR.TXT
D testdata/data/mstr/eatwh2/csv/LU_CATALOG.TXT
D testdata/data/mstr/eatwh2/csv/LU_CATEGORY.TXT
D testdata/data/mstr/eatwh2/csv/LU_COUNTRY.TXT
D testdata/data/mstr/eatwh2/csv/LU_COUNTRY_MANAGER.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUSTOMER.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_CITY.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_REGION.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_STATE.TXT
D testdata/data/mstr/eatwh2/csv/LU_DAY.TXT
D testdata/data/mstr/eatwh2/csv/LU_DIST_CTR.TXT
D testdata/data/mstr/eatwh2/csv/LU_EMPLOYEE.TXT
D testdata/data/mstr/eatwh2/csv/LU_INCOME.TXT
D testdata/data/mstr/eatwh2/csv/LU_ITEM.TXT
D testdata/data/mstr/eatwh2/csv/LU_MANAGER.TXT
D testdata/data/mstr/eatwh2/csv/LU_MONTH.TXT
D testdata/data/mstr/eatwh2/csv/LU_MONTH_OF_YEAR.TXT
D testdata/data/mstr/eatwh2/csv/LU_ORDER.TXT
D testdata/data/mstr/eatwh2/csv/LU_PROMOTION.TXT
D testdata/data/mstr/eatwh2/csv/LU_PROMO_TYPE.TXT
D testdata/data/mstr/eatwh2/csv/LU_PYMT_TYPE.TXT
D testdata/data/mstr/eatwh2/csv/LU_QUARTER.TXT
D testdata/data/mstr/eatwh2/csv/LU_REGION.TXT
D testdata/data/mstr/eatwh2/csv/LU_SHIPPER.TXT
D testdata/data/mstr/eatwh2/csv/LU_SUBCATEG.TXT
D testdata/data/mstr/eatwh2/csv/LU_SUPPLIER.TXT
D testdata/data/mstr/eatwh2/csv/LU_YEAR.TXT
D testdata/data/mstr/eatwh2/csv/MNTH_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/MSI_STATS_LOG.TXT
D testdata/data/mstr/eatwh2/csv/MSI_STATS_PROP.TXT
D testdata/data/mstr/eatwh2/csv/MTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/ORDER_DETAIL.TXT
D testdata/data/mstr/eatwh2/csv/ORDER_FACT.TXT
D testdata/data/mstr/eatwh2/csv/PMT_INVENTORY.TXT
D testdata/data/mstr/eatwh2/csv/PROMOTIONS.TXT
D testdata/data/mstr/eatwh2/csv/QTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/QTR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/RELATE_PROJECTS_CATEGORIES.TXT
D testdata/data/mstr/eatwh2/csv/REL_CAT_ITEM.TXT
D testdata/data/mstr/eatwh2/csv/REL_GROUPS.TXT
D testdata/data/mstr/eatwh2/csv/REL_USERS_GROUPS.TXT
D testdata/data/mstr/eatwh2/csv/RUSH_ORDER.TXT
D testdata/data/mstr/eatwh2/csv/STATE_REGION_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/STATE_SUBCATEG_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/STATE_SUBCATEG_REGION_SLS.TXT
D testdata/data/mstr/eatwh2/csv/SUBCATEG_MNTH_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/TE_TRANS_STATISTICS.TXT
D testdata/data/mstr/eatwh2/csv/YR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/YTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/YTM_MONTH.TXT
M tests/test-hive-udfs/pom.xml
282 files changed, 1,285 insertions(+), 1,648,838 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/4361/8
-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[Impala-ASF-CR] IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.

Alex Behm has posted comments on this change.

Change subject: IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.
......................................................................


Patch Set 3:

(3 comments)

Looks good to me.

Can we please separate the tool integration from the fixes in two separate patches?

http://gerrit.cloudera.org:8080/#/c/4361/3/bin/check-rat-report.py
File bin/check-rat-report.py:

Line 21: # Usage:
Can you describe the purpose of this tool? Where did this script come from?


Line 24: #      `git archive --prefix=Foo/ -o baz.tar.gz HEAD`
can we make the examples more concrete?


http://gerrit.cloudera.org:8080/#/c/4361/3/testdata/bin/cache_tables.py
File testdata/bin/cache_tables.py:

Line 22: # query.  This only works on a mini-dfs cluster.  This is remarkably difficult to do 
fix whitespace while here


-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.

Todd Lipcon has posted comments on this change.

Change subject: IMPALA-4110: PREVIEW: Make RAT run on Impala tarballs.
......................................................................


Patch Set 1:

(5 comments)

looks pretty reasonable. Might want to do a surface level understanding of why you need this ratcursive workaround and file a JIRA upstream.

http://gerrit.cloudera.org:8080/#/c/4361/1/bin/rat.sh
File bin/rat.sh:

PS1, Line 38: RAT_JAR=$1
            : # The location of the Impala directory (or subdirectory within the Impala tree) to check:
            : START=$2
rather than relying just on set -u, i think it's nicer to print a real 'usage: $0 ...'


PS1, Line 51:  PN
what's PN?


Line 54:         if (ulimit -t 10; java -jar "${RAT_JAR}" -x "${FN}" >"${OUTFILE}"); then
wow, neat trick I'd never seen


Line 58:             if [ -d "${FN}" ]; then
maybe you want to avoid recursing into symlinks?


Line 63:                 echo "Failed to RAT ${FN}" >&2
should set the exit code in this case, no? otherwise people might miss this.


-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.

Jim Apple has uploaded a new patch set (#5).

Change subject: IMPALA-4110: Clean up issues found by Apache RAT.
......................................................................

IMPALA-4110: Clean up issues found by Apache RAT.

The script and support files are in another patch:

https://gerrit.cloudera.org/#/c/4405/

Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
---
M LICENSE.txt
M be/.astylerc
M be/.impala.doxy
M be/src/benchmarks/expr-benchmark.cc
M be/src/experiments/data-provider.cc
M be/src/experiments/hashing/cache-hash-test.cc
M be/src/experiments/hashing/growing-test.cc
M be/src/experiments/hashing/interface/cache-hash-test.cc
M be/src/experiments/hashing/interface/growing-test.cc
M be/src/experiments/hashing/multilevel/cache-hash-test.cc
M be/src/experiments/hashing/multilevel/growing-test.cc
M be/src/experiments/hashing/prefetch/cache-hash-test.cc
M be/src/experiments/hashing/prefetch/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/cache-hash-test.cc
M be/src/experiments/hashing/split-benchmarks/growing-test.cc
M be/src/experiments/hashing/split-benchmarks/partitioning-throughput-test.cc
M be/src/experiments/hashing/streaming/cache-hash-test.cc
M be/src/experiments/hashing/streaming/growing-test.cc
M be/src/testutil/certificates-info.txt
M be/src/util/asan.h
M bin/README-RUNNING-BENCHMARKS
D bin/cpplint.py
M bin/impala-ipython
M bin/impala-py.test
M bin/impala-python
M cmake_modules/FindAvro.cmake
M cmake_modules/FindBreakpad.cmake
M cmake_modules/FindBzip2.cmake
M cmake_modules/FindGFlags.cmake
M cmake_modules/FindGLog.cmake
M cmake_modules/FindHDFS.cmake
M cmake_modules/FindJNI.cmake
M cmake_modules/FindLdap.cmake
M cmake_modules/FindLlvm.cmake
M cmake_modules/FindLlvmBinaries.cmake
M cmake_modules/FindLz4.cmake
M cmake_modules/FindOpenSSL.cmake
M cmake_modules/FindPProf.cmake
M cmake_modules/FindRapidJson.cmake
M cmake_modules/FindRe2.cmake
M cmake_modules/FindSnappy.cmake
M cmake_modules/FindThrift.cmake
M cmake_modules/FindZlib.cmake
M fe/src/main/java/com/cloudera/impala/analysis/AggregateInfoBase.java
M fe/src/main/java/com/cloudera/impala/analysis/ExprSubstitutionMap.java
M fe/src/main/java/com/cloudera/impala/analysis/PartitionSpec.java
M fe/src/main/java/com/cloudera/impala/catalog/ArrayType.java
M fe/src/main/java/com/cloudera/impala/catalog/MapType.java
M fe/src/main/java/com/cloudera/impala/catalog/StructType.java
M fe/src/main/java/com/cloudera/impala/planner/Planner.java
M fe/src/test/resources/authz-policy.ini.template
M fe/src/test/resources/hive-log4j.properties.template
M fe/src/test/resources/log4j.properties.template
M infra/python/deps/download_requirements
M infra/python/deps/requirements.txt
M testdata/avro_schema_resolution/create_table.sql
M testdata/bin/cache_tables.py
M testdata/bin/create-mini.sql
M testdata/bin/load-dependent-tables.sql
M testdata/bin/load-hive-builtins.sh
M testdata/bin/run-hive.sh
M testdata/cluster/node_templates/cdh5/etc/init.d/kms
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-common
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-master
M testdata/cluster/node_templates/cdh5/etc/init.d/kudu-tserver
M testdata/cluster/node_templates/cdh5/etc/init.d/llama-application
M testdata/cluster/node_templates/common/etc/init.d/common.tmpl
M testdata/cluster/node_templates/common/etc/init.d/hdfs-common
M testdata/cluster/node_templates/common/etc/init.d/hdfs-datanode
M testdata/cluster/node_templates/common/etc/init.d/hdfs-namenode
M testdata/cluster/node_templates/common/etc/init.d/yarn-common
M testdata/cluster/node_templates/common/etc/init.d/yarn-nodemanager
M testdata/cluster/node_templates/common/etc/init.d/yarn-resourcemanager
D testdata/data/mstr/eatwh1/EATWH1-DDL.sql
D testdata/data/mstr/eatwh1/LoadTablesEATWH1.sql
D testdata/data/mstr/eatwh1/csv/COST_MARKET_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/COST_MARKET_DEP.TXT
D testdata/data/mstr/eatwh1/csv/COST_MARKET_DIV.TXT
D testdata/data/mstr/eatwh1/csv/COST_REGION_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/COST_REGION_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/COST_STORE_DEP.TXT
D testdata/data/mstr/eatwh1/csv/COST_STORE_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/FT1.TXT
D testdata/data/mstr/eatwh1/csv/FT10.TXT
D testdata/data/mstr/eatwh1/csv/FT11.TXT
D testdata/data/mstr/eatwh1/csv/FT12.TXT
D testdata/data/mstr/eatwh1/csv/FT13.TXT
D testdata/data/mstr/eatwh1/csv/FT14.TXT
D testdata/data/mstr/eatwh1/csv/FT15.TXT
D testdata/data/mstr/eatwh1/csv/FT17.TXT
D testdata/data/mstr/eatwh1/csv/FT2.TXT
D testdata/data/mstr/eatwh1/csv/FT3.TXT
D testdata/data/mstr/eatwh1/csv/FT4.TXT
D testdata/data/mstr/eatwh1/csv/FT5.TXT
D testdata/data/mstr/eatwh1/csv/FT6.TXT
D testdata/data/mstr/eatwh1/csv/FT7.TXT
D testdata/data/mstr/eatwh1/csv/FT8.TXT
D testdata/data/mstr/eatwh1/csv/FT9.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_CURR.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_ORDERS.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q1_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q1_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q2_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q2_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q3_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q3_1998.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q4_1997.TXT
D testdata/data/mstr/eatwh1/csv/INVENTORY_Q4_1998.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_COLOR.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DAY.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DEMOG.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MANAGER.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MARKET.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_MONTH.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_PRICEZONE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_QUAL.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_QUARTER.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_SEASON.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_SIZE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STATE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STORE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_STYLE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_WEEK.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_WEEKDAY.TXT
D testdata/data/mstr/eatwh1/csv/LOOKUP_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/LU_CALL_CTR.TXT
D testdata/data/mstr/eatwh1/csv/LU_CATALOG.TXT
D testdata/data/mstr/eatwh1/csv/LU_CATEGORY.TXT
D testdata/data/mstr/eatwh1/csv/LU_COUNTRY.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUSTOMER.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUST_CITY.TXT
D testdata/data/mstr/eatwh1/csv/LU_CUST_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LU_DATE.TXT
D testdata/data/mstr/eatwh1/csv/LU_DIST_CTR.TXT
D testdata/data/mstr/eatwh1/csv/LU_EMPLOYEE.TXT
D testdata/data/mstr/eatwh1/csv/LU_INCOME.TXT
D testdata/data/mstr/eatwh1/csv/LU_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/LU_MANAGER.TXT
D testdata/data/mstr/eatwh1/csv/LU_MONTH.TXT
D testdata/data/mstr/eatwh1/csv/LU_MONTH_OF_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/LU_ORDER.TXT
D testdata/data/mstr/eatwh1/csv/LU_PROMOTION.TXT
D testdata/data/mstr/eatwh1/csv/LU_PROMO_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LU_PYMT_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/LU_QUARTER.TXT
D testdata/data/mstr/eatwh1/csv/LU_REGION.TXT
D testdata/data/mstr/eatwh1/csv/LU_SHIPPER.TXT
D testdata/data/mstr/eatwh1/csv/LU_SUBCATEG.TXT
D testdata/data/mstr/eatwh1/csv/LU_SUPPLIER.TXT
D testdata/data/mstr/eatwh1/csv/LU_YEAR.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/MARKET_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/MNTH_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh1/csv/MSI_STATS_LOG.TXT
D testdata/data/mstr/eatwh1/csv/MSI_STATS_PROP.TXT
D testdata/data/mstr/eatwh1/csv/ORDER_DETAIL.TXT
D testdata/data/mstr/eatwh1/csv/ORDER_FACT.TXT
D testdata/data/mstr/eatwh1/csv/PMT_INVENTORY.TXT
D testdata/data/mstr/eatwh1/csv/PRODUCT_DETAIL.TXT
D testdata/data/mstr/eatwh1/csv/PROMOTIONS.TXT
D testdata/data/mstr/eatwh1/csv/P_DAY_DEC_94.TXT
D testdata/data/mstr/eatwh1/csv/P_MONTH_DEC_93.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_1.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_2.TXT
D testdata/data/mstr/eatwh1/csv/P_WEEK_DEC_94_3.TXT
D testdata/data/mstr/eatwh1/csv/QTR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh1/csv/REGION_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/REGION_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/REGION_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/REGION_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_COLOR.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_SIZE.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_ITEM_STYLE.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_LY_LW.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_MTD.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_REGION_MAN.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_STORE_DEMOG.TXT
D testdata/data/mstr/eatwh1/csv/RELATE_STORE_TYPE.TXT
D testdata/data/mstr/eatwh1/csv/REL_CAT_ITEM.TXT
D testdata/data/mstr/eatwh1/csv/RUSH_ORDER.TXT
D testdata/data/mstr/eatwh1/csv/SEPERATE_FACT.TXT
D testdata/data/mstr/eatwh1/csv/STORE_CLASS.TXT
D testdata/data/mstr/eatwh1/csv/STORE_DEPARTMENT.TXT
D testdata/data/mstr/eatwh1/csv/STORE_DIVISION.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_93.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_93_HETERO.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_94.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_94_HETERO.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_ORDERS.TXT
D testdata/data/mstr/eatwh1/csv/STORE_ITEM_PTMAP.TXT
D testdata/data/mstr/eatwh1/csv/TE_TRANS_STATISTICS.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_DATE_LW_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_DATE_MTD.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_MONTH_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_QUARTER_LY.TXT
D testdata/data/mstr/eatwh1/csv/TRANS_YEAR_LY.TXT
D testdata/data/mstr/eatwh1/csv/YR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/EATWH2-DDL.sql
D testdata/data/mstr/eatwh2/LoadTablesEATWH2.sql
D testdata/data/mstr/eatwh2/csv/BIG_ORDER_FACT.TXT
D testdata/data/mstr/eatwh2/csv/CITY_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_SUBCATEG_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CITY_SUBCATEG_SLS.TXT
D testdata/data/mstr/eatwh2/csv/CUSTOMER_SLS.TXT
D testdata/data/mstr/eatwh2/csv/DAY_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_CURR.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_ORDERS.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q1_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q1_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q2_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q2_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q3_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q3_2001.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q4_2000.TXT
D testdata/data/mstr/eatwh2/csv/INVENTORY_Q4_2001.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_EMP_SLS.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_MNTH_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/ITEM_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/LU_BRAND.TXT
D testdata/data/mstr/eatwh2/csv/LU_CALL_CTR.TXT
D testdata/data/mstr/eatwh2/csv/LU_CATALOG.TXT
D testdata/data/mstr/eatwh2/csv/LU_CATEGORY.TXT
D testdata/data/mstr/eatwh2/csv/LU_COUNTRY.TXT
D testdata/data/mstr/eatwh2/csv/LU_COUNTRY_MANAGER.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUSTOMER.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_CITY.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_REGION.TXT
D testdata/data/mstr/eatwh2/csv/LU_CUST_STATE.TXT
D testdata/data/mstr/eatwh2/csv/LU_DAY.TXT
D testdata/data/mstr/eatwh2/csv/LU_DIST_CTR.TXT
D testdata/data/mstr/eatwh2/csv/LU_EMPLOYEE.TXT
D testdata/data/mstr/eatwh2/csv/LU_INCOME.TXT
D testdata/data/mstr/eatwh2/csv/LU_ITEM.TXT
D testdata/data/mstr/eatwh2/csv/LU_MANAGER.TXT
D testdata/data/mstr/eatwh2/csv/LU_MONTH.TXT
D testdata/data/mstr/eatwh2/csv/LU_MONTH_OF_YEAR.TXT
D testdata/data/mstr/eatwh2/csv/LU_ORDER.TXT
D testdata/data/mstr/eatwh2/csv/LU_PROMOTION.TXT
D testdata/data/mstr/eatwh2/csv/LU_PROMO_TYPE.TXT
D testdata/data/mstr/eatwh2/csv/LU_PYMT_TYPE.TXT
D testdata/data/mstr/eatwh2/csv/LU_QUARTER.TXT
D testdata/data/mstr/eatwh2/csv/LU_REGION.TXT
D testdata/data/mstr/eatwh2/csv/LU_SHIPPER.TXT
D testdata/data/mstr/eatwh2/csv/LU_SUBCATEG.TXT
D testdata/data/mstr/eatwh2/csv/LU_SUPPLIER.TXT
D testdata/data/mstr/eatwh2/csv/LU_YEAR.TXT
D testdata/data/mstr/eatwh2/csv/MNTH_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/MSI_STATS_LOG.TXT
D testdata/data/mstr/eatwh2/csv/MSI_STATS_PROP.TXT
D testdata/data/mstr/eatwh2/csv/MTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/ORDER_DETAIL.TXT
D testdata/data/mstr/eatwh2/csv/ORDER_FACT.TXT
D testdata/data/mstr/eatwh2/csv/PMT_INVENTORY.TXT
D testdata/data/mstr/eatwh2/csv/PROMOTIONS.TXT
D testdata/data/mstr/eatwh2/csv/QTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/QTR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/RELATE_PROJECTS_CATEGORIES.TXT
D testdata/data/mstr/eatwh2/csv/REL_CAT_ITEM.TXT
D testdata/data/mstr/eatwh2/csv/REL_GROUPS.TXT
D testdata/data/mstr/eatwh2/csv/REL_USERS_GROUPS.TXT
D testdata/data/mstr/eatwh2/csv/RUSH_ORDER.TXT
D testdata/data/mstr/eatwh2/csv/STATE_REGION_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/STATE_SUBCATEG_MNTH_SLS.TXT
D testdata/data/mstr/eatwh2/csv/STATE_SUBCATEG_REGION_SLS.TXT
D testdata/data/mstr/eatwh2/csv/SUBCATEG_MNTH_CTR_SLS.TXT
D testdata/data/mstr/eatwh2/csv/TE_TRANS_STATISTICS.TXT
D testdata/data/mstr/eatwh2/csv/YR_CATEGORY_SLS.TXT
D testdata/data/mstr/eatwh2/csv/YTD_DAY.TXT
D testdata/data/mstr/eatwh2/csv/YTM_MONTH.TXT
M tests/comparison/conftest.py
M tests/test-hive-udfs/pom.xml
280 files changed, 1,292 insertions(+), 1,648,831 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/4361/5
-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.

Alex Behm has posted comments on this change.

Change subject: IMPALA-4110: Clean up issues found by Apache RAT.
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4361/6/be/.impala.doxy
File be/.impala.doxy:

Line 17
should we really delete all these existing comments?


-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-4110: Clean up issues found by Apache RAT.

Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.

Internal Jenkins has posted comments on this change.

Change subject: IMPALA-4110: Clean up issues found by Apache RAT.
......................................................................


Patch Set 8: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bfe77f9a871018e7a67553ed270e2df53006962
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No