[GitHub] [brooklyn-server] ahgittin commented on a change in pull request #1115: Catalog bundle resolvers

[GitBox <gi...@apache.org>]

ahgittin commented on a change in pull request #1115:
URL: https://github.com/apache/brooklyn-server/pull/1115#discussion_r504312066



##########
File path: core/src/main/java/org/apache/brooklyn/core/typereg/BrooklynTypePlanTransformer.java
##########
@@ -81,14 +83,15 @@
      * has returned a positive value, and the same constraints on the inputs as for that method apply.
      * <p>
      * Implementations should either return null or throw {@link UnsupportedTypePlanException} 
-     * if they cannot instantiate the given {@link RegisteredType#getPlan()}. */
+     * if upon closer inspection following a non-null score, they do not actually support the given {@link RegisteredType#getPlan()}.
+     * If they should support the plan but the plan contains an error, they should throw the relevant error for feedback to the user. */
     @Nullable Object create(@Nonnull RegisteredType type, @Nonnull RegisteredTypeLoadingContext context);
 
-    // TODO sketch methods for loading *catalog* definitions.  note some potential overlap
-    // with BrooklynTypeRegistery.createXxxFromPlan
-    @Beta
-    double scoreForTypeDefinition(String formatCode, Object catalogData);
-    @Beta
-    List<RegisteredType> createFromTypeDefinition(String formatCode, Object catalogData);
+    /** @deprecated since 1.0; use {@link org.apache.brooklyn.core.typereg.BrooklynCatalogBundleResolver} for adding to catalog */

Review comment:
       👍 - will say since 1.1




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org