[jira] [Resolved] (YUNIKORN-1550) pass k8s node labels as attributes not json

["Wilfred Spiegelenburg (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YUNIKORN-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wilfred Spiegelenburg resolved YUNIKORN-1550.
---------------------------------------------
    Fix Version/s: 1.3.0
       Resolution: Fixed

Change committed to master.

No corresponding core change as the attributes were not used in yet on that side.

Thank you [~zhuqi] 

> pass k8s node labels as attributes not json
> -------------------------------------------
>
>                 Key: YUNIKORN-1550
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1550
>             Project: Apache YuniKorn
>          Issue Type: Sub-task
>          Components: shim - kubernetes
>    Affects Versions: 1.2.0
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Qi Zhu
>            Priority: Major
>              Labels: newbie, pull-request-available
>             Fix For: 1.3.0
>
>
> The k8shim in YUNIKORN-1389 was extended to pass on the K8s node labels to the core via the attributes. The K8s node labels are marshalled into a single json string. The string is added using a new key.
> There are multiple issues with that. The overhead of un-marshalling it each time a label needs to be checked for existence is large. It also needs a two step check to find a label. First find the label in the attributes and then un-marshal the string and do another check for the real key & value needed.
> We should add the labels from the K8s node as entries in the attributes map. Each label becomes and entry not json marshalling.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org