[GitHub] [incubator-pinot] jenniferdai commented on a change in pull request #4735: Changing error log to warn in SegmentPreprocessingMapper

[GitBox <gi...@apache.org>]

jenniferdai commented on a change in pull request #4735: Changing error log to warn in SegmentPreprocessingMapper
URL: https://github.com/apache/incubator-pinot/pull/4735#discussion_r337662660
 
 

 ##########
 File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mappers/SegmentPreprocessingMapper.java
 ##########
 @@ -94,7 +94,7 @@ public void map(AvroKey<GenericRecord> record, NullWritable value, final Context
       if (!normalizedTimeColumnValue.equals(_sampleNormalizedTimeColumnValue)) {
 
 Review comment:
   When you decide to rollup segments, we want to make sure that only one time unit is rolled up, so it is theoretically safer to fail preprocessing if more than one time unit is contained (although I know we have some segments that cross timezones, in which case there will be more than one timeunit). I wanted to fail the job entirely and not allow customers to continue, but I settled for an error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org