You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/23 15:01:16 UTC

[GitHub] [doris] morrySnow commented on a diff in pull request #10377: [feature](nereids) Add brackets expr and ssbSql

morrySnow commented on code in PR #10377:
URL: https://github.com/apache/doris/pull/10377#discussion_r905134514


##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -196,6 +196,7 @@ primaryExpression
     | LEFT_PAREN query RIGHT_PAREN                                                             #subqueryExpression
     | identifier                                                                               #columnReference
     | base=primaryExpression DOT fieldName=identifier                                          #dereference
+    | '(' expression ')'                                                                       #parenthesizedExpression

Review Comment:
   line 196 use `LEFT_PAREN`, so we should use one thing to represent left parenthesis in all place



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org