You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@arrow.apache.org by "Dragoș Moldovan-Grünfeld (Jira)" <ji...@apache.org> on 2021/12/20 17:34:00 UTC

[jira] [Commented] (ARROW-15167) [R] Improve efficiency of decimal casting

    [ https://issues.apache.org/jira/browse/ARROW-15167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462745#comment-17462745 ] 

Dragoș Moldovan-Grünfeld commented on ARROW-15167:
--------------------------------------------------

I think row 981 is the issue as \{{std::stod}} converts a string to double ttps://github.com/apache/arrow/blob/04641a38ee5da0fa1d745fd29fd4a206719338cd/r/src/array_to_vector.cpp#L981

> [R] Improve efficiency of decimal casting
> -----------------------------------------
>
>                 Key: ARROW-15167
>                 URL: https://issues.apache.org/jira/browse/ARROW-15167
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: R
>            Reporter: Jonathan Keane
>            Priority: Major
>             Fix For: 8.0.0
>
>
> https://github.com/apache/arrow/blob/04641a38ee5da0fa1d745fd29fd4a206719338cd/r/src/array_to_vector.cpp#L975-L990
> "this looks quite inefficient (it roundtrips through a string representation instead of creating a double directly)."
> from: https://github.com/apache/arrow/pull/11898#discussion_r769657404



--
This message was sent by Atlassian Jira
(v8.20.1#820001)