[GitHub] Jule- opened a new pull request #589: Rewrite install dir resolution for legacy plugins

[GitBox <gi...@apache.org>]

Jule- opened a new pull request #589: Rewrite install dir resolution for legacy plugins
URL: https://github.com/apache/cordova-android/pull/589
 
 
   Let's start fresh!
   
   ### What does this PR do?
   This is the rebase of my old PR #576 coming from #575 on the master branch as encouraged.
   Basically I have separated bloc that was handling new app directory structure from the old one. Plus I have rewrite tests with RegExp allowing buggy forms with or without `/` at the end like.
   Plus all (hope so) code reviews from @brodybits.
   
   ### What testing has been done on this change?
   - new: `app`, `app/`, `app/whatever`
   - old: `src`, `src/`, `src/whatever/source`, `libs`, `libs/`, `libs/whatever/bin`
   - buggy: `src/myappsomething/source`, `appsomething/source`
   Like my original issue with: [cordova-plugin-local-notifications](https://github.com/katzer/cordova-plugin-local-notifications/blob/6d1b27f1e9d8e2198fd1ea6e9032419295690c47/plugin.xml#L145-L147). Try it:
   ```
   $ cordova plugin add cordova-plugin-local-notification
   ```
   
   ### Contextual issues and PRs raised
   #577, #578, #580 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org