You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/06/17 10:01:58 UTC
[GitHub] [james-project] chibenwa commented on a diff in pull request #1056: [REACTOR] Reactify CanSendFrom::userCanSendFrom
chibenwa commented on code in PR #1056:
URL: https://github.com/apache/james-project/pull/1056#discussion_r899971367
##########
server/data/data-api/src/main/java/org/apache/james/rrt/api/CanSendFrom.java:
##########
@@ -30,6 +33,10 @@ public interface CanSendFrom {
*/
boolean userCanSendFrom(Username connectedUser, Username fromUser);
+ default Publisher<Boolean> userCanSendFromReactive(Username connectedUser, Username fromUser) {
Review Comment:
CanSendFromImpl don't need to wrap it's blocking calls? Shouldn't it implement this default method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org