You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "nitinware (via GitHub)" <gi...@apache.org> on 2026/09/07 21:50:12 UTC

[PR] Docs: document accepted encoder/decoder signatures on coder.RegisterCoder [beam]

nitinware opened a new pull request, #40050:
URL: https://github.com/apache/beam/pull/40050

   Addresses #21930
   
   Adds explicit encoder/decoder function signature documentation to
   `coder.RegisterCoder`, matching the four signatures already documented on
   the top-level `beam.RegisterCoder` wrapper in `forward.go`. Also adds a
   short note on `NewCustomCoder` pointing at the same signature spec, since
   it accepts the same functions.
   
   Docs-only change — no behavior modification. `go vet` and `go build`
   on `pkg/beam/core/graph/coder/...` both clean.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/actions/workflows/build_wheels.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/actions/workflows/python_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/actions/workflows/java_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/actions/workflows/go_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Docs: document accepted encoder/decoder signatures on coder.RegisterCoder [beam]

Posted by "nitinware (via GitHub)" <gi...@apache.org>.
nitinware commented on PR #40050:
URL: https://github.com/apache/beam/pull/40050#issuecomment-5723390222

   assign to next reviewer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Docs: document accepted encoder/decoder signatures on coder.RegisterCoder [beam]

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck merged PR #40050:
URL: https://github.com/apache/beam/pull/40050


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Docs: document accepted encoder/decoder signatures on coder.RegisterCoder [beam]

Posted by "nitinware (via GitHub)" <gi...@apache.org>.
nitinware commented on PR #40050:
URL: https://github.com/apache/beam/pull/40050#issuecomment-5724110468

   @lostluck thanks for the review and merge! Appreciate it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Docs: document accepted encoder/decoder signatures on coder.RegisterCoder [beam]

Posted by "nitinware (via GitHub)" <gi...@apache.org>.
nitinware commented on PR #40050:
URL: https://github.com/apache/beam/pull/40050#issuecomment-5723885290

   @lostluck Thanks for the review and approval! I’d appreciate it if you could merge the PR as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Docs: document accepted encoder/decoder signatures on coder.RegisterCoder [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40050:
URL: https://github.com/apache/beam/pull/40050#issuecomment-5691967139

   Assigning reviewers:
   
   R: @lostluck for label go.
   
   
   Note: If you would like to opt out of this review, comment `assign to next reviewer`.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Docs: document accepted encoder/decoder signatures on coder.RegisterCoder [beam]

Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #40050:
URL: https://github.com/apache/beam/pull/40050#issuecomment-5724078114

   Yup that was the intent. Needed to wait for the presubmits to finish.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org