You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/29 07:21:48 UTC

[GitHub] [apisix-java-plugin-runner] dmsolr opened a new pull request #45: chore: remove unnecessary dependencies and IP clean

dmsolr opened a new pull request #45:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/45


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bugfix
   - Description
   
   - How to fix?
   
   1. remove unnecessary dependencies
   2. IP clean: to distinguish LICENSE and NOTICE for binary and source code distribution
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   
   - Source branch
   
   - Related commits and pull requests
   
   - Target branch
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] dmsolr commented on pull request #45: chore: remove unnecessary dependencies and IP clean

Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #45:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/45#issuecomment-870347451


   > Err... The CI is broken.
   
   Yeap. Because I removed the `logback`, but there is a test case depend on it. @tzssangglass is going to fix it and submit it soon. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] dmsolr commented on pull request #45: chore: remove unnecessary dependencies and IP clean

Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #45:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/45#issuecomment-870775007


   @tzssangglass hi, I found some cases depend on Logging. I think logging is unstable. It is also because it depends on `logback`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] spacewander merged pull request #45: chore: remove unnecessary dependencies and IP clean

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #45:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/45


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] spacewander commented on pull request #45: chore: remove unnecessary dependencies and IP clean

Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #45:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/45#issuecomment-870343621


   Err... The CI is broken.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #45: chore: remove unnecessary dependencies and IP clean

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #45:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/45#issuecomment-870803492


   > @tzssangglass hi, I found some cases depend on Logging. I think logging is unstable. It is also because it depends on `logback`.
   
   got, fix later
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] spacewander commented on pull request #45: chore: remove unnecessary dependencies and IP clean

Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #45:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/45#issuecomment-870343621


   Err... The CI is broken.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #45: chore: remove unnecessary dependencies and IP clean

Posted by GitBox <gi...@apache.org>.
tzssangglass commented on pull request #45:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/45#issuecomment-871871224


   @dmsolr is this PR ready？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-java-plugin-runner] dmsolr commented on pull request #45: chore: remove unnecessary dependencies and IP clean

Posted by GitBox <gi...@apache.org>.
dmsolr commented on pull request #45:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/45#issuecomment-870347451


   > Err... The CI is broken.
   
   Yeap. Because I removed the `logback`, but there is a test case depend on it. @tzssangglass is going to fix it and submit it soon. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org