You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2017/12/28 20:41:22 UTC
[Bug 7524] New: spamc.c getopt is not working on RHEL/CentOS 7.4
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7524
Bug ID: 7524
Summary: spamc.c getopt is not working on RHEL/CentOS 7.4
Product: Spamassassin
Version: 3.4.2
Hardware: PC
OS: Windows NT
Status: NEW
Severity: blocker
Priority: P2
Component: Regression Tests
Assignee: dev@spamassassin.apache.org
Reporter: kmcgrail@apache.org
Target Milestone: Undefined
I believe there are some issues with getopt and spamc.
For example, t/spamc_bug6196.t fails
Error in argument 7 : option not found --username=ignore_-F_switch
Changing --username= to short -u allows the test to work.
Testing on older boxes works fine.
Similar tests that fail:
t/spamc_headers.t (Wstat: 0 Tests: 5 Failed: 5)
Failed tests: 1-5
Error in argument 7 : option not found --connect-retries
--headers is seen as unknown option
t/spamc_x_E_R.t (Wstat: 0 Tests: 49 Failed: 2)
Failed tests: 32-33
Error in argument 7 : option not found --connect-retries
--connect-retries is seen as unknown option
Testing 3.4.1 on the same box passes
Digging further, I think this is the issue
https://svn.apache.org/viewvc/spamassassin/branches/3.4/spamc/getopt.c?r1=1804327&r2=1816710
It appears that the patch to spamc files didn't trigger a rebuild so my
previous regression test passed.
Reverting those patches
Trunk:
Committed revision 1816708.
3.4:
Committed revision 1816710.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7524] spamc.c getopt is not working on RHEL/CentOS 7.4
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7524
Kevin A. McGrail <km...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Kevin A. McGrail <km...@apache.org> ---
Looks like your logic is better now and regression tests pass. And I'll make
sure to run a make distclean so make test picks up changes in the spamc/ dir.
That's how this slipped through the first time.
3.4: Committed revision 1819449.
Trunk: Committed revision 1819448.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7524] spamc.c getopt is not working on RHEL/CentOS 7.4
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7524
Kevin A. McGrail <km...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #3 from Kevin A. McGrail <km...@apache.org> ---
Taking a look at the new patch.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7524] spamc.c getopt is not working on RHEL/CentOS 7.4
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7524
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |giovanni@paclan.it
--- Comment #2 from Giovanni Bechis <gi...@paclan.it> ---
Created attachment 5505
--> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5505&action=edit
free opt
There was a missing parenthesis on my previous patch, this one adds all
necessary free(3) calls and passes regression tests.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 7524] spamc.c getopt is not working on RHEL/CentOS 7.4
Posted by bu...@bugzilla.spamassassin.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7524
Kevin A. McGrail <km...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
CC| |kmcgrail@apache.org
Status|NEW |RESOLVED
--- Comment #1 from Kevin A. McGrail <km...@apache.org> ---
So clearly freeing opt was not a good idea :-)
Here are the commits reverting the free in bug 7509 in spamc/getopt.c
3.4: Committed revision 1819442.
Trunk: Committed revision 1819443.
--
You are receiving this mail because:
You are the assignee for the bug.