You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "CrazyHZM (via GitHub)" <gi...@apache.org> on 2023/06/13 12:28:52 UTC

[GitHub] [dubbo] CrazyHZM commented on a diff in pull request #12515: Disable all filters for internal service

CrazyHZM commented on code in PR #12515:
URL: https://github.com/apache/dubbo/pull/12515#discussion_r1228047436


##########
dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/integration/AbstractRegistryCenterExporterListener.java:
##########
@@ -56,7 +57,13 @@ public abstract class AbstractRegistryCenterExporterListener implements Exporter
     @Override
     public void exported(Exporter<?> exporter) throws RpcException {
         ListenerExporterWrapper listenerExporterWrapper = (ListenerExporterWrapper) exporter;
-        FilterChainBuilder.CallbackRegistrationInvoker callbackRegistrationInvoker = (FilterChainBuilder.CallbackRegistrationInvoker) listenerExporterWrapper.getInvoker();
+
+        Invoker invoker = listenerExporterWrapper.getInvoker();
+        if (!(invoker instanceof FilterChainBuilder.CallbackRegistrationInvoker)) {
+            exportedExporters.add(exporter);
+            return;
+        }

Review Comment:
   What is this scene? Can you give me a note? 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org