You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhishek Kumar <ab...@gmail.com> on 2022/03/31 20:44:49 UTC
Review Request 73923: Fix NullPointerException in Java Patch J10054
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73923/
-----------------------------------------------------------
Review request for ranger, Abhay Kulkarni, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3690
https://issues.apache.org/jira/browse/RANGER-3690
Repository: ranger
Description
-------
Null pointer exception is seen on line 87 in the java patch
PatchForSyncSourceUpdate_J10054 when a ranger upgrade takes place.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/patch/PatchForSyncSourceUpdate_J10054.java e6946b150
Diff: https://reviews.apache.org/r/73923/diff/1/
Testing
-------
Tested and confirmed no errors are seen on ranger_db_patch.log for patch no 054 when an upgrade happens.
Thanks,
Abhishek Kumar
Re: Review Request 73923: Fix NullPointerException in Java Patch J10054
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73923/#review224232
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On April 1, 2022, 2 a.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73923/
> -----------------------------------------------------------
>
> (Updated April 1, 2022, 2 a.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3690
> https://issues.apache.org/jira/browse/RANGER-3690
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Null pointer exception is seen on line 87 in the java patch
>
> PatchForSyncSourceUpdate_J10054 when a ranger upgrade takes place.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/patch/PatchForSyncSourceUpdate_J10054.java e6946b150
>
>
> Diff: https://reviews.apache.org/r/73923/diff/2/
>
>
> Testing
> -------
>
> Tested and confirmed no errors are seen on ranger_db_patch.log for patch no 054 when an upgrade happens.
>
>
> Thanks,
>
> Abhishek Kumar
>
>
Re: Review Request 73923: Fix NullPointerException in Java Patch J10054
Posted by Abhishek Kumar <ab...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73923/
-----------------------------------------------------------
(Updated April 1, 2022, 2 a.m.)
Review request for ranger, Abhay Kulkarni, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3690
https://issues.apache.org/jira/browse/RANGER-3690
Repository: ranger
Description
-------
Null pointer exception is seen on line 87 in the java patch
PatchForSyncSourceUpdate_J10054 when a ranger upgrade takes place.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/patch/PatchForSyncSourceUpdate_J10054.java e6946b150
Diff: https://reviews.apache.org/r/73923/diff/2/
Changes: https://reviews.apache.org/r/73923/diff/1-2/
Testing
-------
Tested and confirmed no errors are seen on ranger_db_patch.log for patch no 054 when an upgrade happens.
Thanks,
Abhishek Kumar
Re: Review Request 73923: Fix NullPointerException in Java Patch J10054
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73923/#review224231
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/patch/PatchForSyncSourceUpdate_J10054.java
Line 86 (original), 87 (patched)
<https://reviews.apache.org/r/73923/#comment313117>
For better readability, consider replacing "!StringUtils.isEmpty" with "StringUtils.isNotEmpty" - in #87, #90, #121, #123.
- Madhan Neethiraj
On March 31, 2022, 8:44 p.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73923/
> -----------------------------------------------------------
>
> (Updated March 31, 2022, 8:44 p.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3690
> https://issues.apache.org/jira/browse/RANGER-3690
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Null pointer exception is seen on line 87 in the java patch
>
> PatchForSyncSourceUpdate_J10054 when a ranger upgrade takes place.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/patch/PatchForSyncSourceUpdate_J10054.java e6946b150
>
>
> Diff: https://reviews.apache.org/r/73923/diff/1/
>
>
> Testing
> -------
>
> Tested and confirmed no errors are seen on ranger_db_patch.log for patch no 054 when an upgrade happens.
>
>
> Thanks,
>
> Abhishek Kumar
>
>