[GitHub] [rocketmq-client-go] wgdzlh opened a new issue, #1018: Faulty move of reference count of shared rmqClient

["wgdzlh (via GitHub)" <gi...@apache.org>]

wgdzlh opened a new issue, #1018:
URL: https://github.com/apache/rocketmq-client-go/issues/1018

   #888 change reference count of shared rmqClient into sync.Once body, which is buggy. The client will be shutdown once any consumer or producer call Shutdown, but it may be still used by other consumer or producer.
   The problem mentioned in #888 will not happen, since the start of client is called in sync.Once: https://github.com/apache/rocketmq-client-go/blob/6c77b6792c224cff2f3f971fc44d4a7ab0d8a29e/consumer/push_consumer.go#L161
   https://github.com/apache/rocketmq-client-go/blob/6c77b6792c224cff2f3f971fc44d4a7ab0d8a29e/consumer/consumer.go#L285, so it will only be called once. Multiple start call will not affect the reference count of client.
   Simply revert #888 will fix the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq-client-go] cserwen closed issue #1018: Faulty move of reference count of shared rmqClient

["cserwen (via GitHub)" <gi...@apache.org>]

cserwen closed issue #1018: Faulty move of reference count of shared rmqClient
URL: https://github.com/apache/rocketmq-client-go/issues/1018


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org