[jira] [Commented] (ORC-123) ToolTest.cc leaks memory

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15755211#comment-15755211 ] 

ASF GitHub Bot commented on ORC-123:
------------------------------------

Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/74#discussion_r92864389
  
    --- Diff: tools/test/ToolTest.cc ---
    @@ -82,8 +83,10 @@ int runProgram(const std::vector<std::string>& command,
                    std::string &err) {
     
       // create temporary filenames for stdout and stderr
    -  char *stdoutName = strdup("/tmp/orc-test-stdout-XXXXXXXX");
    -  char *stderrName = strdup("/tmp/orc-test-stderr-XXXXXXXX");
    --- End diff --
    
    `strdup` does a malloc internally and must be freed.


> ToolTest.cc leaks memory
> ------------------------
>
>                 Key: ORC-123
>                 URL: https://issues.apache.org/jira/browse/ORC-123
>             Project: Orc
>          Issue Type: Bug
>          Components: C++
>            Reporter: Deepak Majeti
>            Assignee: Deepak Majeti
>
> ToolTest.cc:111 {{argv}} is never freed.
> {{stdoutName}} and {{stderrName}} created by {{strdup}} are never freed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)