You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2017/04/03 22:35:39 UTC
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/
-----------------------------------------------------------
(Updated April 3, 2017, 10:35 p.m.)
Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
Bugs: MESOS-7015
https://issues.apache.org/jira/browse/MESOS-7015
Repository: mesos
Description
-------
Added unit tests to verify offers are suppressed based on registration.
Diffs (updated)
-----
src/tests/master_tests.cpp d1828eb42e0aedc9330c3786bbd9bb63aa42a64e
src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
Diff: https://reviews.apache.org/r/57818/diff/2/
Changes: https://reviews.apache.org/r/57818/diff/1-2/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/#review171002
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On April 3, 2017, 10:35 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57818/
> -----------------------------------------------------------
>
> (Updated April 3, 2017, 10:35 p.m.)
>
>
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-7015
> https://issues.apache.org/jira/browse/MESOS-7015
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests to verify offers are suppressed based on registration.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp d1828eb42e0aedc9330c3786bbd9bb63aa42a64e
> src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
>
>
> Diff: https://reviews.apache.org/r/57818/diff/2/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/#review171082
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57815, 57816, 57817, 57818]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 4, 2017, 10:37 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57818/
> -----------------------------------------------------------
>
> (Updated April 4, 2017, 10:37 p.m.)
>
>
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-7015
> https://issues.apache.org/jira/browse/MESOS-7015
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests to verify offers are suppressed based on registration.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp d1828eb42e0aedc9330c3786bbd9bb63aa42a64e
> src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
>
>
> Diff: https://reviews.apache.org/r/57818/diff/3/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/#review171679
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57815, 57816, 57817, 57818]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 11, 2017, 11:10 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57818/
> -----------------------------------------------------------
>
> (Updated April 11, 2017, 11:10 p.m.)
>
>
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-7015
> https://issues.apache.org/jira/browse/MESOS-7015
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests to verify offers are suppressed based on registration.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp d1828eb42e0aedc9330c3786bbd9bb63aa42a64e
> src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
>
>
> Diff: https://reviews.apache.org/r/57818/diff/4/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/#review175596
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57815, 57817, 57818]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 19, 2017, 6:26 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57818/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 6:26 p.m.)
>
>
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-7015
> https://issues.apache.org/jira/browse/MESOS-7015
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests to verify offers are suppressed based on registration.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
>
>
> Diff: https://reviews.apache.org/r/57818/diff/8/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/#review175850
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/scheduler_tests.cpp
Lines 1490 (patched)
<https://reviews.apache.org/r/57818/#comment249180>
s/all roles/its role/
- Vinod Kone
On May 19, 2017, 6:26 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57818/
> -----------------------------------------------------------
>
> (Updated May 19, 2017, 6:26 p.m.)
>
>
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-7015
> https://issues.apache.org/jira/browse/MESOS-7015
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests to verify offers are suppressed based on registration.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
>
>
> Diff: https://reviews.apache.org/r/57818/diff/8/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/#review176857
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57815, 57817, 57818]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On June 2, 2017, 9:29 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57818/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 9:29 p.m.)
>
>
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-7015
> https://issues.apache.org/jira/browse/MESOS-7015
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests to verify offers are suppressed based on registration.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
>
>
> Diff: https://reviews.apache.org/r/57818/diff/14/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/#review176964
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57815, 57817, 57818]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On June 5, 2017, 10:01 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57818/
> -----------------------------------------------------------
>
> (Updated June 5, 2017, 10:01 p.m.)
>
>
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-7015
> https://issues.apache.org/jira/browse/MESOS-7015
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests to verify offers are suppressed based on registration.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
>
>
> Diff: https://reviews.apache.org/r/57818/diff/15/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/
-----------------------------------------------------------
(Updated June 5, 2017, 10:01 p.m.)
Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-7015
https://issues.apache.org/jira/browse/MESOS-7015
Repository: mesos
Description
-------
Added unit tests to verify offers are suppressed based on registration.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
Diff: https://reviews.apache.org/r/57818/diff/15/
Changes: https://reviews.apache.org/r/57818/diff/14-15/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/
-----------------------------------------------------------
(Updated June 2, 2017, 9:29 p.m.)
Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
Changes
-------
rebased.
Bugs: MESOS-7015
https://issues.apache.org/jira/browse/MESOS-7015
Repository: mesos
Description
-------
Added unit tests to verify offers are suppressed based on registration.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
Diff: https://reviews.apache.org/r/57818/diff/14/
Changes: https://reviews.apache.org/r/57818/diff/13-14/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/#review176832
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57815, 57817, 57818]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On June 2, 2017, 5:50 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57818/
> -----------------------------------------------------------
>
> (Updated June 2, 2017, 5:50 p.m.)
>
>
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-7015
> https://issues.apache.org/jira/browse/MESOS-7015
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests to verify offers are suppressed based on registration.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
>
>
> Diff: https://reviews.apache.org/r/57818/diff/13/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/
-----------------------------------------------------------
(Updated June 2, 2017, 5:50 p.m.)
Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-7015
https://issues.apache.org/jira/browse/MESOS-7015
Repository: mesos
Description
-------
Added unit tests to verify offers are suppressed based on registration.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
Diff: https://reviews.apache.org/r/57818/diff/13/
Changes: https://reviews.apache.org/r/57818/diff/12-13/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/
-----------------------------------------------------------
(Updated June 1, 2017, 12:38 a.m.)
Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
Changes
-------
Fixed merge conflict.
Bugs: MESOS-7015
https://issues.apache.org/jira/browse/MESOS-7015
Repository: mesos
Description
-------
Added unit tests to verify offers are suppressed based on registration.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
Diff: https://reviews.apache.org/r/57818/diff/12/
Changes: https://reviews.apache.org/r/57818/diff/11-12/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/#review176553
-----------------------------------------------------------
Bad patch!
Reviews applied: [57818, 57817, 57815]
Failed command: python support/apply-reviews.py -n -r 57817
Error:
2017-05-31 23:39:53 URL:https://reviews.apache.org/r/57817/diff/raw/ [78096/78096] -> "57817.patch" [1]
error: patch failed: src/master/master.cpp:6237
error: src/master/master.cpp: patch does not apply
error: patch failed: src/tests/master_allocator_tests.cpp:1427
error: src/tests/master_allocator_tests.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/18228/console
- Mesos Reviewbot
On May 31, 2017, 2:53 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57818/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 2:53 p.m.)
>
>
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-7015
> https://issues.apache.org/jira/browse/MESOS-7015
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests to verify offers are suppressed based on registration.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
>
>
> Diff: https://reviews.apache.org/r/57818/diff/11/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/#review176455
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57815, 57817, 57818]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On May 31, 2017, 2:53 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57818/
> -----------------------------------------------------------
>
> (Updated May 31, 2017, 2:53 p.m.)
>
>
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-7015
> https://issues.apache.org/jira/browse/MESOS-7015
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests to verify offers are suppressed based on registration.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
>
>
> Diff: https://reviews.apache.org/r/57818/diff/11/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/
-----------------------------------------------------------
(Updated May 31, 2017, 2:53 p.m.)
Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
Changes
-------
rebase
Bugs: MESOS-7015
https://issues.apache.org/jira/browse/MESOS-7015
Repository: mesos
Description
-------
Added unit tests to verify offers are suppressed based on registration.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
Diff: https://reviews.apache.org/r/57818/diff/11/
Changes: https://reviews.apache.org/r/57818/diff/10-11/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/
-----------------------------------------------------------
(Updated May 31, 2017, 8 a.m.)
Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-7015
https://issues.apache.org/jira/browse/MESOS-7015
Repository: mesos
Description
-------
Added unit tests to verify offers are suppressed based on registration.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
Diff: https://reviews.apache.org/r/57818/diff/10/
Changes: https://reviews.apache.org/r/57818/diff/9-10/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/
-----------------------------------------------------------
(Updated May 23, 2017, 10:20 p.m.)
Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
Changes
-------
Addressed review comments.
Bugs: MESOS-7015
https://issues.apache.org/jira/browse/MESOS-7015
Repository: mesos
Description
-------
Added unit tests to verify offers are suppressed based on registration.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
Diff: https://reviews.apache.org/r/57818/diff/9/
Changes: https://reviews.apache.org/r/57818/diff/8-9/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/
-----------------------------------------------------------
(Updated May 19, 2017, 6:26 p.m.)
Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
Changes
-------
Updates based on agreed approach.
Bugs: MESOS-7015
https://issues.apache.org/jira/browse/MESOS-7015
Repository: mesos
Description
-------
Added unit tests to verify offers are suppressed based on registration.
Diffs (updated)
-----
src/tests/scheduler_tests.cpp d23a393a8123b7e1a0d613dec225daabe3694169
Diff: https://reviews.apache.org/r/57818/diff/8/
Changes: https://reviews.apache.org/r/57818/diff/7-8/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/#review174129
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57815, 57817, 57818]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 6, 2017, 3:30 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57818/
> -----------------------------------------------------------
>
> (Updated May 6, 2017, 3:30 p.m.)
>
>
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-7015
> https://issues.apache.org/jira/browse/MESOS-7015
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests to verify offers are suppressed based on registration.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp ceee2f4a5d38e0f4200f444769e058d2173de821
> src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
>
>
> Diff: https://reviews.apache.org/r/57818/diff/7/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/
-----------------------------------------------------------
(Updated May 6, 2017, 10:30 p.m.)
Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
Changes
-------
Rebased.
Bugs: MESOS-7015
https://issues.apache.org/jira/browse/MESOS-7015
Repository: mesos
Description
-------
Added unit tests to verify offers are suppressed based on registration.
Diffs (updated)
-----
src/tests/master_tests.cpp ceee2f4a5d38e0f4200f444769e058d2173de821
src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
Diff: https://reviews.apache.org/r/57818/diff/7/
Changes: https://reviews.apache.org/r/57818/diff/6-7/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/
-----------------------------------------------------------
(Updated May 5, 2017, 12:34 a.m.)
Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
Changes
-------
Modifications based on discussion in Slack.
Bugs: MESOS-7015
https://issues.apache.org/jira/browse/MESOS-7015
Repository: mesos
Description
-------
Added unit tests to verify offers are suppressed based on registration.
Diffs (updated)
-----
src/tests/master_tests.cpp ceee2f4a5d38e0f4200f444769e058d2173de821
src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
Diff: https://reviews.apache.org/r/57818/diff/6/
Changes: https://reviews.apache.org/r/57818/diff/5-6/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/#review172051
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57815, 57816, 57817, 57818]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 14, 2017, 11:41 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57818/
> -----------------------------------------------------------
>
> (Updated April 14, 2017, 11:41 p.m.)
>
>
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-7015
> https://issues.apache.org/jira/browse/MESOS-7015
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests to verify offers are suppressed based on registration.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp d1828eb42e0aedc9330c3786bbd9bb63aa42a64e
> src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
>
>
> Diff: https://reviews.apache.org/r/57818/diff/5/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/
-----------------------------------------------------------
(Updated April 15, 2017, 6:41 a.m.)
Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
Changes
-------
Updated based on review comments in this chain.
Bugs: MESOS-7015
https://issues.apache.org/jira/browse/MESOS-7015
Repository: mesos
Description
-------
Added unit tests to verify offers are suppressed based on registration.
Diffs (updated)
-----
src/tests/master_tests.cpp d1828eb42e0aedc9330c3786bbd9bb63aa42a64e
src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
Diff: https://reviews.apache.org/r/57818/diff/5/
Changes: https://reviews.apache.org/r/57818/diff/4-5/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/
-----------------------------------------------------------
(Updated April 11, 2017, 11:10 p.m.)
Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
Bugs: MESOS-7015
https://issues.apache.org/jira/browse/MESOS-7015
Repository: mesos
Description
-------
Added unit tests to verify offers are suppressed based on registration.
Diffs (updated)
-----
src/tests/master_tests.cpp d1828eb42e0aedc9330c3786bbd9bb63aa42a64e
src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
Diff: https://reviews.apache.org/r/57818/diff/4/
Changes: https://reviews.apache.org/r/57818/diff/3-4/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/
-----------------------------------------------------------
(Updated April 4, 2017, 10:37 p.m.)
Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
Bugs: MESOS-7015
https://issues.apache.org/jira/browse/MESOS-7015
Repository: mesos
Description
-------
Added unit tests to verify offers are suppressed based on registration.
Diffs (updated)
-----
src/tests/master_tests.cpp d1828eb42e0aedc9330c3786bbd9bb63aa42a64e
src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
Diff: https://reviews.apache.org/r/57818/diff/3/
Changes: https://reviews.apache.org/r/57818/diff/2-3/
Testing
-------
All tests passed.
Thanks,
Anindya Sinha
Re: Review Request 57818: Added unit tests to verify offers are
suppressed based on registration.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57818/#review170952
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57815, 57816, 57817, 57818]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 3, 2017, 10:35 p.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57818/
> -----------------------------------------------------------
>
> (Updated April 3, 2017, 10:35 p.m.)
>
>
> Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.
>
>
> Bugs: MESOS-7015
> https://issues.apache.org/jira/browse/MESOS-7015
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests to verify offers are suppressed based on registration.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp d1828eb42e0aedc9330c3786bbd9bb63aa42a64e
> src/tests/scheduler_tests.cpp 0f5d9ada6eb880379baf5f106fd2d5b12e9738db
>
>
> Diff: https://reviews.apache.org/r/57818/diff/2/
>
>
> Testing
> -------
>
> All tests passed.
>
>
> Thanks,
>
> Anindya Sinha
>
>