[GitHub] [spark] tomasbartalos commented on a change in pull request #23749: [SPARK-26841][SQL] Kafka timestamp pushdown

[GitBox <gi...@apache.org>]

tomasbartalos commented on a change in pull request #23749: [SPARK-26841][SQL] Kafka timestamp pushdown
URL: https://github.com/apache/spark/pull/23749#discussion_r266451978
 
 

 ##########
 File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaOffsetReader.scala
 ##########
 @@ -396,6 +406,8 @@ private[kafka010] class KafkaOffsetReader(
 }
 
 private[kafka010] object KafkaOffsetReader {
+  // offsets are not instances of Optional, we need special state for None
+  val EMPTY_OFFSET: Long = -100L
 
 Review comment:
   Completely agree with you (this is what the comment is trying to express). I tried to go with least invasive changes, but since you've pointed this out, I can change the offset map everywhere from:
   `Map[TopicPartition, Long]` to `Map[TopicPartition, Option[Long]]`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org