You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Adam Fisk (JIRA)" <ji...@apache.org> on 2009/12/17 03:17:18 UTC
[jira] Created: (CASSANDRA-638) Check SlicePredicate/ColumnParent
Column versus SuperColumn consistency
Check SlicePredicate/ColumnParent Column versus SuperColumn consistency
------------------------------------------------------------------------
Key: CASSANDRA-638
URL: https://issues.apache.org/jira/browse/CASSANDRA-638
Project: Cassandra
Issue Type: Improvement
Reporter: Adam Fisk
Priority: Minor
Fix For: 0.9
This crops up in any call taking both a ColumnParent and a SlicePredicate, as some settings apply only to Columns while others apply only to SuperColumns.
For example, it doesn't make sense to call setColumn_names on the SlicePredicate when the ColumnParent is a ColumnFamily that contains SuperColumns, as the return values will be SuperColumns, not Columns. The resulting error is currently difficult to decipher (16 byte UUID required).
Similarly, I'm not sure what happens if you don't call setColumn_names on the SlicePredicate in the case where you are querying a ColumnFamily with Columns, although I'm guessing it returns all column names.
Just a quick check to make sure the SlicePredicate doesn't have column names set when the ColumnParent is a SuperColumnFamily, returning a more informative error if so, should do the trick.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-638) Check SlicePredicate/ColumnParent
Column versus SuperColumn consistency
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791744#action_12791744 ]
Jonathan Ellis commented on CASSANDRA-638:
------------------------------------------
Do you think you could add a test to test/system/test_server.py illustrating what should be rejected?
(http://wiki.apache.org/cassandra/HowToContribute explains how to run the system tests)
> Check SlicePredicate/ColumnParent Column versus SuperColumn consistency
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-638
> URL: https://issues.apache.org/jira/browse/CASSANDRA-638
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Adam Fisk
> Priority: Minor
> Fix For: 0.9
>
>
> This crops up in any call taking both a ColumnParent and a SlicePredicate, as some settings apply only to Columns while others apply only to SuperColumns.
> For example, it doesn't make sense to call setColumn_names on the SlicePredicate when the ColumnParent is a ColumnFamily that contains SuperColumns, as the return values will be SuperColumns, not Columns. The resulting error is currently difficult to decipher (16 byte UUID required).
> Similarly, I'm not sure what happens if you don't call setColumn_names on the SlicePredicate in the case where you are querying a ColumnFamily with Columns, although I'm guessing it returns all column names.
> Just a quick check to make sure the SlicePredicate doesn't have column names set when the ColumnParent is a SuperColumnFamily, returning a more informative error if so, should do the trick.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-638) Check SlicePredicate/ColumnParent
Column versus SuperColumn consistency
Posted by "Adam Fisk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791832#action_12791832 ]
Adam Fisk commented on CASSANDRA-638:
-------------------------------------
I'm about 90% I did that, but I unfortunately won't be able to get back to that system and keep plugging away on this ticket until Monday. I'll pick it up then though.
Thanks Jonathan.
> Check SlicePredicate/ColumnParent Column versus SuperColumn consistency
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-638
> URL: https://issues.apache.org/jira/browse/CASSANDRA-638
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Adam Fisk
> Priority: Minor
> Fix For: 0.9
>
>
> This crops up in any call taking both a ColumnParent and a SlicePredicate, as some settings apply only to Columns while others apply only to SuperColumns.
> For example, it doesn't make sense to call setColumn_names on the SlicePredicate when the ColumnParent is a ColumnFamily that contains SuperColumns, as the return values will be SuperColumns, not Columns. The resulting error is currently difficult to decipher (16 byte UUID required).
> Similarly, I'm not sure what happens if you don't call setColumn_names on the SlicePredicate in the case where you are querying a ColumnFamily with Columns, although I'm guessing it returns all column names.
> Just a quick check to make sure the SlicePredicate doesn't have column names set when the ColumnParent is a SuperColumnFamily, returning a more informative error if so, should do the trick.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-638) Check SlicePredicate/ColumnParent
Column versus SuperColumn consistency
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791764#action_12791764 ]
Jonathan Ellis commented on CASSANDRA-638:
------------------------------------------
from trunk/interface/, run thrift -gen py cassandra.thrift, then run nosetests from trunk/
> Check SlicePredicate/ColumnParent Column versus SuperColumn consistency
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-638
> URL: https://issues.apache.org/jira/browse/CASSANDRA-638
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Adam Fisk
> Priority: Minor
> Fix For: 0.9
>
>
> This crops up in any call taking both a ColumnParent and a SlicePredicate, as some settings apply only to Columns while others apply only to SuperColumns.
> For example, it doesn't make sense to call setColumn_names on the SlicePredicate when the ColumnParent is a ColumnFamily that contains SuperColumns, as the return values will be SuperColumns, not Columns. The resulting error is currently difficult to decipher (16 byte UUID required).
> Similarly, I'm not sure what happens if you don't call setColumn_names on the SlicePredicate in the case where you are querying a ColumnFamily with Columns, although I'm guessing it returns all column names.
> Just a quick check to make sure the SlicePredicate doesn't have column names set when the ColumnParent is a SuperColumnFamily, returning a more informative error if so, should do the trick.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-638) Check SlicePredicate/ColumnParent
Column versus SuperColumn consistency
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-638.
--------------------------------------
Resolution: Incomplete
> Check SlicePredicate/ColumnParent Column versus SuperColumn consistency
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-638
> URL: https://issues.apache.org/jira/browse/CASSANDRA-638
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Adam Fisk
> Priority: Minor
> Fix For: 0.6
>
>
> This crops up in any call taking both a ColumnParent and a SlicePredicate, as some settings apply only to Columns while others apply only to SuperColumns.
> For example, it doesn't make sense to call setColumn_names on the SlicePredicate when the ColumnParent is a ColumnFamily that contains SuperColumns, as the return values will be SuperColumns, not Columns. The resulting error is currently difficult to decipher (16 byte UUID required).
> Similarly, I'm not sure what happens if you don't call setColumn_names on the SlicePredicate in the case where you are querying a ColumnFamily with Columns, although I'm guessing it returns all column names.
> Just a quick check to make sure the SlicePredicate doesn't have column names set when the ColumnParent is a SuperColumnFamily, returning a more informative error if so, should do the trick.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-638) Check SlicePredicate/ColumnParent
Column versus SuperColumn consistency
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794826#action_12794826 ]
Jonathan Ellis commented on CASSANDRA-638:
------------------------------------------
ping
> Check SlicePredicate/ColumnParent Column versus SuperColumn consistency
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-638
> URL: https://issues.apache.org/jira/browse/CASSANDRA-638
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Adam Fisk
> Priority: Minor
> Fix For: 0.9
>
>
> This crops up in any call taking both a ColumnParent and a SlicePredicate, as some settings apply only to Columns while others apply only to SuperColumns.
> For example, it doesn't make sense to call setColumn_names on the SlicePredicate when the ColumnParent is a ColumnFamily that contains SuperColumns, as the return values will be SuperColumns, not Columns. The resulting error is currently difficult to decipher (16 byte UUID required).
> Similarly, I'm not sure what happens if you don't call setColumn_names on the SlicePredicate in the case where you are querying a ColumnFamily with Columns, although I'm guessing it returns all column names.
> Just a quick check to make sure the SlicePredicate doesn't have column names set when the ColumnParent is a SuperColumnFamily, returning a more informative error if so, should do the trick.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-638) Check SlicePredicate/ColumnParent
Column versus SuperColumn consistency
Posted by "Adam Fisk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791757#action_12791757 ]
Adam Fisk commented on CASSANDRA-638:
-------------------------------------
No problem. I'm new to nosetests, though, and running nosetests test/system/test_server.py can't find Thrift:
ERROR: Failure: ImportError (No module named thrift.transport)
What's the best way to wire that up? I synced up my Thrift version with trunk and all that.
> Check SlicePredicate/ColumnParent Column versus SuperColumn consistency
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-638
> URL: https://issues.apache.org/jira/browse/CASSANDRA-638
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Adam Fisk
> Priority: Minor
> Fix For: 0.9
>
>
> This crops up in any call taking both a ColumnParent and a SlicePredicate, as some settings apply only to Columns while others apply only to SuperColumns.
> For example, it doesn't make sense to call setColumn_names on the SlicePredicate when the ColumnParent is a ColumnFamily that contains SuperColumns, as the return values will be SuperColumns, not Columns. The resulting error is currently difficult to decipher (16 byte UUID required).
> Similarly, I'm not sure what happens if you don't call setColumn_names on the SlicePredicate in the case where you are querying a ColumnFamily with Columns, although I'm guessing it returns all column names.
> Just a quick check to make sure the SlicePredicate doesn't have column names set when the ColumnParent is a SuperColumnFamily, returning a more informative error if so, should do the trick.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-638) Check SlicePredicate/ColumnParent
Column versus SuperColumn consistency
Posted by "Adam Fisk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803571#action_12803571 ]
Adam Fisk commented on CASSANDRA-638:
-------------------------------------
Sorry Jonathan -- got outrageously busy. I can still take a look at this, but I'm really not sure when I'll realistically get to it.
> Check SlicePredicate/ColumnParent Column versus SuperColumn consistency
> ------------------------------------------------------------------------
>
> Key: CASSANDRA-638
> URL: https://issues.apache.org/jira/browse/CASSANDRA-638
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Adam Fisk
> Priority: Minor
> Fix For: 0.6
>
>
> This crops up in any call taking both a ColumnParent and a SlicePredicate, as some settings apply only to Columns while others apply only to SuperColumns.
> For example, it doesn't make sense to call setColumn_names on the SlicePredicate when the ColumnParent is a ColumnFamily that contains SuperColumns, as the return values will be SuperColumns, not Columns. The resulting error is currently difficult to decipher (16 byte UUID required).
> Similarly, I'm not sure what happens if you don't call setColumn_names on the SlicePredicate in the case where you are querying a ColumnFamily with Columns, although I'm guessing it returns all column names.
> Just a quick check to make sure the SlicePredicate doesn't have column names set when the ColumnParent is a SuperColumnFamily, returning a more informative error if so, should do the trick.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.