[jira] [Commented] (SOLR-15955) Update Jetty dependency to 10

["Mark Robert Miller (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-15955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485396#comment-17485396 ] 

Mark Robert Miller commented on SOLR-15955:
-------------------------------------------

PR coming in a moment. I ended up going back and minimizing the changes to even more minimal. The claim is that Jetty 10 is Jetty 11 without the javax->jakarta package rename, but that appears to be goal more than reality. I've experienced it before with runtime differences and here I see there are compile-time differences - Jetty 10 is more backward compatible with some APIs than 11. So I have removed some unnecessary changes I had introduced when attempting Jetty 11. A lot of the HTTP client API was overhauled and there are many improvements, but in this issue, my goal was to have as few changes as possible.

There still is a remaining issue though, one that I knew of but hoped wouldn't cause me an issue here. Jetty 10 is much more sensitive to poor connection, client->server code. Unfortunately, that means random fails in tests involving JavaBinCodec EOFExceptions and crypto-related fails. I'm looking to see if that can be stabilized with relatively few adjustments - at least to the current test pass rate.

> Update Jetty dependency to 10
> -----------------------------
>
>                 Key: SOLR-15955
>                 URL: https://issues.apache.org/jira/browse/SOLR-15955
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mark Robert Miller
>            Assignee: Mark Robert Miller
>            Priority: Major
>
> Jetty 9 is going end of life - I have a patch for the minimal changes needed to move to 10. Jetty 11 is the same as 10, but moves the javax package to jakarta, which the hdfs test dependency on jetty conflicts with.
> There is still an unresolved issue with S3 tests and their Jetty dependency, even with 10, that I’m still looking into. I’ll put up a PR tomorrow with a few more details. It may be without a resolution for the S3 test dependency yet, looking into what might be done. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org