You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org> on 2006/07/25 17:49:15 UTC
[jira] Created: (GERONIMO-2227) ENC Lookup Fix (include parent
modules)
ENC Lookup Fix (include parent modules)
---------------------------------------
Key: GERONIMO-2227
URL: http://issues.apache.org/jira/browse/GERONIMO-2227
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Affects Versions: 1.1
Reporter: Aaron Mulder
Assigned To: David Jencks
Fix For: 1.1.1
I ran across this while working on plugins that use resource-ref-like features to identify a database connection pool.
The problem was that some naming searches were restricted to the current module only when I felt all parents should be searched too.
I would like David J to review this before I commit it, as my understanding of the code in question is not terribly thorough.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2227) ENC Lookup Fix (include parent
modules)
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2227?page=comments#action_12423861 ]
Aaron Mulder commented on GERONIMO-2227:
----------------------------------------
Unfortunately, I don't have an example. This change was left on my tree and I've forgotten specifically what I ran into to cause me to do it. I do remember that I ended up debugging extensively and finally found that the commented-out line was causing the wrong module to be searched, but that's already in there and I can't remember what the new changes were addressing.
I guess we better put this on hold until I can recreate the problem.
> ENC Lookup Fix (include parent modules)
> ---------------------------------------
>
> Key: GERONIMO-2227
> URL: http://issues.apache.org/jira/browse/GERONIMO-2227
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 1.1
> Reporter: Aaron Mulder
> Assigned To: David Jencks
> Fix For: 1.1.1
>
> Attachments: 2227-enc-include-parents.patch
>
>
> I ran across this while working on plugins that use resource-ref-like features to identify a database connection pool, JMS destination, etc.
> The problem was that some naming searches were restricted to the current module only when I felt all parents should be searched too.
> I would like David J to review this before I commit it, as my understanding of the code in question is not terribly thorough.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-2227) ENC Lookup Fix (include parent
modules)
Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2227?page=comments#action_12423859 ]
David Jencks commented on GERONIMO-2227:
----------------------------------------
Maybe I'm missing something, but you patch appears to assign null to an already null variable. It also doesn't address the issue of looking in parents. I also don't understand where the line
- //moduleURI = linkName.substring(0, pos);
you are proposing to remove came from and think that it would be correct. The idea is that is you specify
j2ee-module#admin-object-name
we will only look in that particular j2ee module, not some other that might have a similarly named admin object.
Do you have an sample to show the problem you are trying to solve?
> ENC Lookup Fix (include parent modules)
> ---------------------------------------
>
> Key: GERONIMO-2227
> URL: http://issues.apache.org/jira/browse/GERONIMO-2227
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 1.1
> Reporter: Aaron Mulder
> Assigned To: David Jencks
> Fix For: 1.1.1
>
> Attachments: 2227-enc-include-parents.patch
>
>
> I ran across this while working on plugins that use resource-ref-like features to identify a database connection pool, JMS destination, etc.
> The problem was that some naming searches were restricted to the current module only when I felt all parents should be searched too.
> I would like David J to review this before I commit it, as my understanding of the code in question is not terribly thorough.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2227) ENC Lookup Fix (include parent
modules)
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2227?page=all ]
Aaron Mulder updated GERONIMO-2227:
-----------------------------------
Fix Version/s: 1.x
(was: 1.1.1)
> ENC Lookup Fix (include parent modules)
> ---------------------------------------
>
> Key: GERONIMO-2227
> URL: http://issues.apache.org/jira/browse/GERONIMO-2227
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 1.1
> Reporter: Aaron Mulder
> Assigned To: David Jencks
> Fix For: 1.x
>
> Attachments: 2227-enc-include-parents.patch
>
>
> I ran across this while working on plugins that use resource-ref-like features to identify a database connection pool, JMS destination, etc.
> The problem was that some naming searches were restricted to the current module only when I felt all parents should be searched too.
> I would like David J to review this before I commit it, as my understanding of the code in question is not terribly thorough.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2227) ENC Lookup Fix (include parent
modules)
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2227?page=all ]
Aaron Mulder updated GERONIMO-2227:
-----------------------------------
Description:
I ran across this while working on plugins that use resource-ref-like features to identify a database connection pool, JMS destination, etc.
The problem was that some naming searches were restricted to the current module only when I felt all parents should be searched too.
I would like David J to review this before I commit it, as my understanding of the code in question is not terribly thorough.
was:
I ran across this while working on plugins that use resource-ref-like features to identify a database connection pool.
The problem was that some naming searches were restricted to the current module only when I felt all parents should be searched too.
I would like David J to review this before I commit it, as my understanding of the code in question is not terribly thorough.
> ENC Lookup Fix (include parent modules)
> ---------------------------------------
>
> Key: GERONIMO-2227
> URL: http://issues.apache.org/jira/browse/GERONIMO-2227
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 1.1
> Reporter: Aaron Mulder
> Assigned To: David Jencks
> Fix For: 1.1.1
>
> Attachments: 2227-enc-include-parents.patch
>
>
> I ran across this while working on plugins that use resource-ref-like features to identify a database connection pool, JMS destination, etc.
> The problem was that some naming searches were restricted to the current module only when I felt all parents should be searched too.
> I would like David J to review this before I commit it, as my understanding of the code in question is not terribly thorough.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2227) ENC Lookup Fix (include parent
modules)
Posted by "Aaron Mulder (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2227?page=all ]
Aaron Mulder updated GERONIMO-2227:
-----------------------------------
Attachment: 2227-enc-include-parents.patch
> ENC Lookup Fix (include parent modules)
> ---------------------------------------
>
> Key: GERONIMO-2227
> URL: http://issues.apache.org/jira/browse/GERONIMO-2227
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 1.1
> Reporter: Aaron Mulder
> Assigned To: David Jencks
> Fix For: 1.1.1
>
> Attachments: 2227-enc-include-parents.patch
>
>
> I ran across this while working on plugins that use resource-ref-like features to identify a database connection pool.
> The problem was that some naming searches were restricted to the current module only when I felt all parents should be searched too.
> I would like David J to review this before I commit it, as my understanding of the code in question is not terribly thorough.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2227) ENC Lookup Fix (include parent
modules)
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-2227?page=all ]
David Jencks updated GERONIMO-2227:
-----------------------------------
Fix Version/s: Wish List
(was: 1.x)
Assignee: Aaron Mulder (was: David Jencks)
Don't see how to progress without more info...
> ENC Lookup Fix (include parent modules)
> ---------------------------------------
>
> Key: GERONIMO-2227
> URL: http://issues.apache.org/jira/browse/GERONIMO-2227
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 1.1
> Reporter: Aaron Mulder
> Assigned To: Aaron Mulder
> Fix For: Wish List
>
> Attachments: 2227-enc-include-parents.patch
>
>
> I ran across this while working on plugins that use resource-ref-like features to identify a database connection pool, JMS destination, etc.
> The problem was that some naming searches were restricted to the current module only when I felt all parents should be searched too.
> I would like David J to review this before I commit it, as my understanding of the code in question is not terribly thorough.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-2227) ENC Lookup Fix (include parent
modules)
Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Dillon updated GERONIMO-2227:
-----------------------------------
Component/s: naming
> ENC Lookup Fix (include parent modules)
> ---------------------------------------
>
> Key: GERONIMO-2227
> URL: https://issues.apache.org/jira/browse/GERONIMO-2227
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: naming
> Affects Versions: 1.1
> Reporter: Aaron Mulder
> Assignee: Aaron Mulder
> Fix For: Wish List
>
> Attachments: 2227-enc-include-parents.patch
>
>
> I ran across this while working on plugins that use resource-ref-like features to identify a database connection pool, JMS destination, etc.
> The problem was that some naming searches were restricted to the current module only when I felt all parents should be searched too.
> I would like David J to review this before I commit it, as my understanding of the code in question is not terribly thorough.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.