You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/03/03 01:00:37 UTC

[GitHub] john-bodley opened a new pull request #4524: [setup] Adding requirements.txt

john-bodley opened a new pull request #4524: [setup] Adding requirements.txt
URL: https://github.com/apache/incubator-superset/pull/4524
 
 
   I realize that Superset is an application rather than a library but when defining Python packages but `setup.py` should only contain abstract dependencies as described in detail [here](https://caremad.io/posts/2013/07/setup-vs-requirement/). 
   
   This PR performs the following changes:
   1. Removes the pinned versions from `setup.py`
   2. Adds a `requirements.txt` which explicitly pins every abstract dependency defined in `setup.py`. This helps to ensure consistent installation, which previously wasn't guaranteed when ranges or bounds were defined.
   3. Alphabetizes dependencies.
   4. Updates the documentation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services