[GitHub] [activemq-artemis] gemmellr commented on a change in pull request #2882: NO-JIRA fix divert test

[GitBox <gi...@apache.org>]

gemmellr commented on a change in pull request #2882: NO-JIRA fix divert test
URL: https://github.com/apache/activemq-artemis/pull/2882#discussion_r342672941
 
 

 ##########
 File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/divert/DivertTest.java
 ##########
 @@ -169,7 +169,7 @@ public void testCrossProtocol() throws Exception {
 
          session.createQueue(new SimpleString(testForConvert), RoutingType.ANYCAST, SimpleString.toSimpleString(testForConvert), null, true);
 
-         session.createQueue(new SimpleString(forwardAddress), RoutingType.MULTICAST, queueName2, null, true);
 
 Review comment:
   Nitpicking, but if this is essentially a missing test change from ARTEMIS-2504 it should be committed against ARTEMIS-2504 rather than as a NO-JIRA change, especially if no release has gone out yet. It makes it much easier later to tell why the change was made or needed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services