You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/11/02 21:33:02 UTC

[GitHub] [helix] somecodemonkey commented on a diff in pull request #2263: 2259/send identity token

somecodemonkey commented on code in PR #2263:
URL: https://github.com/apache/helix/pull/2263#discussion_r1012316082


##########
helix-front/server/controllers/helix.ts:
##########
@@ -50,6 +50,12 @@ export class HelixCtrl {
           'Helix-User': user,
         },
       };
+
+      if (IDENTITY_TOKEN_SOURCE) {
+        options.headers['Identity-Token'] =
+          res.locals.cookie['helixui_identity.token'];
+      }

Review Comment:
   Minor suggestion, the keys 'Identity-Token' and 'helixui_identity.token' are also used elsewhere, I suggest putting them in a constants. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org