[jira] [Commented] (GIRAPH-537) Log message for aggregators has cryptic wording

["Maja Kabiljo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GIRAPH-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13606886#comment-13606886 ] 

Maja Kabiljo commented on GIRAPH-537:
-------------------------------------

https://reviews.apache.org/r/10029/
                
> Log message for aggregators has cryptic wording
> -----------------------------------------------
>
>                 Key: GIRAPH-537
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-537
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Alessandro Presta
>            Assignee: Maja Kabiljo
>         Attachments: GIRAPH-537.patch
>
>
> When workers are synchronizing aggregators using the ExpectedBarrier class, the following message is printed:
> "waitForRequiredPermits: Waiting for times required to be X (currently Y)"
> I find this doesn't convey much about what exactly we're waiting for.
> We should make the log more meaningful and explicitly mention aggregators, at the cost of simplifying things a bit.
> Additionally, we could skip it altogether when no aggregators are being used.
> The ExpectedBarrier class itself also lacks clear documentation: what is this class for? The Javadoc explains how it works without first stating what it is.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira