You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2016/01/15 16:30:29 UTC
[GitHub] couchdb-fauxton pull request: transpile with babel
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/609
transpile with babel
Hello ES6 and React 14! :sunny:
Additional changes:
- optimize watch task: run stylecheck before to provide faster
feedback
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton babel-latest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/609.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #609
----
commit 1db75f744e5baf6bff88cb2f808f9af64bdd9c38
Author: Robert Kowalski <ro...@apache.org>
Date: 2016-01-15T14:52:02Z
transpile with babel
Hello ES6 and React 14!
Additional changes:
- optimize watch task: run stylecheck before to provide faster
feedback
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: transpile with babel
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/609#discussion_r49926028
--- Diff: Gruntfile.js ---
@@ -376,39 +383,26 @@ module.exports = function (grunt) {
// compile the single JSX file into the appropriate Fauxton folder
var targetFilepath = filepath;
- if (isJSX) {
- var folder = filepath.replace(/\/[^\/]*$/, '');
- var targetFolder = folder;
-
- // if the JSX file ISN'T in Fauxton, generate the .js file there
- if (!(/^app\/addons/.test(folder))) {
- targetFolder = folder.replace(/.*\/addons/, 'app/addons');
- }
- targetFilepath = filepath.replace(/.*\/addons/, 'app/addons');
- targetFilepath = targetFilepath.replace(/\.jsx$/, '.js');
- config.shell['build-single-jsx'].command = 'node ./node_modules/react-tools/bin/jsx -x jsx ' + folder + ' ' + targetFolder + ' --no-cache-dir';
- grunt.task.run(['shell:build-single-jsx']);
- }
+ var folder = filepath.replace(/\/[^\/]*$/, '');
+ var targetFolder = folder;
- // if the JS file that just changed was outside of Fauxton, copy it over
- if (isJS && !(/^app\/addons/.test(filepath))) {
- config.copy.changedFiles.files = [{
- src: filepath,
- dest: filepath.replace(/.*\/addons/, 'app/addons')
- }];
- grunt.task.run(['copy:changedFiles']);
- }
--- End diff --
I'm not sure. The purpose of this code was for local dev to ensure any changed JS files in the dash get copied over immediately (i.e. as you change them). Won't this condition still apply with the new folder structure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: transpile with babel
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/609#issuecomment-172879921
@benkeen i had to disable the ES6 transpiling as it seems to break with phantomjs... so far haven't found out the issue.
it looks like nothing breaks now, can you retest?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: transpile with babel
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/609
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: transpile with babel
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/609#issuecomment-172149755
Super exciting. :D Can't wait to get React 14 in there.
From what I can see, this look good. It does break the dash, though ['cannot read property jQuery of undefined` / `cannot set property Backbone` of undefined].
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: transpile with babel
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/609#discussion_r49865782
--- Diff: Gruntfile.js ---
@@ -376,39 +383,26 @@ module.exports = function (grunt) {
// compile the single JSX file into the appropriate Fauxton folder
var targetFilepath = filepath;
- if (isJSX) {
- var folder = filepath.replace(/\/[^\/]*$/, '');
- var targetFolder = folder;
-
- // if the JSX file ISN'T in Fauxton, generate the .js file there
- if (!(/^app\/addons/.test(folder))) {
- targetFolder = folder.replace(/.*\/addons/, 'app/addons');
- }
- targetFilepath = filepath.replace(/.*\/addons/, 'app/addons');
- targetFilepath = targetFilepath.replace(/\.jsx$/, '.js');
- config.shell['build-single-jsx'].command = 'node ./node_modules/react-tools/bin/jsx -x jsx ' + folder + ' ' + targetFolder + ' --no-cache-dir';
- grunt.task.run(['shell:build-single-jsx']);
- }
+ var folder = filepath.replace(/\/[^\/]*$/, '');
+ var targetFolder = folder;
- // if the JS file that just changed was outside of Fauxton, copy it over
- if (isJS && !(/^app\/addons/.test(filepath))) {
- config.copy.changedFiles.files = [{
- src: filepath,
- dest: filepath.replace(/.*\/addons/, 'app/addons')
- }];
- grunt.task.run(['copy:changedFiles']);
- }
--- End diff --
i am not sure about the intention of the code code and it does not seem to make sense with all required js and compiled js files in the new dev server directory any more - can you confirm that @benkeen ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: transpile with babel
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/609#issuecomment-181460784
merged as cfc664d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: transpile with babel
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/609#issuecomment-181452733
+1 looks great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: transpile with babel
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/609#issuecomment-173686010
Looks good from here. There's a wayward console.log() in `routes-mango.js` but it looks like that snuck in in another ticket.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---