You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Benson Margulies <bi...@gmail.com> on 2011/11/20 14:00:22 UTC

Re: Maven shade plugin question

Trask,

No problem, but in the future feel free to send such a thing to the
maven dev list.

I'll look at your patch. Honestly, there's no one who is very reliably
looking for new patches across many of the plugins, so a ping is a
good idea.

We generally don't release for only one patch, and we released
recently, but if it fixes a howler and it would help you I'll try to
also turn the crank.

--benson


On Sun, Nov 20, 2011 at 4:41 AM, Trask Stalnaker
<tr...@gmail.com> wrote:
> Hi Benson,
> I hope you don't mind me emailing you directly.  I noticed that you have
> made the last few contributions to the maven shade plugin.
> I have submitted https://jira.codehaus.org/browse/MSHADE-104 a month or two
> ago.  I just updated the jira ticket tonight with a second version of the
> patch.
> Is there anything I can do to help this patch get accepted into the maven
> shade plugin trunk?  I'm happy to make any modifications to the patch that
> you would like to see, and I can provide more
> docs/examples/tests/explanations/etc if that will help.
> Thank you for your time.
> Sincerely,
> Trask Stalnaker
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Maven shade plugin question

Posted by Trask Stalnaker <tr...@gmail.com>.
Thanks for reviewing and committing the patch.  Could you also deploy a new
snapshot build to the apache snapshot repository?

Thanks,
Trask

On Sun, Nov 20, 2011 at 10:12 AM, Trask Stalnaker <trask.stalnaker@gmail.com
> wrote:

> Thanks so much for the response.  I look forward to your review of the
> patch.  I'm happy to re-write it taking a different approach if you see
> fit, so just shoot me your feedback.
>
> Thanks again.
>
> Trask
>
>
> On Sun, Nov 20, 2011 at 5:00 AM, Benson Margulies <bi...@gmail.com>wrote:
>
>> Trask,
>>
>> No problem, but in the future feel free to send such a thing to the
>> maven dev list.
>>
>> I'll look at your patch. Honestly, there's no one who is very reliably
>> looking for new patches across many of the plugins, so a ping is a
>> good idea.
>>
>> We generally don't release for only one patch, and we released
>> recently, but if it fixes a howler and it would help you I'll try to
>> also turn the crank.
>>
>> --benson
>>
>>
>> On Sun, Nov 20, 2011 at 4:41 AM, Trask Stalnaker
>> <tr...@gmail.com> wrote:
>> > Hi Benson,
>> > I hope you don't mind me emailing you directly.  I noticed that you have
>> > made the last few contributions to the maven shade plugin.
>> > I have submitted https://jira.codehaus.org/browse/MSHADE-104 a month
>> or two
>> > ago.  I just updated the jira ticket tonight with a second version of
>> the
>> > patch.
>> > Is there anything I can do to help this patch get accepted into the
>> maven
>> > shade plugin trunk?  I'm happy to make any modifications to the patch
>> that
>> > you would like to see, and I can provide more
>> > docs/examples/tests/explanations/etc if that will help.
>> > Thank you for your time.
>> > Sincerely,
>> > Trask Stalnaker
>> >
>>
>
>

Re: Maven shade plugin question

Posted by Trask Stalnaker <tr...@gmail.com>.
Thanks so much for the response.  I look forward to your review of the
patch.  I'm happy to re-write it taking a different approach if you see
fit, so just shoot me your feedback.

Thanks again.

Trask

On Sun, Nov 20, 2011 at 5:00 AM, Benson Margulies <bi...@gmail.com>wrote:

> Trask,
>
> No problem, but in the future feel free to send such a thing to the
> maven dev list.
>
> I'll look at your patch. Honestly, there's no one who is very reliably
> looking for new patches across many of the plugins, so a ping is a
> good idea.
>
> We generally don't release for only one patch, and we released
> recently, but if it fixes a howler and it would help you I'll try to
> also turn the crank.
>
> --benson
>
>
> On Sun, Nov 20, 2011 at 4:41 AM, Trask Stalnaker
> <tr...@gmail.com> wrote:
> > Hi Benson,
> > I hope you don't mind me emailing you directly.  I noticed that you have
> > made the last few contributions to the maven shade plugin.
> > I have submitted https://jira.codehaus.org/browse/MSHADE-104 a month or
> two
> > ago.  I just updated the jira ticket tonight with a second version of the
> > patch.
> > Is there anything I can do to help this patch get accepted into the maven
> > shade plugin trunk?  I'm happy to make any modifications to the patch
> that
> > you would like to see, and I can provide more
> > docs/examples/tests/explanations/etc if that will help.
> > Thank you for your time.
> > Sincerely,
> > Trask Stalnaker
> >
>