You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "akpatnam25 (via GitHub)" <gi...@apache.org> on 2024/08/21 20:32:43 UTC
[PR] [CELEBORN-1573] Change to debug logging on client side for reserve slots [celeborn]
akpatnam25 opened a new pull request, #2700:
URL: https://github.com/apache/celeborn/pull/2700
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Change client side reserve slots log to debug.
### Why are the changes needed?
in a large fleet of workers such as ours, it is noisy for the user in the driver logs.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1573] Change to debug logging on client side for reserve slots [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on code in PR #2700:
URL: https://github.com/apache/celeborn/pull/2700#discussion_r1726194582
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -651,7 +651,7 @@ class LifecycleManager(val appUniqueId: String, val conf: CelebornConf) extends
replyRegisterShuffle(RegisterShuffleResponse(StatusCode.SLOT_NOT_AVAILABLE, Array.empty))
return
case StatusCode.SUCCESS =>
- logInfo(s"OfferSlots for $shuffleId Success!Slots Info: ${res.workerResource}")
+ logDebug(s"OfferSlots for $shuffleId Success!Slots Info: ${res.workerResource}")
Review Comment:
I disagree with this suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1573] Change to debug logging on client side for reserve slots [celeborn]
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #2700:
URL: https://github.com/apache/celeborn/pull/2700#discussion_r1726181283
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -651,7 +651,7 @@ class LifecycleManager(val appUniqueId: String, val conf: CelebornConf) extends
replyRegisterShuffle(RegisterShuffleResponse(StatusCode.SLOT_NOT_AVAILABLE, Array.empty))
return
case StatusCode.SUCCESS =>
- logInfo(s"OfferSlots for $shuffleId Success!Slots Info: ${res.workerResource}")
+ logDebug(s"OfferSlots for $shuffleId Success!Slots Info: ${res.workerResource}")
Review Comment:
```suggestion
if (log.isDebugEnabled()) {
logDebug(s"OfferSlots for $shuffleId Success!Slots Info: ${res.workerResource}")
} else {
logInfo(
s"OfferSlots for $shuffleId Success!Slots Info size: ${res.workerResource.size()}")
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1573] Change to debug logging on client side for reserve slots [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #2700: [CELEBORN-1573] Change to debug logging on client side for reserve slots
URL: https://github.com/apache/celeborn/pull/2700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1573] Change to debug logging on client side for reserve slots [celeborn]
Posted by "s0nskar (via GitHub)" <gi...@apache.org>.
s0nskar commented on PR #2700:
URL: https://github.com/apache/celeborn/pull/2700#issuecomment-2303946849
> Maybe print this log to one line can be helpful.
@FMX i created a PR sometime back to support single line logging – https://github.com/apache/celeborn/pull/2672. Let me wdyt about this, i'll extend it to other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1573] Change to debug logging on client side for reserve slots [celeborn]
Posted by "s0nskar (via GitHub)" <gi...@apache.org>.
s0nskar commented on PR #2700:
URL: https://github.com/apache/celeborn/pull/2700#issuecomment-2303798387
I think this change can make retrospective debugging hard as we will no insight into which workers the shuffle data was written to, what was the behaviour of workers during that time.
Instead of making it completely a debug log IMO we should at least output some basic info about the worker host selected for shuffle this will reduce the noise but also leave some space for debugging issues.
Ex –
```
Host: 10.152.63.41
WorkerStatus: WorkerStatus{state=Normal, stateStartTime=1724244049248}
NumOfSlotsAllocated: 100
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1573] Change to debug logging on client side for reserve slots [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #2700:
URL: https://github.com/apache/celeborn/pull/2700#issuecomment-2303904780
> > > I think this change can make retrospective debugging hard as we will have no insight into which workers the shuffle data was written to and what was the behaviour of those workers during that time.
> > > Instead of making it completely a debug log IMO we should at least output some basic info about the worker host selected for shuffle this will reduce the noise but also leave some space for debugging issues.
> > > Ex –
> > > ```
> > > Host: 10.152.63.41
> > > WorkerStatus: WorkerStatus{state=Normal, stateStartTime=1724244049248}
> > > NumOfSlotsAllocated: 100
> > > ```
> >
> >
> > I think this will still be noisy in a large fleet, especially in the driver logs where users might be looking for other logs/errors. I feel that if truly needed for debugging, the user can then enable debug logging for it.
>
> Maybe print this log to one line can be helpful.
Setting the logger levels for components could be the ultimate solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1573] Change to debug logging on client side for reserve slots [celeborn]
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #2700:
URL: https://github.com/apache/celeborn/pull/2700#issuecomment-2303894127
> > I think this change can make retrospective debugging hard as we will have no insight into which workers the shuffle data was written to and what was the behaviour of those workers during that time.
> > Instead of making it completely a debug log IMO we should at least output some basic info about the worker host selected for shuffle this will reduce the noise but also leave some space for debugging issues.
> > Ex –
> > ```
> > Host: 10.152.63.41
> > WorkerStatus: WorkerStatus{state=Normal, stateStartTime=1724244049248}
> > NumOfSlotsAllocated: 100
> > ```
>
> I think this will still be noisy in a large fleet, especially in the driver logs where users might be looking for other logs/errors. I feel that if truly needed for debugging, the user can then enable debug logging for it.
Maybe print this log to one line can be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1573] Change to debug logging on client side for reserve slots [celeborn]
Posted by "akpatnam25 (via GitHub)" <gi...@apache.org>.
akpatnam25 commented on PR #2700:
URL: https://github.com/apache/celeborn/pull/2700#issuecomment-2303887040
> I think this change can make retrospective debugging hard as we will have no insight into which workers the shuffle data was written to and what was the behaviour of those workers during that time.
>
> Instead of making it completely a debug log IMO we should at least output some basic info about the worker host selected for shuffle this will reduce the noise but also leave some space for debugging issues.
>
> Ex –
>
> ```
> Host: 10.152.63.41
> WorkerStatus: WorkerStatus{state=Normal, stateStartTime=1724244049248}
> NumOfSlotsAllocated: 100
> ```
I think this will still be noisy in a large fleet, especially in the driver logs where users might be looking for other logs/errors. I feel that if truly needed for debugging, the user can then enable debug logging for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1573] Change to debug logging on client side for reserve slots [celeborn]
Posted by "akpatnam25 (via GitHub)" <gi...@apache.org>.
akpatnam25 commented on PR #2700:
URL: https://github.com/apache/celeborn/pull/2700#issuecomment-2302968816
cc @FMX @SteNicholas @mridulm @zhouyejoe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org