[GitHub] [carbondata] manishnalla1994 opened a new pull request #3145: [CARBONDATA-3315] Fix for Range Filter failing with two between clauses as children of OR expression

[GitBox <gi...@apache.org>]

manishnalla1994 opened a new pull request #3145: [CARBONDATA-3315] Fix for Range Filter failing with two between clauses as children of OR expression
URL: https://github.com/apache/carbondata/pull/3145
 
 
   Problem : Range filter with Or and two between clauses as children fails  because while evaluating the Or we combine both the sub-trees into one and then evaluate, which is wrong.
   
   Solution : Instead of combining them we have to treat both the children of 'OR' as different expressions and evaluate separately.
   
   Be sure to do all of the following checklist to help us incorporate 
   your contribution quickly and easily:
   
    - [ ] Any interfaces changed?
    
    - [ ] Any backward compatibility impacted?
    
    - [x] Document update required? No
   
    - [x] Testing done
           Please provide details on 
           - Whether new unit test cases have been added or why no new tests are required?
           - How it is tested? Please attach test report.
           - Is it a performance related change? Please attach the performance test report.
           - Any additional information to help reviewers in testing this change.
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services