You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/04 08:11:25 UTC
[GitHub] [superset] jplanckeel commented on a diff in pull request #20567: feat(helm): add liveness and readiness for deployment webserver
jplanckeel commented on code in PR #20567:
URL: https://github.com/apache/superset/pull/20567#discussion_r912739569
##########
helm/superset/templates/deployment.yaml:
##########
@@ -114,6 +114,24 @@ spec:
- name: http
containerPort: {{ .Values.service.port }}
protocol: TCP
+ livenessProbe:
+ httpGet:
+ path: /health
+ port: {{ .Values.service.port }}
+ initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds | default 15 }}
+ timeoutSeconds: {{ .Values.livenessProbe.timeoutSeconds | default 1 }}
+ failureThreshold: {{ .Values.livenessProbe.failureThreshold | default 3 }}
+ periodSeconds: {{ .Values.livenessProbe.periodSeconds | default 5 }}
+ successThreshold: {{ .Values.livenessProbe.successThreshold | default 1 }}
+ readinessProbe:
+ httpGet:
+ path: /health
+ port: {{ .Values.service.port }}
Review Comment:
Thanks for you comment, i changed these ;)
##########
helm/superset/templates/deployment.yaml:
##########
@@ -114,6 +114,24 @@ spec:
- name: http
containerPort: {{ .Values.service.port }}
protocol: TCP
+ livenessProbe:
+ httpGet:
+ path: /health
+ port: {{ .Values.service.port }}
Review Comment:
Thanks for you comment, i changed these ;)
##########
helm/superset/values.yaml:
##########
@@ -113,6 +113,20 @@ extraVolumeMounts: []
# - name: additionalSecret:
# mountPath: /mnt/secret
+# livenessProbe:
Review Comment:
Thanks for you comment, i changed these ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org