[GitHub] [daffodil-site] stevedlawrence commented on a change in pull request #74: Use the official Jekyll container to build the site

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #74:
URL: https://github.com/apache/daffodil-site/pull/74#discussion_r761291377



##########
File path: .apk
##########
@@ -0,0 +1 @@
+graphviz

Review comment:
       Unfortunately comment don't work. The container does this t install packages from this file
   ```bash
   apk add --no-cache --no-progress $(cat .apk)
   ````
   So any comments aren't processed as comments and are just treated as additional things to install.
   
   We really need the container to do something like this:
   ```bash
   apk add --no-cache --no-progress $(grep -v '^#' .apk)
   ```
   But we can't make that change without updating the container.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org