You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Matthias Weßendorf (JIRA)" <ji...@apache.org> on 2006/06/18 06:11:29 UTC

[jira] Created: (VALIDATOR-191) ISBNValidator has dependency to org.apache.oro.text.perl.Perl5Util

ISBNValidator has dependency to org.apache.oro.text.perl.Perl5Util
------------------------------------------------------------------

         Key: VALIDATOR-191
         URL: http://issues.apache.org/jira/browse/VALIDATOR-191
     Project: Commons Validator
        Type: Improvement

    Versions: 1.3.0 Release, 1.2.0 Release, 1.3.1    
    Reporter: Matthias Weßendorf
    Priority: Minor


Hey,

since Java 1.4 supports RegExpr. itself is it possible to remove the "org.apache.oro.text.perl.Perl5Util"
from ISBNValidator?

The org.apache.oro.** dependency is also there for the regExp validator.

Any ideas on that?
Or is this a "no no", since a Java 1.4 dep. is not suitable.

Thanks,
Matthias

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (VALIDATOR-191) ISBNValidator has dependency to org.apache.oro.text.perl.Perl5Util

Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/VALIDATOR-191?page=comments#action_12418887 ] 

Niall Pemberton commented on VALIDATOR-191:
-------------------------------------------

Need to remove the "/" from the start and end of the regular expression:

    private static final String ISBN_PATTERN =
        "^" + GROUP + SEP + PUBLISHER + SEP + TITLE + SEP + CHECK + "$";


> ISBNValidator has dependency to org.apache.oro.text.perl.Perl5Util
> ------------------------------------------------------------------
>
>          Key: VALIDATOR-191
>          URL: http://issues.apache.org/jira/browse/VALIDATOR-191
>      Project: Commons Validator
>         Type: Improvement

>     Versions: 1.3.0 Release, 1.2.0 Release, 1.3.1
>     Reporter: Matthias Weßendorf
>     Priority: Minor
>  Attachments: isbn_validator.patch
>
> Hey,
> since Java 1.4 supports RegExpr. itself is it possible to remove the "org.apache.oro.text.perl.Perl5Util"
> from ISBNValidator?
> The org.apache.oro.** dependency is also there for the regExp validator.
> Any ideas on that?
> Or is this a "no no", since a Java 1.4 dep. is not suitable.
> Thanks,
> Matthias

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (VALIDATOR-191) ISBNValidator has dependency to org.apache.oro.text.perl.Perl5Util

Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/VALIDATOR-191?page=comments#action_12416667 ] 

Niall Pemberton commented on VALIDATOR-191:
-------------------------------------------

Its not a "no no" - I did a poll of JDK usage back in January and we discussed moving to a JDK 1.4 dependency then:

Move to JDK 1.4: http://tinyurl.com/h3k6j
Poll Result: http://tinyurl.com/h78zf

Since then we have done the Validator 1.3.0 release, so I think we should do this in a Validator 1.4 version (nice coincidence :-)

>From memory though its not just the ISBN validator - there is also the email address and url validators that depend on ORO.

> ISBNValidator has dependency to org.apache.oro.text.perl.Perl5Util
> ------------------------------------------------------------------
>
>          Key: VALIDATOR-191
>          URL: http://issues.apache.org/jira/browse/VALIDATOR-191
>      Project: Commons Validator
>         Type: Improvement

>     Versions: 1.3.0 Release, 1.2.0 Release, 1.3.1
>     Reporter: Matthias Weßendorf
>     Priority: Minor
>  Attachments: isbn_validator.patch
>
> Hey,
> since Java 1.4 supports RegExpr. itself is it possible to remove the "org.apache.oro.text.perl.Perl5Util"
> from ISBNValidator?
> The org.apache.oro.** dependency is also there for the regExp validator.
> Any ideas on that?
> Or is this a "no no", since a Java 1.4 dep. is not suitable.
> Thanks,
> Matthias

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (VALIDATOR-191) ISBNValidator has dependency to org.apache.oro.text.perl.Perl5Util

Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/VALIDATOR-191?page=all ]

Niall Pemberton updated VALIDATOR-191:
--------------------------------------

    Component/s: Routines

> ISBNValidator has dependency to org.apache.oro.text.perl.Perl5Util
> ------------------------------------------------------------------
>
>                 Key: VALIDATOR-191
>                 URL: http://issues.apache.org/jira/browse/VALIDATOR-191
>             Project: Commons Validator
>          Issue Type: Improvement
>          Components: Routines
>    Affects Versions: 1.3.0 Release, 1.2.0 Release, 1.3.1
>            Reporter: Matthias Weßendorf
>            Priority: Minor
>         Attachments: isbn_validator.patch
>
>
> Hey,
> since Java 1.4 supports RegExpr. itself is it possible to remove the "org.apache.oro.text.perl.Perl5Util"
> from ISBNValidator?
> The org.apache.oro.** dependency is also there for the regExp validator.
> Any ideas on that?
> Or is this a "no no", since a Java 1.4 dep. is not suitable.
> Thanks,
> Matthias

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (VALIDATOR-191) ISBNValidator has dependency to org.apache.oro.text.perl.Perl5Util

Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/VALIDATOR-191?page=all ]

Niall Pemberton updated VALIDATOR-191:
--------------------------------------

    Fix Version/s: 1.4.0

> ISBNValidator has dependency to org.apache.oro.text.perl.Perl5Util
> ------------------------------------------------------------------
>
>                 Key: VALIDATOR-191
>                 URL: http://issues.apache.org/jira/browse/VALIDATOR-191
>             Project: Commons Validator
>          Issue Type: Improvement
>          Components: Routines
>    Affects Versions: 1.3.0 Release, 1.2.0 Release, 1.3.1
>            Reporter: Matthias Weßendorf
>            Priority: Minor
>             Fix For: 1.4.0
>
>         Attachments: isbn_validator.patch
>
>
> Hey,
> since Java 1.4 supports RegExpr. itself is it possible to remove the "org.apache.oro.text.perl.Perl5Util"
> from ISBNValidator?
> The org.apache.oro.** dependency is also there for the regExp validator.
> Any ideas on that?
> Or is this a "no no", since a Java 1.4 dep. is not suitable.
> Thanks,
> Matthias

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (VALIDATOR-191) ISBNValidator has dependency to org.apache.oro.text.perl.Perl5Util

Posted by "Matthias Weßendorf (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/VALIDATOR-191?page=all ]

Matthias Weßendorf updated VALIDATOR-191:
-----------------------------------------

    Attachment: isbn_validator.patch

here a patch goes

> ISBNValidator has dependency to org.apache.oro.text.perl.Perl5Util
> ------------------------------------------------------------------
>
>          Key: VALIDATOR-191
>          URL: http://issues.apache.org/jira/browse/VALIDATOR-191
>      Project: Commons Validator
>         Type: Improvement

>     Versions: 1.3.0 Release, 1.2.0 Release, 1.3.1
>     Reporter: Matthias Weßendorf
>     Priority: Minor
>  Attachments: isbn_validator.patch
>
> Hey,
> since Java 1.4 supports RegExpr. itself is it possible to remove the "org.apache.oro.text.perl.Perl5Util"
> from ISBNValidator?
> The org.apache.oro.** dependency is also there for the regExp validator.
> Any ideas on that?
> Or is this a "no no", since a Java 1.4 dep. is not suitable.
> Thanks,
> Matthias

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Commented: (VALIDATOR-191) ISBNValidator has dependency to org.apache.oro.text.perl.Perl5Util

Posted by "Matthias Weßendorf (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/VALIDATOR-191?page=comments#action_12416698 ] 

Matthias Weßendorf commented on VALIDATOR-191:
----------------------------------------------

there are some issues with the ISBNValitator test case for Java .14 RegExpr.
Will take a look at it.

> ISBNValidator has dependency to org.apache.oro.text.perl.Perl5Util
> ------------------------------------------------------------------
>
>          Key: VALIDATOR-191
>          URL: http://issues.apache.org/jira/browse/VALIDATOR-191
>      Project: Commons Validator
>         Type: Improvement

>     Versions: 1.3.0 Release, 1.2.0 Release, 1.3.1
>     Reporter: Matthias Weßendorf
>     Priority: Minor
>  Attachments: isbn_validator.patch
>
> Hey,
> since Java 1.4 supports RegExpr. itself is it possible to remove the "org.apache.oro.text.perl.Perl5Util"
> from ISBNValidator?
> The org.apache.oro.** dependency is also there for the regExp validator.
> Any ideas on that?
> Or is this a "no no", since a Java 1.4 dep. is not suitable.
> Thanks,
> Matthias

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


[jira] Updated: (VALIDATOR-191) Remove the dependency on Jakarta ORO (move to JDK 1.4 regular expression support)

Posted by "Niall Pemberton (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/VALIDATOR-191?page=all ]

Niall Pemberton updated VALIDATOR-191:
--------------------------------------

    Summary: Remove the dependency on Jakarta ORO (move to JDK 1.4 regular expression support)  (was: ISBNValidator has dependency to org.apache.oro.text.perl.Perl5Util)

I'm changing the title of this issue to be more general since there are a number of validation routines using Jakarta ORO.

I have moved and re-written ISBNValidator to the new routines package and the dependency on Jakarta ORO has now gone - see issue# VALIDATOR-188 for details about the new version
   http://svn.apache.org/viewvc?view=rev&revision=486765

Now just need to do URL, Email and "mask" validators :-)

> Remove the dependency on Jakarta ORO (move to JDK 1.4 regular expression support)
> ---------------------------------------------------------------------------------
>
>                 Key: VALIDATOR-191
>                 URL: http://issues.apache.org/jira/browse/VALIDATOR-191
>             Project: Commons Validator
>          Issue Type: Improvement
>          Components: Routines
>    Affects Versions: 1.3.0 Release, 1.2.0 Release, 1.3.1 Release
>            Reporter: Matthias Weßendorf
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: isbn_validator.patch
>
>
> Hey,
> since Java 1.4 supports RegExpr. itself is it possible to remove the "org.apache.oro.text.perl.Perl5Util"
> from ISBNValidator?
> The org.apache.oro.** dependency is also there for the regExp validator.
> Any ideas on that?
> Or is this a "no no", since a Java 1.4 dep. is not suitable.
> Thanks,
> Matthias

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org