[GitHub] [incubator-doris] morningman commented on issue #2208: Return not_acceptable response for stream load when load task is failed

[GitBox <gi...@apache.org>]

morningman commented on issue #2208: Return not_acceptable response for stream load when load task is failed
URL: https://github.com/apache/incubator-doris/pull/2208#issuecomment-554351245
 
 
   > > I don't think this a good idea to return 406 to user instead of 200.
   > > Actually, code 200 only means a http request is received and be processed completely.
   > > The failure of loading process is the business logic, not some HTTP error.
   > > And users should decide what to do based on the status code returend in response body.
   > 
   > ok, in my point of view , most of the case, the status code is ok which means it is as user expected, we don't need to see what the response body is. when http status code is ok, for other users, like the stream load example code (java), may think it is ok, so may cause data lost but user don't know when the stream load is refused by server, i think it is depended on what most of people think what the http status code is used for?
   
   I agree that this is an optional implementation. But unfortunately, it has to be implement at the very beginning. But for now, most of our user are already accepted this pattern of usage. If we change this now, previous users may have to change their program once we upgrade, and this is unacceptable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org