You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/27 16:30:19 UTC

[GitHub] [arrow] jonkeane commented on a diff in pull request #13014: ARROW-16374: [R] [C++] skip another snappy test during sanitizer runs

jonkeane commented on code in PR #13014:
URL: https://github.com/apache/arrow/pull/13014#discussion_r860004786


##########
r/tests/testthat/test-parquet.R:
##########
@@ -197,6 +197,8 @@ test_that("Maps are preserved when writing/reading from Parquet", {
 })
 
 test_that("read_parquet() and write_parquet() accept connection objects", {
+  skip_if_not_available("snappy")

Review Comment:
   Yeah, I've been thinking about how may of these we need + it would be great if we actually tested this with our default and then fell back on sanitizers only. Either compression should be totally fine, but it would be nice to have coverage on both. But we should do that generally. I'll make a Jira for that + we can do that outside of the release pressure. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org