[GitHub] [airflow] SamWheating commented on a change in pull request #18557: Warning of public exposure of deployment in UI with on/off config

[GitBox <gi...@apache.org>]

SamWheating commented on a change in pull request #18557:
URL: https://github.com/apache/airflow/pull/18557#discussion_r717771063



##########
File path: airflow/www/views.py
##########
@@ -3026,6 +3026,14 @@ def tree_data(self):
         # avoid spaces to reduce payload size
         return htmlsafe_json_dumps(tree_data, separators=(',', ':'))
 
+    def warn_deployment_exposure(self):
+        deployment_warning = "Deployment is exposed to public internet"

Review comment:
       Could this message maybe be extended with some useful information?
   
   Maybe something like:
   
   ```
   Recent requests to /robots.txt indicate that this deployment may be accessible to the public internet.
   
   This warning can be disabled by setting webserver.warn_deployment_exposure=False in the configuration.
   ```
   
   We could also link to a page in the docs with more information on webserver security.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org