[jira] [Work logged] (BEAM-5790) Euphoria: Remove Dataset abstraction

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-5790?focusedWorklogId=163374&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-163374 ]

ASF GitHub Bot logged work on BEAM-5790:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Nov/18 08:01
            Start Date: 07/Nov/18 08:01
    Worklog Time Spent: 10m 
      Work Description: je-ik commented on a change in pull request #6750: [BEAM-5790] Euphoria: Remove Dataset abstraction.
URL: https://github.com/apache/beam/pull/6750#discussion_r231408220
 
 

 ##########
 File path: sdks/java/extensions/euphoria/src/test/java/org/apache/beam/sdk/extensions/euphoria/core/testkit/ReduceByKeyTest.java
 ##########
 @@ -487,10 +488,10 @@ public void testMergingAndTriggering() {
   //          }
   //
   //          @Override
-  //          protected Dataset<Triple<TimeInterval, Integer, Set<String>>> getOutput(
-  //              Dataset<KV<String, Integer>> input) {
+  //          protected PCollection<Triple<TimeInterval, Integer, Set<String>>> getOutput(
+  //              PCollection<KV<String, Integer>> input) {
   //            input = AssignEventTime.of(input).using(KV::getValue).output();
-  //            Dataset<KV<Integer, Set<String>>> reduced =
+  //            PCollection<KV<Integer, Set<String>>> reduced =
   //                ReduceByKey.of(input)
   //                    .keyBy(e -> e.getKey().charAt(0) - '0')
   //                    .valueBy(KV::getKey)
 
 Review comment:
   Same here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 163374)
    Time Spent: 1h  (was: 50m)

> Euphoria: Remove Dataset abstraction
> ------------------------------------
>
>                 Key: BEAM-5790
>                 URL: https://issues.apache.org/jira/browse/BEAM-5790
>             Project: Beam
>          Issue Type: Sub-task
>          Components: dsl-euphoria
>    Affects Versions: Not applicable
>            Reporter: David Moravek
>            Assignee: David Moravek
>            Priority: Major
>             Fix For: 2.9.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> There is no point of having Dataset abstraction anymore. We can use PCollections directly and provide more seamless experience to the end user.
> Euphoria did not yet make it to any release, so this is probably the last chance to get rid of the Dataset abstraction, because this would introduce a huge breaking change.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)