You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by gr...@apache.org on 2021/06/22 16:28:54 UTC
[superset] branch revert-15109-gg-FixSqlLabResults created (now
9177c6c)
This is an automated email from the ASF dual-hosted git repository.
graceguo pushed a change to branch revert-15109-gg-FixSqlLabResults
in repository https://gitbox.apache.org/repos/asf/superset.git.
at 9177c6c Revert "fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)"
This branch includes the following new commits:
new 9177c6c Revert "fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)"
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[superset] 01/01: Revert "fix: SQL Lab show "Refetch Results"
button while fetching new query results (#15109)"
Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
graceguo pushed a commit to branch revert-15109-gg-FixSqlLabResults
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 9177c6cf9a3f1ec6b53d0b72ec389dbe51768f47
Author: Grace Guo <gr...@airbnb.com>
AuthorDate: Tue Jun 22 09:28:07 2021 -0700
Revert "fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)"
This reverts commit 408d58f937a544190ca64d13942a6a7b04b95615.
---
superset-frontend/src/SqlLab/reducers/sqlLab.js | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/superset-frontend/src/SqlLab/reducers/sqlLab.js b/superset-frontend/src/SqlLab/reducers/sqlLab.js
index ec84381..daa06a9 100644
--- a/superset-frontend/src/SqlLab/reducers/sqlLab.js
+++ b/superset-frontend/src/SqlLab/reducers/sqlLab.js
@@ -517,20 +517,7 @@ export default function sqlLabReducer(state = {}, action) {
if (changedQuery.changedOn > queriesLastUpdate) {
queriesLastUpdate = changedQuery.changedOn;
}
- const prevState = state.queries[id].state;
- const currentState = changedQuery.state;
- newQueries[id] = {
- ...state.queries[id],
- ...changedQuery,
- // race condition:
- // because of async behavior, sql lab may still poll a couple of seconds
- // when it started fetching or finished rendering results
- state:
- currentState === 'success' &&
- ['fetching', 'success'].includes(prevState)
- ? prevState
- : currentState,
- };
+ newQueries[id] = { ...state.queries[id], ...changedQuery };
change = true;
}
});