You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/19 09:02:24 UTC
[GitHub] [spark] hvanhovell opened a new pull request #27635:
[SPARK-30811][SQL] CTE should not cause stack overflow when it refers to
non-existent table with same name
hvanhovell opened a new pull request #27635: [SPARK-30811][SQL] CTE should not cause stack overflow when it refers to non-existent table with same name
URL: https://github.com/apache/spark/pull/27635
### Why are the changes needed?
This ports the tests introduced in https://github.com/apache/spark/commit/7285eea6839d40cbac15101c633a9a572eb3b603 to master to avoid future regressions.
### Background
A query with Common Table Expressions can cause a stack overflow when it contains a CTE that refers a non-existing table with the same name. The name of the table need to have a database qualifier. This is caused by a couple of things:
- CTESubstitution runs analysis on the CTE, but this does not throw an exception because the table has a database qualifier. The reason is that we don't fail is because we re-attempt to resolve the relation in a later rule;
- CTESubstitution replace logic does not check if the table it is replacing has a database, it shouldn't replace the relation if it does. So now we will happily replace nonexist.t with t;
Note that this not an issue for master or the spark-3.0 branch.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
Added regression test to `AnalysisErrorSuite` and `DataFrameSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27635:
[SPARK-30811][SQL] CTE should not cause stack overflow when it refers to
non-existent table with same name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27635: [SPARK-30811][SQL] CTE should not cause stack overflow when it refers to non-existent table with same name
URL: https://github.com/apache/spark/pull/27635#issuecomment-588113495
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27635: [SPARK-30811][SQL]
CTE should not cause stack overflow when it refers to non-existent table
with same name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27635: [SPARK-30811][SQL] CTE should not cause stack overflow when it refers to non-existent table with same name
URL: https://github.com/apache/spark/pull/27635#issuecomment-588240743
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27635: [SPARK-30811][SQL] CTE
should not cause stack overflow when it refers to non-existent table with
same name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27635: [SPARK-30811][SQL] CTE should not cause stack overflow when it refers to non-existent table with same name
URL: https://github.com/apache/spark/pull/27635#issuecomment-588112862
**[Test build #118671 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118671/testReport)** for PR 27635 at commit [`d38d874`](https://github.com/apache/spark/commit/d38d874f15287e2c40eb93145d6e112adb9076ca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27635: [SPARK-30811][SQL]
CTE should not cause stack overflow when it refers to non-existent table
with same name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27635: [SPARK-30811][SQL] CTE should not cause stack overflow when it refers to non-existent table with same name
URL: https://github.com/apache/spark/pull/27635#issuecomment-588113505
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23423/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27635: [SPARK-30811][SQL] CTE
should not cause stack overflow when it refers to non-existent table with
same name
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27635: [SPARK-30811][SQL] CTE should not cause stack overflow when it refers to non-existent table with same name
URL: https://github.com/apache/spark/pull/27635#issuecomment-588239741
**[Test build #118671 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118671/testReport)** for PR 27635 at commit [`d38d874`](https://github.com/apache/spark/commit/d38d874f15287e2c40eb93145d6e112adb9076ca).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27635:
[SPARK-30811][SQL] CTE should not cause stack overflow when it refers to
non-existent table with same name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27635: [SPARK-30811][SQL] CTE should not cause stack overflow when it refers to non-existent table with same name
URL: https://github.com/apache/spark/pull/27635#issuecomment-588113505
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23423/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27635:
[SPARK-30811][SQL] CTE should not cause stack overflow when it refers to
non-existent table with same name
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27635: [SPARK-30811][SQL] CTE should not cause stack overflow when it refers to non-existent table with same name
URL: https://github.com/apache/spark/pull/27635#issuecomment-588112862
**[Test build #118671 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118671/testReport)** for PR 27635 at commit [`d38d874`](https://github.com/apache/spark/commit/d38d874f15287e2c40eb93145d6e112adb9076ca).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27635:
[SPARK-30811][SQL] CTE should not cause stack overflow when it refers to
non-existent table with same name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27635: [SPARK-30811][SQL] CTE should not cause stack overflow when it refers to non-existent table with same name
URL: https://github.com/apache/spark/pull/27635#issuecomment-588240756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118671/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27635:
[SPARK-30811][SQL] CTE should not cause stack overflow when it refers to
non-existent table with same name
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27635: [SPARK-30811][SQL] CTE should not cause stack overflow when it refers to non-existent table with same name
URL: https://github.com/apache/spark/pull/27635
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27635: [SPARK-30811][SQL]
CTE should not cause stack overflow when it refers to non-existent table
with same name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27635: [SPARK-30811][SQL] CTE should not cause stack overflow when it refers to non-existent table with same name
URL: https://github.com/apache/spark/pull/27635#issuecomment-588113495
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27635: [SPARK-30811][SQL]
CTE should not cause stack overflow when it refers to non-existent table
with same name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27635: [SPARK-30811][SQL] CTE should not cause stack overflow when it refers to non-existent table with same name
URL: https://github.com/apache/spark/pull/27635#issuecomment-588240756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118671/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27635:
[SPARK-30811][SQL] CTE should not cause stack overflow when it refers to
non-existent table with same name
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27635: [SPARK-30811][SQL] CTE should not cause stack overflow when it refers to non-existent table with same name
URL: https://github.com/apache/spark/pull/27635#issuecomment-588240743
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org