You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2012/06/21 18:21:43 UTC
[jira] [Created] (LUCENE-4162) MathUtil is publiuc and checks
parameter only with assert. Incorrect usage can easily lead to endless loop
Uwe Schindler created LUCENE-4162:
-------------------------------------
Summary: MathUtil is publiuc and checks parameter only with assert. Incorrect usage can easily lead to endless loop
Key: LUCENE-4162
URL: https://issues.apache.org/jira/browse/LUCENE-4162
Project: Lucene - Java
Issue Type: Bug
Reporter: Uwe Schindler
Priority: Critical
We should check the 2 parameters carefully before entering the loop. Those checks here cost nothing.
Otherwise this class must be hidden, we should not offer any public method to the users that can loop infinite without parameter checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4162) MathUtil is publiuc and checks
parameter only with assert. Incorrect usage can easily lead to endless loop
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-4162:
----------------------------------
Component/s: core/other
Affects Version/s: 5.0
4.0
Fix Version/s: 5.0
4.0
Assignee: Uwe Schindler
> MathUtil is publiuc and checks parameter only with assert. Incorrect usage can easily lead to endless loop
> ----------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4162
> URL: https://issues.apache.org/jira/browse/LUCENE-4162
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/other
> Affects Versions: 4.0, 5.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Critical
> Fix For: 4.0, 5.0
>
>
> We should check the 2 parameters carefully before entering the loop. Those checks here cost nothing.
> Otherwise this class must be hidden, we should not offer any public method to the users that can loop infinite without parameter checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-4162) MathUtil is publiuc and checks
parameter only with assert. Incorrect usage can easily lead to endless loop
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-4162.
-----------------------------------
Resolution: Fixed
Committed trunk revision: 1352609
Committed 4.x revision: 1352613
> MathUtil is publiuc and checks parameter only with assert. Incorrect usage can easily lead to endless loop
> ----------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4162
> URL: https://issues.apache.org/jira/browse/LUCENE-4162
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/other
> Affects Versions: 4.0, 5.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Critical
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4162.patch
>
>
> We should check the 2 parameters carefully before entering the loop. Those checks here cost nothing.
> Otherwise this class must be hidden, we should not offer any public method to the users that can loop infinite without parameter checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4162) MathUtil is publiuc and checks
parameter only with assert. Incorrect usage can easily lead to endless loop
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-4162:
----------------------------------
Attachment: LUCENE-4162.patch
Path, will commit soon.
> MathUtil is publiuc and checks parameter only with assert. Incorrect usage can easily lead to endless loop
> ----------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4162
> URL: https://issues.apache.org/jira/browse/LUCENE-4162
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/other
> Affects Versions: 4.0, 5.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Critical
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4162.patch
>
>
> We should check the 2 parameters carefully before entering the loop. Those checks here cost nothing.
> Otherwise this class must be hidden, we should not offer any public method to the users that can loop infinite without parameter checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4162) MathUtil is publiuc and checks
parameter only with assert. Incorrect usage can easily lead to endless loop
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13398566#comment-13398566 ]
Michael McCandless commented on LUCENE-4162:
--------------------------------------------
+1 thanks Uwe!
> MathUtil is publiuc and checks parameter only with assert. Incorrect usage can easily lead to endless loop
> ----------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-4162
> URL: https://issues.apache.org/jira/browse/LUCENE-4162
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/other
> Affects Versions: 4.0, 5.0
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Critical
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4162.patch
>
>
> We should check the 2 parameters carefully before entering the loop. Those checks here cost nothing.
> Otherwise this class must be hidden, we should not offer any public method to the users that can loop infinite without parameter checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org