[GitHub] mbeckerle commented on a change in pull request #162: Properly handle malformed binding files

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #162: Properly handle malformed binding files
URL: https://github.com/apache/incubator-daffodil/pull/162#discussion_r246178739
 
 

 ##########
 File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/externalvars/ExternalVariablesLoader.scala
 ##########
 @@ -83,7 +84,13 @@ object ExternalVariablesLoader {
   // return the mutated map.
 
   def loadVariables(vars: Map[String, String], referringContext: ThrowsSDE, vmap: VariableMap): VariableMap = {
-    val bindings = getVariables(vars)
+    val bindings = try {
+      getVariables(vars)
+    } catch {
+      case qupe: QNameUndefinedPrefixException => referringContext.SDE(qupe.getMessage)
 
 Review comment:
   And here, and couple other places below too. Should just be one case. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services