You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/03/11 13:38:59 UTC

[GitHub] [mynewt-nimble] utzig commented on issue #768: Added advertiser, scanner, peripheral and central to apps

utzig commented on issue #768: Added advertiser, scanner, peripheral and central to apps
URL: https://github.com/apache/mynewt-nimble/pull/768#issuecomment-597640555
 
 
   I don't usually review nimble PRs, but since this was opened in mynewt-core before I was a bit curious. So there are some things like functions with `name(void)` vs `name()` (with no type), `case` not aligned below the `switch`, etc. I don't have strong preferences on style but I like consistency. @sjanc @andrzej-kaczmarek @rymanluk Is nimble following the same style that core uses? In that case maybe it would be interesting to add the style checker here as well!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services