You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/13 08:18:16 UTC

[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2938: [SeaTunnel][Flink]use PrimitiveArrayTypeInfo replace basictypeinfo.

hailin0 commented on code in PR #2938:
URL: https://github.com/apache/incubator-seatunnel/pull/2938#discussion_r994310761


##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-mongodb-flink-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/mongodb/MongodbIT.java:
##########
@@ -175,7 +174,6 @@ private static List<Document> generateTestDataSet() {
             new SeaTunnelDataType[]{
                 BasicType.LONG_TYPE,
                 new MapType(BasicType.STRING_TYPE, BasicType.SHORT_TYPE),
-                ArrayType.BYTE_ARRAY_TYPE,

Review Comment:
   update to
   -> ArrayType.SHORT_ARRAY_TYPE,



##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-mongodb-flink-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/mongodb/MongodbIT.java:
##########
@@ -158,7 +158,6 @@ private static List<Document> generateTestDataSet() {
             new String[]{
                 "id",
                 "c_map",
-                "c_array",

Review Comment:
   revert？



##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-mongodb-flink-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/mongodb/MongodbIT.java:
##########
@@ -198,7 +196,6 @@ private static List<Document> generateTestDataSet() {
                 new Object[]{
                     Long.valueOf(i),
                     Collections.singletonMap("key", Short.parseShort("1")),
-                    new Byte[]{Byte.parseByte("1")},

Review Comment:
   -> new Short[]{Short.parseShort("1")},



##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-mongodb-flink-e2e/src/test/resources/mongodb/mongodb_source_and_sink.conf:
##########
@@ -36,7 +36,6 @@ source {
       fields {
         id = bigint
         c_map = "map<string, smallint>"
-        c_array = "array<tinyint>"

Review Comment:
   -> `array<smallint>`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org