You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/17 03:08:45 UTC

[GitHub] [skywalking-python] wuchengyi2006 opened a new pull request #105: Fix Reconnect when report has an exception occurs

wuchengyi2006 opened a new pull request #105:
URL: https://github.com/apache/skywalking-python/pull/105


   <!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
   <!--
   - [ ] Add a test case for the new plugin
   - [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
   - [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
   - [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] wuchengyi2006 closed pull request #105: Fix Reconnect when report has an exception occurs

Posted by GitBox <gi...@apache.org>.
wuchengyi2006 closed pull request #105:
URL: https://github.com/apache/skywalking-python/pull/105


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] kezhenxu94 commented on pull request #105: Fix Reconnect when report has an exception occurs

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #105:
URL: https://github.com/apache/skywalking-python/pull/105#issuecomment-747179648


   Hey @wuchengyi2006 , thanks! The exception should be caught here https://github.com/apache/skywalking-python/blob/37edeba1d4cab668e9ab21fd00b3be1b5ec8c18d/skywalking/agent/protocol/grpc.py#L121-L124
   
   which version are you using and what exception did you encounter that is not caught by 👆


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] wuchengyi2006 commented on pull request #105: Fix Reconnect when report has an exception occurs

Posted by GitBox <gi...@apache.org>.
wuchengyi2006 commented on pull request #105:
URL: https://github.com/apache/skywalking-python/pull/105#issuecomment-747888833


   > Hey @wuchengyi2006 , thanks! The exception should be caught here
   > 
   > https://github.com/apache/skywalking-python/blob/37edeba1d4cab668e9ab21fd00b3be1b5ec8c18d/skywalking/agent/protocol/grpc.py#L121-L124
   > 
   > which version are you using and what exception did you encounter that is not caught by 👆
   
   Great,My version maybe is too old,It seems that the problem has been solved！


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] kezhenxu94 commented on pull request #105: Fix Reconnect when report has an exception occurs

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #105:
URL: https://github.com/apache/skywalking-python/pull/105#issuecomment-747897914


   Thanks for confirmation


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org